Commit c09063a5 authored by Rayan Kanso's avatar Rayan Kanso Committed by Commit Bot

[Background Fetch] Fix UpdateUI icon update.

The JobDetails were being deleted before the OIC could query for the updated visuals.
The breaking change was not merged into M71.

Change-Id: I8dcbaa5916001198006a3550c3bfc337436d62cf
Reviewed-on: https://chromium-review.googlesource.com/c/1333807Reviewed-by: default avatarPeter Beverloo <peter@chromium.org>
Reviewed-by: default avatarMugdha Lakhani <nator@chromium.org>
Commit-Queue: Rayan Kanso <rayankans@chromium.org>
Cr-Commit-Position: refs/heads/master@{#607961}
parent f39ae5fc
...@@ -340,10 +340,6 @@ void BackgroundFetchDelegateImpl::UpdateUI( ...@@ -340,10 +340,6 @@ void BackgroundFetchDelegateImpl::UpdateUI(
} }
UpdateOfflineItemAndUpdateObservers(&job_details); UpdateOfflineItemAndUpdateObservers(&job_details);
// UpdateUI() can only be called once, and only when the background fetch
// has succeeded or failed, so we can delete |job_details| now.
job_details_map_.erase(job_details_iter);
} }
void BackgroundFetchDelegateImpl::OnDownloadStarted( void BackgroundFetchDelegateImpl::OnDownloadStarted(
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment