Commit c0b760ab authored by Yang Guo's avatar Yang Guo Committed by Commit Bot

Remove uses of V8's function entry hook.

Bug: v8:8503,821764
Change-Id: I0b541e06f0326f8270e14e0b7a685cab3c288882
Reviewed-on: https://chromium-review.googlesource.com/c/1350177Reviewed-by: default avatarNico Weber <thakis@chromium.org>
Reviewed-by: default avatarRoss McIlroy <rmcilroy@chromium.org>
Commit-Queue: Yang Guo <yangguo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611032}
parent 8bab8f77
...@@ -98,10 +98,6 @@ ReturnAddressLocationResolver GetProfilerReturnAddrResolutionFunc() { ...@@ -98,10 +98,6 @@ ReturnAddressLocationResolver GetProfilerReturnAddrResolutionFunc() {
return nullptr; return nullptr;
} }
DynamicFunctionEntryHook GetProfilerDynamicFunctionEntryHookFunc() {
return nullptr;
}
AddDynamicSymbol GetProfilerAddDynamicSymbolFunc() { AddDynamicSymbol GetProfilerAddDynamicSymbolFunc() {
return nullptr; return nullptr;
} }
...@@ -174,11 +170,6 @@ ReturnAddressLocationResolver GetProfilerReturnAddrResolutionFunc() { ...@@ -174,11 +170,6 @@ ReturnAddressLocationResolver GetProfilerReturnAddrResolutionFunc() {
"ResolveReturnAddressLocation"); "ResolveReturnAddressLocation");
} }
DynamicFunctionEntryHook GetProfilerDynamicFunctionEntryHookFunc() {
return FindFunctionInImports<DynamicFunctionEntryHook>(
"OnDynamicFunctionEntry");
}
AddDynamicSymbol GetProfilerAddDynamicSymbolFunc() { AddDynamicSymbol GetProfilerAddDynamicSymbolFunc() {
return FindFunctionInImports<AddDynamicSymbol>( return FindFunctionInImports<AddDynamicSymbol>(
"AddDynamicSymbol"); "AddDynamicSymbol");
......
...@@ -56,20 +56,6 @@ BASE_EXPORT bool IsProfilingSupported(); ...@@ -56,20 +56,6 @@ BASE_EXPORT bool IsProfilingSupported();
typedef uintptr_t (*ReturnAddressLocationResolver)( typedef uintptr_t (*ReturnAddressLocationResolver)(
uintptr_t return_addr_location); uintptr_t return_addr_location);
// This type declaration must match V8's FunctionEntryHook.
typedef void (*DynamicFunctionEntryHook)(uintptr_t function,
uintptr_t return_addr_location);
// The functions below here are to support profiling V8-generated code.
// V8 has provisions for generating a call to an entry hook for newly generated
// JIT code, and it can push symbol information on code generation and advise
// when the garbage collector moves code. The functions declarations below here
// make glue between V8's facilities and a profiler.
// This type declaration must match V8's FunctionEntryHook.
typedef void (*DynamicFunctionEntryHook)(uintptr_t function,
uintptr_t return_addr_location);
typedef void (*AddDynamicSymbol)(const void* address, typedef void (*AddDynamicSymbol)(const void* address,
size_t length, size_t length,
const char* name, const char* name,
...@@ -81,7 +67,6 @@ typedef void (*MoveDynamicSymbol)(const void* address, const void* new_address); ...@@ -81,7 +67,6 @@ typedef void (*MoveDynamicSymbol)(const void* address, const void* new_address);
// for each of those purposes, find and return the function in question. // for each of those purposes, find and return the function in question.
// Otherwise returns NULL. // Otherwise returns NULL.
BASE_EXPORT ReturnAddressLocationResolver GetProfilerReturnAddrResolutionFunc(); BASE_EXPORT ReturnAddressLocationResolver GetProfilerReturnAddrResolutionFunc();
BASE_EXPORT DynamicFunctionEntryHook GetProfilerDynamicFunctionEntryHookFunc();
BASE_EXPORT AddDynamicSymbol GetProfilerAddDynamicSymbolFunc(); BASE_EXPORT AddDynamicSymbol GetProfilerAddDynamicSymbolFunc();
BASE_EXPORT MoveDynamicSymbol GetProfilerMoveDynamicSymbolFunc(); BASE_EXPORT MoveDynamicSymbol GetProfilerMoveDynamicSymbolFunc();
......
...@@ -7,7 +7,6 @@ ...@@ -7,7 +7,6 @@
namespace gin { namespace gin {
namespace { namespace {
v8::FunctionEntryHook g_entry_hook = NULL;
v8::JitCodeEventHandler g_jit_code_event_handler = NULL; v8::JitCodeEventHandler g_jit_code_event_handler = NULL;
#if defined(OS_WIN) #if defined(OS_WIN)
Debug::CodeRangeCreatedCallback g_code_range_created_callback = NULL; Debug::CodeRangeCreatedCallback g_code_range_created_callback = NULL;
...@@ -15,11 +14,6 @@ Debug::CodeRangeDeletedCallback g_code_range_deleted_callback = NULL; ...@@ -15,11 +14,6 @@ Debug::CodeRangeDeletedCallback g_code_range_deleted_callback = NULL;
#endif #endif
} // namespace } // namespace
// static
void Debug::SetFunctionEntryHook(v8::FunctionEntryHook entry_hook) {
g_entry_hook = entry_hook;
}
// static // static
void Debug::SetJitCodeEventHandler(v8::JitCodeEventHandler event_handler) { void Debug::SetJitCodeEventHandler(v8::JitCodeEventHandler event_handler) {
g_jit_code_event_handler = event_handler; g_jit_code_event_handler = event_handler;
...@@ -37,11 +31,6 @@ void Debug::SetCodeRangeDeletedCallback(CodeRangeDeletedCallback callback) { ...@@ -37,11 +31,6 @@ void Debug::SetCodeRangeDeletedCallback(CodeRangeDeletedCallback callback) {
} }
#endif #endif
// static
v8::FunctionEntryHook DebugImpl::GetFunctionEntryHook() {
return g_entry_hook;
}
// static // static
v8::JitCodeEventHandler DebugImpl::GetJitCodeEventHandler() { v8::JitCodeEventHandler DebugImpl::GetJitCodeEventHandler() {
return g_jit_code_event_handler; return g_jit_code_event_handler;
......
...@@ -12,7 +12,6 @@ namespace gin { ...@@ -12,7 +12,6 @@ namespace gin {
class DebugImpl { class DebugImpl {
public: public:
static v8::FunctionEntryHook GetFunctionEntryHook();
static v8::JitCodeEventHandler GetJitCodeEventHandler(); static v8::JitCodeEventHandler GetJitCodeEventHandler();
#if defined(OS_WIN) #if defined(OS_WIN)
static Debug::CodeRangeCreatedCallback GetCodeRangeCreatedCallback(); static Debug::CodeRangeCreatedCallback GetCodeRangeCreatedCallback();
......
...@@ -71,7 +71,6 @@ IsolateHolder::IsolateHolder( ...@@ -71,7 +71,6 @@ IsolateHolder::IsolateHolder(
DCHECK_EQ(isolate_, snapshot_creator_->GetIsolate()); DCHECK_EQ(isolate_, snapshot_creator_->GetIsolate());
} else { } else {
v8::Isolate::CreateParams params; v8::Isolate::CreateParams params;
params.entry_hook = DebugImpl::GetFunctionEntryHook();
params.code_event_handler = DebugImpl::GetJitCodeEventHandler(); params.code_event_handler = DebugImpl::GetJitCodeEventHandler();
params.constraints.ConfigureDefaults( params.constraints.ConfigureDefaults(
base::SysInfo::AmountOfPhysicalMemory(), base::SysInfo::AmountOfPhysicalMemory(),
......
...@@ -15,14 +15,6 @@ namespace gin { ...@@ -15,14 +15,6 @@ namespace gin {
class GIN_EXPORT Debug { class GIN_EXPORT Debug {
public: public:
/* Installs a callback that is invoked on entry to every V8-generated
* function.
*
* This only affects IsolateHolder instances created after
* SetFunctionEntryHook was invoked.
*/
static void SetFunctionEntryHook(v8::FunctionEntryHook entry_hook);
/* Installs a callback that is invoked each time jit code is added, moved, /* Installs a callback that is invoked each time jit code is added, moved,
* or removed. * or removed.
* *
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment