Commit c0f2c2d4 authored by David Schinazi's avatar David Schinazi Committed by Commit Bot

Add smallest_observed to QUIC ACK frame netlog

This information was incorrectly missing.

R=nharper@chromium.org

Bug: 1112925
Change-Id: I17643ebaeee02eb9d5e63f0630bce66939a3e536
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2337542
Auto-Submit: David Schinazi <dschinazi@chromium.org>
Reviewed-by: default avatarNick Harper <nharper@chromium.org>
Commit-Queue: David Schinazi <dschinazi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#795045}
parent f735fad5
...@@ -154,16 +154,22 @@ base::Value NetLogQuicAckFrameParams(const quic::QuicAckFrame* frame) { ...@@ -154,16 +154,22 @@ base::Value NetLogQuicAckFrameParams(const quic::QuicAckFrame* frame) {
NetLogNumberValue(frame->ack_delay_time.ToMicroseconds())); NetLogNumberValue(frame->ack_delay_time.ToMicroseconds()));
base::Value missing(base::Value::Type::LIST); base::Value missing(base::Value::Type::LIST);
quic::QuicPacketNumber smallest_observed;
if (!frame->packets.Empty()) { if (!frame->packets.Empty()) {
// V34 and above express acked packets, but only print // V34 and above express acked packets, but only print
// missing packets, because it's typically a shorter list. // missing packets, because it's typically a shorter list.
for (quic::QuicPacketNumber packet = frame->packets.Min(); smallest_observed = frame->packets.Min();
for (quic::QuicPacketNumber packet = smallest_observed;
packet < frame->largest_acked; ++packet) { packet < frame->largest_acked; ++packet) {
if (!frame->packets.Contains(packet)) { if (!frame->packets.Contains(packet)) {
missing.Append(NetLogNumberValue(packet.ToUint64())); missing.Append(NetLogNumberValue(packet.ToUint64()));
} }
} }
} else {
smallest_observed = frame->largest_acked;
} }
dict.SetKey("smallest_observed",
NetLogNumberValue(smallest_observed.ToUint64()));
dict.SetKey("missing_packets", std::move(missing)); dict.SetKey("missing_packets", std::move(missing));
base::Value received(base::Value::Type::LIST); base::Value received(base::Value::Type::LIST);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment