Commit c0fe960d authored by Francois Doray's avatar Francois Doray Committed by Commit Bot

[PM] Remove TODO about filtering out late lifecycle state changes.

As documented at
https://cs.chromium.org/chromium/src/components/performance_manager/graph/frame_node_impl.h?l=215&rcl=2b413514ddc9679893b20235eb2cecbbca4d8245,
lifecycle state of a frame/page is updated independently from
navigations. There is no need to filter out updates generated prior
to the last navigation.

Bug: 857472
Change-Id: Ifd64c437349ed218847a6ca4486b8cd0248fb375
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1869473
Commit-Queue: Sigurður Ásgeirsson <siggi@chromium.org>
Auto-Submit: François Doray <fdoray@chromium.org>
Reviewed-by: default avatarSigurður Ásgeirsson <siggi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#707813}
parent 35b48b90
...@@ -407,9 +407,9 @@ void TabLifecycleUnitSource::OnLifecycleStateChanged( ...@@ -407,9 +407,9 @@ void TabLifecycleUnitSource::OnLifecycleStateChanged(
performance_manager::mojom::LifecycleState state) { performance_manager::mojom::LifecycleState state) {
TabLifecycleUnit* lifecycle_unit = GetTabLifecycleUnit(web_contents); TabLifecycleUnit* lifecycle_unit = GetTabLifecycleUnit(web_contents);
// Some WebContents aren't attached to a tab, so there is no corresponding // Lifecycle state is updated independently from navigations. Therefore, there
// TabLifecycleUnit. // is no need to filter out the event if it was generated before the last
// TODO(fdoray): This may want to filter for the navigation_id. // navigation.
if (lifecycle_unit) if (lifecycle_unit)
lifecycle_unit->UpdateLifecycleState(state); lifecycle_unit->UpdateLifecycleState(state);
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment