build: Remove a few more now-no-op set_sources_assignment_filter calls

After https://chromium-review.googlesource.com/c/chromium/src/+/2426564,
not having a sources assignments filter is the default.

No behavior change.

Bug: 1018739
Change-Id: I6e0e4aa4499d7a99908a63851b899c639543a3b8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2443690
Commit-Queue: Nico Weber <thakis@chromium.org>
Commit-Queue: Scott Violet <sky@chromium.org>
Auto-Submit: Nico Weber <thakis@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#813004}

chromeos/lacros/BUILD.gn

@@ -10,12 +10,6 @@ import("//build/lacros/lacros_resource_sizes.gni")
 assert(chromeos_is_browser_only)
 assert(!use_gtk)
 
-# Reset sources_assignment_filter for the BUILD.gn file to prevent
-# regression during the migration of Chromium away from the feature.
-# See docs/no_sources_assignment_filter.md for more information.
-# TODO(crbug.com/1018739): remove this when migration is done.
-set_sources_assignment_filter([])
-
 component("lacros") {
   defines = [ "IS_CHROMEOS_LACROS_IMPL" ]
   deps = [

crypto/BUILD.gn

@@ -5,12 +5,6 @@
 import("//build/config/crypto.gni")
 import("//testing/test.gni")
 
-# Reset sources_assignment_filter for the BUILD.gn file to prevent
-# regression during the migration of Chromium away from the feature.
-# See docs/no_sources_assignment_filter.md for more information.
-# TODO(crbug.com/1018739): remove this when migration is done.
-set_sources_assignment_filter([])
-
 component("crypto") {
   output_name = "crcrypto"  # Avoid colliding with OpenSSL's libcrypto.
   sources = [

ipc/BUILD.gn

@@ -10,12 +10,6 @@ import("//testing/test.gni")
 import("//third_party/protobuf/proto_library.gni")
 import("//tools/ipc_fuzzer/ipc_fuzzer.gni")
 
-# Reset sources_assignment_filter for the BUILD.gn file to prevent
-# regression during the migration of Chromium away from the feature.
-# See docs/no_sources_assignment_filter.md for more information.
-# TODO(crbug.com/1018739): remove this when migration is done.
-set_sources_assignment_filter([])
-
 buildflag_header("ipc_buildflags") {
   header = "ipc_buildflags.h"
 

net/BUILD.gn

@@ -103,12 +103,6 @@ if (is_linux || is_chromeos) {
   net_configs += [ "//build/config/linux:libresolv" ]
 }
 
-# Reset sources_assignment_filter for the BUILD.gn file to prevent
-# regression during the migration of Chromium away from the feature.
-# See docs/no_sources_assignment_filter.md for more information.
-# TODO(crbug.com/1018739): Remove this when migration is done.
-set_sources_assignment_filter([])
-
 source_set("constants") {
   sources = [ "base/trace_constants.h" ]
   deps = [ "//base" ]

net/dns/BUILD.gn

@@ -5,12 +5,6 @@
 import("//net/features.gni")
 import("//testing/libfuzzer/fuzzer_test.gni")
 
-# Reset sources_assignment_filter for the BUILD.gn file to prevent
-# regression during the migration of Chromium away from the feature.
-# See docs/no_sources_assignment_filter.md for more information.
-# TODO(crbug.com/1018739): remove this when migration is done.
-set_sources_assignment_filter([])
-
 enable_built_in_dns = !is_ios
 
 source_set("dns") {

printing/BUILD.gn

@@ -18,12 +18,6 @@ if (use_cups && is_chromeos) {
   import("//printing/backend/tools/code_generator.gni")
 }
 
-# Reset sources_assignment_filter for the BUILD.gn file to prevent
-# regression during the migration of Chromium away from the feature.
-# See docs/no_sources_assignment_filter.md for more information.
-# TODO(crbug.com/1018739): remove this when migration is done.
-set_sources_assignment_filter([])
-
 if ((enable_basic_printing && is_win) || enable_print_preview) {
   # Windows basic printing or print preview requires pdf enabled.
   assert(enable_pdf,

remoting/base/BUILD.gn

@@ -4,12 +4,6 @@
 
 import("//third_party/protobuf/proto_library.gni")
 
-# Reset sources_assignment_filter for the BUILD.gn file to prevent
-# regression during the migration of Chromium away from the feature.
-# See docs/no_sources_assignment_filter.md for more information.
-# TODO(crbug.com/1018739): remove this when migration is done.
-set_sources_assignment_filter([])
-
 proto_library("protobuf_http_client_messages_proto") {
   sources = [ "protobuf_http_client_messages.proto" ]
 }

remoting/client/audio/BUILD.gn

@@ -2,12 +2,6 @@
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
-# Reset sources_assignment_filter for the BUILD.gn file to prevent
-# regression during the migration of Chromium away from the feature.
-# See docs/no_sources_assignment_filter.md for more information.
-# TODO(crbug.com/1018739): remove this when migration is done.
-set_sources_assignment_filter([])
-
 source_set("audio") {
   sources = [
     "async_audio_data_supplier.cc",

remoting/client/input/BUILD.gn

@@ -2,12 +2,6 @@
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
-# Reset sources_assignment_filter for the BUILD.gn file to prevent
-# regression during the migration of Chromium away from the feature.
-# See docs/no_sources_assignment_filter.md for more information.
-# TODO(crbug.com/1018739): remove this when migration is done.
-set_sources_assignment_filter([])
-
 source_set("input") {
   sources = [
     "client_input_injector.h",

rlz/BUILD.gn

@@ -8,12 +8,6 @@
 import("//rlz/buildflags/buildflags.gni")
 import("//testing/test.gni")
 
-# Reset sources_assignment_filter for the BUILD.gn file to prevent
-# regression during the migration of Chromium away from the feature.
-# See docs/no_sources_assignment_filter.md for more information.
-# TODO(crbug.com/1018739): remove this when migration is done.
-set_sources_assignment_filter([])
-
 config("rlz_lib_config") {
   defines = [ "RLZ_NETWORK_IMPLEMENTATION_CHROME_NET" ]
 }

sandbox/BUILD.gn

@@ -46,7 +46,6 @@ buildflag_header("sandbox_buildflags") {
 # Although the code is Windows-based, the fuzzer is designed to work on Linux,
 # so do not disable this fuzzer on non-Windows platforms.
 fuzzer_test("sandbox_ipc_fuzzer") {
-  set_sources_assignment_filter([])
   sources = [
     "win/fuzzer/fuzzer_types.h",
     "win/fuzzer/sandbox_ipc_fuzzer.cc",

sandbox/win/BUILD.gn

@@ -367,10 +367,9 @@ shared_library("pocdll") {
   defines = [ "POCDLL_EXPORTS" ]
 }
 
-# This fuzzer will only work on Windows, add fuzz targets which could run on Linux
-# to //sandbox/ directly.
+# This fuzzer will only work on Windows, add fuzz targets which could run on
+# Linux to //sandbox/ directly.
 fuzzer_test("sandbox_policy_rule_fuzzer") {
-  set_sources_assignment_filter([])
   sources = [
     "fuzzer/fuzzer_types.h",
     "fuzzer/sandbox_policy_rule_fuzzer.cc",

services/data_decoder/public/cpp/BUILD.gn

@@ -22,8 +22,6 @@ component("service_provider") {
 }
 
 source_set("cpp") {
-  set_sources_assignment_filter([])
-
   public = [
     "data_decoder.h",
     "json_sanitizer.h",