Skip to content

GitLab

T
tangled
Commit c1263b90 authored by mstensho@opera.com's avatar mstensho@opera.com
Browse files
Options

Make vertical-lr and vertical-rl versions of the tests that replace border-padding-pagination.html 

border-padding-pagination.html exists for both these writing modes, and it won't be
used in the new implementation, so better make sure that we don't lose coverage.

R=jchaffraix@chromium.org

Review URL: https://codereview.chromium.org/510123002

git-svn-id: svn://svn.chromium.org/blink/trunk@181622 bbb929c8-8fbe-4397-9dbb-9b2b20218538
parent e5742cf4
Hide whitespace changes
Inline Side-by-side
Showing with 283 additions and 3 deletions
third_party/WebKit/LayoutTests/TestExpectations
View file @ c1263b90
...@@ -973,7 +973,7 @@ crbug.com/391223 [ Mac ] virtual/regionbasedmulticol/fast/multicol/multicol-with ...@@ -973,7 +973,7 @@ crbug.com/391223 [ Mac ] virtual/regionbasedmulticol/fast/multicol/multicol-with
# the baseline is based on the region based multicol implementation. # the baseline is based on the region based multicol implementation.
crbug.com/350853 fast/multicol/balance-short-trailing-empty-block.html [ Skip ] crbug.com/350853 fast/multicol/balance-short-trailing-empty-block.html [ Skip ]
crbug.com/350853 fast/multicol/balance-trailing-border.html [ Skip ] crbug.com/350853 fast/multicol/balance-trailing-border.html [ Skip ]
crbug.com/350853 fast/multicol/balance-trailing-border2.html [ Skip ] crbug.com/350853 fast/multicol/balance-trailing-border-after-break.html [ Skip ]
crbug.com/350853 fast/multicol/balance-unbreakable.html [ Skip ] crbug.com/350853 fast/multicol/balance-unbreakable.html [ Skip ]
crbug.com/350853 fast/multicol/break-in-scrollable.html [ Skip ] crbug.com/350853 fast/multicol/break-in-scrollable.html [ Skip ]
crbug.com/350853 fast/multicol/change-block-child-height.html [ Skip ] crbug.com/350853 fast/multicol/change-block-child-height.html [ Skip ]
...@@ -1044,6 +1044,12 @@ crbug.com/350853 fast/multicol/positioned-outside-of-columns.html [ Skip ] ...@@ -1044,6 +1044,12 @@ crbug.com/350853 fast/multicol/positioned-outside-of-columns.html [ Skip ]
crbug.com/350853 fast/multicol/tall-float1.html [ Skip ] crbug.com/350853 fast/multicol/tall-float1.html [ Skip ]
crbug.com/350853 fast/multicol/tall-float2.html [ Skip ] crbug.com/350853 fast/multicol/tall-float2.html [ Skip ]
crbug.com/350853 fast/multicol/transform-inside-opacity.html [ Skip ] crbug.com/350853 fast/multicol/transform-inside-opacity.html [ Skip ]
crbug.com/408123 fast/multicol/vertical-lr/balancing/balance-short-trailing-empty-block.html [ Skip ]
crbug.com/408123 fast/multicol/vertical-lr/balancing/balance-trailing-border.html [ Skip ]
crbug.com/408123 fast/multicol/vertical-lr/balancing/balance-trailing-border-after-break.html [ Skip ]
crbug.com/408123 fast/multicol/vertical-rl/balancing/balance-short-trailing-empty-block.html [ Skip ]
crbug.com/408123 fast/multicol/vertical-rl/balancing/balance-trailing-border.html [ Skip ]
crbug.com/408123 fast/multicol/vertical-rl/balancing/balance-trailing-border-after-break.html [ Skip ]
crbug.com/350853 fast/multicol/widows.html [ Skip ] crbug.com/350853 fast/multicol/widows.html [ Skip ]
crbug.com/350853 fast/multicol/widows2.html [ Skip ] crbug.com/350853 fast/multicol/widows2.html [ Skip ]
crbug.com/350853 fast/pagination/auto-height.html [ Skip ] crbug.com/350853 fast/pagination/auto-height.html [ Skip ]
......
third_party/WebKit/LayoutTests/fast/multicol/balance-short-trailing-empty-block-expected.txt
View file @ c1263b90
Both words below should be in the the right column. Both words below should be in the the right column.
Tests that a block a column boundary is recorded properly for balancing Tests if a block crossing a column boundary is recorded properly for balancing
On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE". On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
......
third_party/WebKit/LayoutTests/fast/multicol/balance-short-trailing-empty-block.html
View file @ c1263b90
...@@ -8,6 +8,6 @@ ...@@ -8,6 +8,6 @@
<div style="height:30px;"></div> <div style="height:30px;"></div>
</div> </div>
<script> <script>
description("Tests that a block a column boundary is recorded properly for balancing"); description("Tests if a block crossing a column boundary is recorded properly for balancing");
shouldBe("mc.offsetHeight", "190"); shouldBe("mc.offsetHeight", "190");
</script> </script>
third_party/WebKit/LayoutTests/fast/multicol/vertical-lr/balancing/balance-short-trailing-empty-block-expected.txt 0 → 100644
View file @ c1263b90
Both words below should be in the the right column.
Tests if a block crossing a column boundary is recorded properly for balancing
On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
PASS mc.offsetWidth is 190
PASS successfullyParsed is true
TEST COMPLETE
second
column
third_party/WebKit/LayoutTests/fast/multicol/vertical-lr/balancing/balance-short-trailing-empty-block.html 0 → 100644
View file @ c1263b90
<!DOCTYPE html>
<script src="../../../../resources/js-test.js"></script>
<p>Both words below should be in the the right column.</p>
<div id="console"></div>
<div id="mc" style="-webkit-writing-mode:vertical-lr; -webkit-columns:2; columns:2; orphans:1; widows:1; -webkit-column-rule:1px solid; column-rule:1px solid; background:olive;">
<div style="width:120px;"></div>
<div style="line-height:80px;">second<br>column</div>
<div style="width:30px;"></div>
</div>
<script>
description("Tests if a block crossing a column boundary is recorded properly for balancing");
shouldBe("mc.offsetWidth", "190");
</script>
third_party/WebKit/LayoutTests/fast/multicol/vertical-lr/balancing/balance-trailing-border-after-break-expected.txt 0 → 100644
View file @ c1263b90
Tests that the bottom border at a column boundary in a block that lives in multiple columns is recorded properly for balancing
On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
PASS mc.offsetWidth is 69
PASS successfullyParsed is true
TEST COMPLETE
There should be no space between the short black line and the long gray one.
third_party/WebKit/LayoutTests/fast/multicol/vertical-lr/balancing/balance-trailing-border-after-break.html 0 → 100644
View file @ c1263b90
<!DOCTYPE html>
<script src="../../../../resources/js-test.js"></script>
<script>
description("Tests that the bottom border at a column boundary in a block that lives in multiple columns is recorded properly for balancing");
</script>
<p>There should be no space between the short black line and the long gray one.</p>
<div id="mc" style="-webkit-writing-mode:vertical-lr; -webkit-columns:3; columns:3; line-height:21px; height:14em; orphans:1; widows:1; border-right:3px solid gray;">
<div style="width:9px;"></div>
<div style="border-right:3px solid black;">
<br><br><br><br><br><br><br><br>
</div>
</div>
<script>
shouldBe("mc.offsetWidth", "69");
</script>
third_party/WebKit/LayoutTests/fast/multicol/vertical-lr/balancing/balance-trailing-border-expected.txt 0 → 100644
View file @ c1263b90
Both words below should be in the the right column.
Tests that the bottom border at a column boundary is recorded properly for balancing
On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
PASS mc.offsetWidth is 168
PASS successfullyParsed is true
TEST COMPLETE
right
column
third_party/WebKit/LayoutTests/fast/multicol/vertical-lr/balancing/balance-trailing-border.html 0 → 100644
View file @ c1263b90
<!DOCTYPE html>
<script src="../../../../resources/js-test.js"></script>
<p>Both words below should be in the the right column.</p>
<div id="console"></div>
<div id="mc" style="-webkit-writing-mode:vertical-lr; -webkit-columns:2; columns:2; orphans:1; widows:1; -webkit-column-rule:1px solid; column-rule:1px solid; background:olive;">
<div style="width:110px"></div>
<div style="border:2px solid black; height:175px;">
<div style="margin:10px 0; border:2px solid blue;">
<span style="line-height:80px;">right<br>column</span>
</div>
</div>
</div>
<script>
description("Tests that the bottom border at a column boundary is recorded properly for balancing");
shouldBe("mc.offsetWidth", "168");
</script>
third_party/WebKit/LayoutTests/fast/multicol/vertical-lr/balancing/balance-unbreakable-expected.txt 0 → 100644
View file @ c1263b90
There should be a square with some stuff inside below.
Tests that an image at a column boundary is recorded properly for balancing
On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
PASS mc.offsetWidth is 224
PASS successfullyParsed is true
TEST COMPLETE
line
line
line
line
line
line
third_party/WebKit/LayoutTests/fast/multicol/vertical-lr/balancing/balance-unbreakable.html 0 → 100644
View file @ c1263b90
<!DOCTYPE html>
<script src="../../../../resources/js-test.js"></script>
<p>There should be a <em>square</em> with some stuff inside below.</p>
<div id="console"></div>
<div id="mc" style="-webkit-writing-mode:vertical-lr; -webkit-columns:3; columns:3; height:7em; orphans:1; widows:1; background:olive;">
<div style="line-height:4em;">line</div>
<div style="line-height:8em;">line</div>
<img alt="x" style="display:block; width:2em;">
<div style="line-height:4em;">line</div>
<div style="line-height:10em;">line</div>
<div style="line-height:2em;">line</div>
<div style="line-height:6em;">line</div>
</div>
<div style="width:14em; height:7em; background:olive;"></div>
<script>
description("Tests that an image at a column boundary is recorded properly for balancing");
shouldBe("mc.offsetWidth", "224");
</script>
third_party/WebKit/LayoutTests/fast/multicol/vertical-lr/border-padding-pagination.html
View file @ c1263b90
<!-- For the new ("region-based") multicol implementation, this test is superseded by the following
tests:
balance-short-trailing-empty-block.html
balance-trailing-border.html
balance-unbreakable.html
Rather than rebaselining the results, this test should be deleted when enabling the new
implementation. -->
<html> <html>
<body style="-webkit-writing-mode:vertical-lr"> <body style="-webkit-writing-mode:vertical-lr">
<div style="-webkit-column-count:2;-moz-column-count:2; border:2px solid maroon"> <div style="-webkit-column-count:2;-moz-column-count:2; border:2px solid maroon">
......
third_party/WebKit/LayoutTests/fast/multicol/vertical-rl/balancing/balance-short-trailing-empty-block-expected.txt 0 → 100644
View file @ c1263b90
Both words below should be in the the right column.
Tests if a block crossing a column boundary is recorded properly for balancing
On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
PASS mc.offsetWidth is 190
PASS successfullyParsed is true
TEST COMPLETE
second
column
third_party/WebKit/LayoutTests/fast/multicol/vertical-rl/balancing/balance-short-trailing-empty-block.html 0 → 100644
View file @ c1263b90
<!DOCTYPE html>
<script src="../../../../resources/js-test.js"></script>
<p>Both words below should be in the the right column.</p>
<div id="console"></div>
<div id="mc" style="-webkit-writing-mode:vertical-rl; -webkit-columns:2; columns:2; orphans:1; widows:1; -webkit-column-rule:1px solid; column-rule:1px solid; background:olive;">
<div style="width:120px;"></div>
<div style="line-height:80px;">second<br>column</div>
<div style="width:30px;"></div>
</div>
<script>
description("Tests if a block crossing a column boundary is recorded properly for balancing");
shouldBe("mc.offsetWidth", "190");
</script>
third_party/WebKit/LayoutTests/fast/multicol/vertical-rl/balancing/balance-trailing-border-after-break-expected.txt 0 → 100644
View file @ c1263b90
Tests that the bottom border at a column boundary in a block that lives in multiple columns is recorded properly for balancing
On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
PASS mc.offsetWidth is 69
PASS successfullyParsed is true
TEST COMPLETE
There should be no space between the short black line and the long gray one.
third_party/WebKit/LayoutTests/fast/multicol/vertical-rl/balancing/balance-trailing-border-after-break.html 0 → 100644
View file @ c1263b90
<!DOCTYPE html>
<script src="../../../../resources/js-test.js"></script>
<script>
description("Tests that the bottom border at a column boundary in a block that lives in multiple columns is recorded properly for balancing");
</script>
<p>There should be no space between the short black line and the long gray one.</p>
<div id="mc" style="-webkit-writing-mode:vertical-rl; -webkit-columns:3; columns:3; line-height:21px; height:14em; orphans:1; widows:1; border-left:3px solid gray;">
<div style="width:9px;"></div>
<div style="border-left:3px solid black;">
<br><br><br><br><br><br><br><br>
</div>
</div>
<script>
shouldBe("mc.offsetWidth", "69");
</script>
third_party/WebKit/LayoutTests/fast/multicol/vertical-rl/balancing/balance-trailing-border-expected.txt 0 → 100644
View file @ c1263b90
Both words below should be in the the right column.
Tests that the bottom border at a column boundary is recorded properly for balancing
On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
PASS mc.offsetWidth is 168
PASS successfullyParsed is true
TEST COMPLETE
right
column
third_party/WebKit/LayoutTests/fast/multicol/vertical-rl/balancing/balance-trailing-border.html 0 → 100644
View file @ c1263b90
<!DOCTYPE html>
<script src="../../../../resources/js-test.js"></script>
<p>Both words below should be in the the right column.</p>
<div id="console"></div>
<div id="mc" style="-webkit-writing-mode:vertical-rl; -webkit-columns:2; columns:2; orphans:1; widows:1; -webkit-column-rule:1px solid; column-rule:1px solid; background:olive;">
<div style="width:110px"></div>
<div style="border:2px solid black; height:175px;">
<div style="margin:10px 0; border:2px solid blue;">
<span style="line-height:80px;">right<br>column</span>
</div>
</div>
</div>
<script>
description("Tests that the bottom border at a column boundary is recorded properly for balancing");
shouldBe("mc.offsetWidth", "168");
</script>
third_party/WebKit/LayoutTests/fast/multicol/vertical-rl/balancing/balance-unbreakable-expected.txt 0 → 100644
View file @ c1263b90
There should be a square with some stuff inside below.
Tests that an image at a column boundary is recorded properly for balancing
On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
PASS mc.offsetWidth is 224
PASS successfullyParsed is true
TEST COMPLETE
line
line
line
line
line
line
third_party/WebKit/LayoutTests/fast/multicol/vertical-rl/balancing/balance-unbreakable.html 0 → 100644
View file @ c1263b90
<!DOCTYPE html>
<script src="../../../../resources/js-test.js"></script>
<p>There should be a <em>square</em> with some stuff inside below.</p>
<div id="console"></div>
<div id="mc" style="-webkit-writing-mode:vertical-rl; -webkit-columns:3; columns:3; height:7em; orphans:1; widows:1; background:olive;">
<div style="line-height:4em;">line</div>
<div style="line-height:8em;">line</div>
<img alt="x" style="display:block; width:2em;">
<div style="line-height:4em;">line</div>
<div style="line-height:10em;">line</div>
<div style="line-height:2em;">line</div>
<div style="line-height:6em;">line</div>
</div>
<div style="width:14em; height:7em; background:olive;"></div>
<script>
description("Tests that an image at a column boundary is recorded properly for balancing");
shouldBe("mc.offsetWidth", "224");
</script>
third_party/WebKit/LayoutTests/fast/multicol/vertical-rl/border-padding-pagination.html
View file @ c1263b90
<!-- For the new ("region-based") multicol implementation, this test is superseded by the following
tests:
balance-short-trailing-empty-block.html
balance-trailing-border.html
balance-unbreakable.html
Rather than rebaselining the results, this test should be deleted when enabling the new
implementation. -->
<html> <html>
<body style="-webkit-writing-mode:vertical-rl"> <body style="-webkit-writing-mode:vertical-rl">
<div style="-webkit-column-count:2;-moz-column-count:2; border:2px solid maroon"> <div style="-webkit-column-count:2;-moz-column-count:2; border:2px solid maroon">
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment