Renable BrowserTest.WindowOpenClose1 and disable DCHECK instead

The browser test predates the DCHECK, so instead of disabling a test
that indicates that triggers a bug somewhere in surface management,
we should temporarily remove the apparently incorrect DCHECK.

BUG=823043
R=mohsen@chromium.org

Change-Id: I03ad6259587b9367bd5940fc5c18da3698746dbe
Reviewed-on: https://chromium-review.googlesource.com/c/1459628
Commit-Queue: Jochen Eisinger <jochen@chromium.org>
Reviewed-by: Mohsen Izadi <mohsen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#630700}

chrome/browser/ui/browser_browsertest.cc

@@ -1853,13 +1853,7 @@ IN_PROC_BROWSER_TEST_F(BrowserTest2, NoTabsInPopups) {
 }
 #endif
 
-// Flaky on Chrome OS only. TODO(https://crbug.com/823043) fix it.
-#if defined(OS_CHROMEOS)
-#define MAYBE_WindowOpenClose1 DISABLED_WindowOpenClose1
-#else
-#define MAYBE_WindowOpenClose1 WindowOpenClose1
-#endif
-IN_PROC_BROWSER_TEST_F(BrowserTest, MAYBE_WindowOpenClose1) {
+IN_PROC_BROWSER_TEST_F(BrowserTest, WindowOpenClose1) {
   base::CommandLine::ForCurrentProcess()->AppendSwitch(
       switches::kDisablePopupBlocking);
   ASSERT_TRUE(embedded_test_server()->Start());

components/viz/service/surfaces/surface_manager.cc

@@ -76,8 +76,9 @@ SurfaceManager::~SurfaceManager() {
 
   // All SurfaceClients and their surfaces are supposed to be
   // destroyed before SurfaceManager.
-  DCHECK(surface_map_.empty());
-  DCHECK(surfaces_to_destroy_.empty());
+  // TODO(crbug.com/823043): The following two DCHECKs don't hold.
+  // DCHECK(surface_map_.empty());
+  // DCHECK(surfaces_to_destroy_.empty());
 }
 
 #if DCHECK_IS_ON()