Commit c1451622 authored by edchin's avatar edchin Committed by Commit Bot

[ios] Add comment to remove -rootViewController

The use of -rootViewController is fine here because it
is used for safe area sizing rather than presentation.
This is necessary because the view is not in the
hierarchy at the time the sizing is done.
We should find a way to completely remove
rootViewController, which may involve moving
when the sizing is done in this case.


Bug: 791784
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: Id69b668a9b08c85b0e0ff66a3dd90ac56f580ecd
Reviewed-on: https://chromium-review.googlesource.com/824432
Commit-Queue: edchin <edchin@chromium.org>
Reviewed-by: default avataredchin <edchin@chromium.org>
Reviewed-by: default avatarGauthier Ambard <gambard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#523795}
parent efaad58f
......@@ -194,6 +194,7 @@ const CGFloat kHintLabelSidePadding = 12;
// safeAreaInsets. Since this situation is universally called for the full
// screen new tab animation, it's safe to check the rootViewController's
// view instead.
// TODO(crbug.com/791784) : Remove use of rootViewController.
UIView* insetsView = self.headerView;
if (!self.headerView.window) {
insetsView =
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment