Revert "Address missed CL comments for chrome.enterprisePrivate.getDeviceInfo() CL."
This reverts commit 4364277e. Reason for revert: The base::mac::CFCastStrict<CFNumberRef>(ask_for_password) cast returns NULL in some cases, and causes a crash. I'll re-land the original CL (which actually fixes a memory leak), with the proper guards to avoid the crash. Original change's description: > Address missed CL comments for chrome.enterprisePrivate.getDeviceInfo() CL. > > Original CL was at: > https://chromium-review.googlesource.com/c/chromium/src/+/1951561 > > Change-Id: I8784ec61cec5834b17afe04ea8b1d474178af15e > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1961211 > Reviewed-by: Julian Pastarmov <pastarmovj@chromium.org> > Reviewed-by: Robert Sesek <rsesek@chromium.org> > Commit-Queue: Tim Song <tengs@chromium.org> > Cr-Commit-Position: refs/heads/master@{#723985} TBR=pastarmovj@chromium.org,tengs@chromium.org,rsesek@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Change-Id: I38286e8d12aa82faff4fc798bc81857ac3576f4c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1978419Reviewed-by:Gustavo Sacomoto <sacomoto@chromium.org> Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Commit-Queue: Gustavo Sacomoto <sacomoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#726886}
Showing
Please register or sign in to comment