Scanning: Set up closure compilation 2/n

Part 2 of enabling closure compiler for scanning browser tests. Focusing on enabling and making sure it compiles, without optimization to tests themselves.

Intentionally omits registration to the main target webui:closure_compile (to be enabled later).

chrome/test/data/webui:closure_compile

Bug: 1059779
Test: browser_tests --gtest_filter=Scanning* && autoninja -C ${out}
Change-Id: I48f06cfd6776ce6cf3583e7ba2005edce8be0d7a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2513688
Commit-Queue: Joon Ahn <joonbug@chromium.org>
Reviewed-by: Jesse Schettler <jschettler@chromium.org>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>
Cr-Commit-Position: refs/heads/master@{#824101}

chrome/test/data/webui/chromeos/scanning/BUILD.gn

@@ -19,7 +19,10 @@ js_type_check("closure_compile") {
     ":scan_preview_test",
     ":scan_to_select_test",
     ":scanner_select_test",
+    ":scanning_app_test",
     ":scanning_app_test_utils",
+    ":scanning_app_unified_test",
+    ":source_select_test",
     ":test_scanning_browser_proxy",
   ]
 }
@@ -68,9 +71,31 @@ js_library("scanner_select_test") {
   externs_list = [ "$externs_path/mocha-2.5.js" ]
 }
 
+js_library("scanning_app_test") {
+  deps = [
+    ":scanning_app_test_utils",
+    "../..:test_util.m",
+    "//chromeos/components/scanning/resources:scanning_app",
+    "//third_party/polymer/v3_0/components-chromium/iron-collapse:iron-collapse",
+    "//ui/webui/resources/cr_elements/cr_button:cr_button.m",
+  ]
+  externs_list = [ "$externs_path/mocha-2.5.js" ]
+}
+
 js_library("scanning_app_test_utils") {
 }
 
+js_library("scanning_app_unified_test") {
+}
+
+js_library("source_select_test") {
+  deps = [
+    ":scanning_app_test_utils",
+    "//chromeos/components/scanning/resources:source_select",
+  ]
+  externs_list = [ "$externs_path/mocha-2.5.js" ]
+}
+
 js_library("test_scanning_browser_proxy") {
   deps = [
     "../..:test_browser_proxy.m",

chrome/test/data/webui/chromeos/scanning/scanning_app_test.js

@@ -10,6 +10,7 @@ import {setScanServiceForTesting} from 'chrome://scanning/mojo_interface_provide
 import {ScannerArr} from 'chrome://scanning/scanning_app_types.js';
 import {tokenToString} from 'chrome://scanning/scanning_app_util.js';
 
+import {assertEquals, assertFalse, assertTrue} from '../../chai_assert.js';
 import {flushTasks} from '../../test_util.m.js';
 
 import * as utils from './scanning_app_test_utils.js';
@@ -40,6 +41,7 @@ const SourceType = {
 
 const pageSizes = [PageSize.A4, PageSize.Letter, PageSize.Max];
 
+/** @implements {chromeos.scanning.mojom.ScanServiceInterface} */
 class FakeScanService {
   constructor() {
     /** @private {!Map<string, !PromiseResolver>} */
@@ -152,8 +154,8 @@ export function scanningAppTest() {
   /** @type {?ScanningAppElement} */
   let scanningApp = null;
 
-  /** @type {?chromeos.scanning.mojom.ScanServiceRemote} */
-  let fakeScanService_;
+  /** @type {?FakeScanService} */
+  let fakeScanService_ = null;
 
   suiteSetup(() => {
     fakeScanService_ = new FakeScanService();
@@ -161,7 +163,7 @@ export function scanningAppTest() {
   });
 
   setup(function() {
-    PolymerTest.clearBody();
+    document.body.innerHTML = '';
   });
 
   teardown(function() {
@@ -179,7 +181,8 @@ export function scanningAppTest() {
   function initializeScanningApp(scanners, capabilities) {
     fakeScanService_.setScanners(scanners);
     fakeScanService_.setCapabilities(capabilities);
-    scanningApp = document.createElement('scanning-app');
+    scanningApp = /** @type {!ScanningAppElement} */ (
+        document.createElement('scanning-app'));
     document.body.appendChild(scanningApp);
     assert(!!scanningApp);
     return fakeScanService_.whenCalled('getScanners');
@@ -190,7 +193,8 @@ export function scanningAppTest() {
    * @return {!CrButtonElement}
    */
   function getMoreSettingsButton() {
-    const button = scanningApp.$$('#moreSettingsButton');
+    const button =
+        /** @type {!CrButtonElement} */ (scanningApp.$$('#moreSettingsButton'));
     assertTrue(!!button);
     return button;
   }
@@ -213,10 +217,14 @@ export function scanningAppTest() {
   }
 
   test('Scan', () => {
-    const firstScannerId = {high: 0, low: 1};
+    const firstScannerId =
+        /** @type {!mojoBase.mojom.UnguessableToken} */ ({high: 0, low: 1});
     const firstScannerName = 'Scanner 1';
-    const secondScannerId = {high: 0, low: 2};
+
+    const secondScannerId =
+        /** @type {!mojoBase.mojom.UnguessableToken} */ ({high: 0, low: 2});
     const secondScannerName = 'Scanner 2';
+
     const expectedScanners = [
       utils.createScanner(firstScannerId, firstScannerName),
       utils.createScanner(secondScannerId, secondScannerName)

chrome/test/data/webui/chromeos/scanning/scanning_app_unified_test.js

@@ -18,7 +18,7 @@ import {sourceSelectTest} from './source_select_test.js';
 window.test_suites_list = [];
 
 function runSuite(suiteName, testFn) {
-  test_suites_list.push(suiteName);
+  window.test_suites_list.push(suiteName);
   suite(suiteName, testFn);
 }
 

chrome/test/data/webui/chromeos/scanning/source_select_test.js

@@ -8,6 +8,8 @@ import 'chrome://scanning/scanning_app.js';
 import {flush} from 'chrome://resources/polymer/v3_0/polymer/polymer_bundled.min.js';
 import {getSourceTypeString} from 'chrome://scanning/scanning_app_util.js';
 
+import {assertEquals, assertFalse, assertTrue} from '../../chai_assert.js';
+
 import * as utils from './scanning_app_test_utils.js';
 
 const FileType = {
@@ -31,11 +33,12 @@ const SourceType = {
 const pageSizes = [PageSize.A4, PageSize.Letter, PageSize.Max];
 
 export function sourceSelectTest() {
-  /** @type {!SourceSelectElement} */
-  let sourceSelect;
+  /** @type {?SourceSelectElement} */
+  let sourceSelect = null;
 
   setup(() => {
-    sourceSelect = document.createElement('source-select');
+    sourceSelect = /** @type {!SourceSelectElement} */ (
+        document.createElement('source-select'));
     assertTrue(!!sourceSelect);
     document.body.appendChild(sourceSelect);
   });