Commit c1737f76 authored by rbpotter's avatar rbpotter Committed by Commit Bot

Closure compiler: Add more externs files to PRESUBMITs

There are a number of externs files for closure compiler that  are
autogenerated from files in chrome/common/extensions/api/ or
extensions/common/api/ that do not have PRESUBMIT checks. Add checks
for these files.

Bug: None
Change-Id: I9df36c4ef819244287c13538d28c765f9aba78cb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1815986
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Reviewed-by: default avatarDevlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#699975}
parent 1fa0f66d
......@@ -26,6 +26,7 @@ def _CheckExterns(input_api, output_api):
externs_root = join(src_root, 'third_party', 'closure_compiler', 'externs')
api_pair_names = {
'accessibility_private.json': 'accessibility_private.js',
'activity_log_private.json': 'activity_log_private.js',
'autofill_private.idl': 'autofill_private.js',
'developer_private.idl': 'developer_private.js',
......@@ -33,10 +34,14 @@ def _CheckExterns(input_api, output_api):
'command_line_private.json': 'command_line_private.js',
'file_manager_private.idl': 'file_manager_private.js',
'file_system_provider.idl': 'file_system_provider.js',
'input_method_private.json': 'input_method_private.js',
'language_settings_private.idl': 'language_settings_private.js',
'media_player_private.json': 'media_player_private.js',
'passwords_private.idl': 'passwords_private.js',
'quick_unlock_private.idl': 'quick_unlock_private.js',
'resources_private.idl': 'resources_private.js',
'safe_browsing_private.idl': 'safe_browsing_private.js',
'settings_private.idl': 'settings_private.js',
'system_private.json': 'system_private.js',
'users_private.idl': 'users_private.js',
# TODO(rdevlin.cronin): Add more!
......
......@@ -26,12 +26,21 @@ def _CheckExterns(input_api, output_api):
api_root, '..', '..', '..', 'third_party', 'closure_compiler', 'externs'))
api_pairs = {
join(api_root, 'audio.idl'): join(externs_root, 'audio.js'),
join(api_root, 'automation.idl'): join(externs_root, 'automation.js'),
join(api_root, 'bluetooth.idl'): join(externs_root, 'bluetooth.js'),
join(api_root, 'bluetooth_private.idl'):
join(externs_root, 'bluetooth_private.js'),
join(api_root, 'clipboard.idl'): join(externs_root, 'clipboard.js'),
join(api_root, 'management.json'): join(externs_root, 'management.js'),
join(api_root, 'metrics_private.json'):
join(externs_root, 'metrics_private.js'),
join(api_root, 'mime_handler_private.idl'):
join(externs_root, 'mime_handler_private.js'),
join(api_root, 'networking_private.idl'):
join(externs_root, 'networking_private.js'),
join(api_root, 'system_display.idl'):
join(externs_root, 'system_display.js'),
# TODO(rdevlin.cronin): Add more!
}
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment