Commit c17e0355 authored by Dana Fried's avatar Dana Fried Committed by Commit Bot

Handover of flags and issues around rounded corners to tluk@

Change-Id: Iba6f775a30f9325f1704a52cce3a5d2cf5202395
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1912625
Auto-Submit: Dana Fried <dfried@chromium.org>
Commit-Queue: Robert Liao <robliao@chromium.org>
Reviewed-by: default avatarRobert Liao <robliao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#714662}
parent 47e44c28
...@@ -1513,8 +1513,8 @@ ...@@ -1513,8 +1513,8 @@
}, },
{ {
"name": "enable-md-rounded-corners-on-dialogs", "name": "enable-md-rounded-corners-on-dialogs",
"owners": ["bsep", "sajadm"], "owners": ["tluk"],
"expiry_milestone": 78 "expiry_milestone": 85
}, },
{ {
"name": "enable-media-internals-devtools", "name": "enable-media-internals-devtools",
......
...@@ -449,7 +449,7 @@ void FindBarView::OnThemeChanged() { ...@@ -449,7 +449,7 @@ void FindBarView::OnThemeChanged() {
0xFF); 0xFF);
auto border = std::make_unique<views::BubbleBorder>( auto border = std::make_unique<views::BubbleBorder>(
views::BubbleBorder::NONE, views::BubbleBorder::SMALL_SHADOW, bg_color); views::BubbleBorder::NONE, views::BubbleBorder::SMALL_SHADOW, bg_color);
// TODO(sajadm): Remove when fixing https://crbug.com/822075 and use // TODO(tluk): Remove when fixing https://crbug.com/822075 and use
// EMPHASIS_HIGH metric values from the LayoutProvider to get the // EMPHASIS_HIGH metric values from the LayoutProvider to get the
// corner radius. // corner radius.
border->SetCornerRadius(2); border->SetCornerRadius(2);
......
...@@ -230,7 +230,7 @@ ProfileMenuViewBase::ProfileMenuViewBase(views::Button* anchor_button, ...@@ -230,7 +230,7 @@ ProfileMenuViewBase::ProfileMenuViewBase(views::Button* anchor_button,
close_bubble_helper_(this, browser) { close_bubble_helper_(this, browser) {
DCHECK(!g_profile_bubble_); DCHECK(!g_profile_bubble_);
g_profile_bubble_ = this; g_profile_bubble_ = this;
// TODO(sajadm): Remove when fixing https://crbug.com/822075 // TODO(tluk): Remove when fixing https://crbug.com/822075
// The sign in webview will be clipped on the bottom corners without these // The sign in webview will be clipped on the bottom corners without these
// margins, see related bug <http://crbug.com/593203>. // margins, see related bug <http://crbug.com/593203>.
set_margins(gfx::Insets(2, 0)); set_margins(gfx::Insets(2, 0));
......
...@@ -18,7 +18,7 @@ const base::Feature kEnableAuraTooltipsOnWindows{ ...@@ -18,7 +18,7 @@ const base::Feature kEnableAuraTooltipsOnWindows{
#endif // OS_WIN #endif // OS_WIN
// Increases corner radius on Dialogs for the material design refresh. // Increases corner radius on Dialogs for the material design refresh.
// TODO(sajadm): Remove this feature flag when platform inconsistencies // TODO(tluk): Remove this feature flag when platform inconsistencies
// have been fixed as recorded on: https://crbug.com/932970 // have been fixed as recorded on: https://crbug.com/932970
const base::Feature kEnableMDRoundedCornersOnDialogs{ const base::Feature kEnableMDRoundedCornersOnDialogs{
"EnableMDRoundedCornersOnDialogs", base::FEATURE_DISABLED_BY_DEFAULT}; "EnableMDRoundedCornersOnDialogs", base::FEATURE_DISABLED_BY_DEFAULT};
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment