Commit c1993ac4 authored by tkent@chromium.org's avatar tkent@chromium.org

Oilpan: Update comments in ImageLoader.

NOTRY=true
BUG=383741,383742

Review URL: https://codereview.chromium.org/329263003

git-svn-id: svn://svn.chromium.org/blink/trunk@176003 bbb929c8-8fbe-4397-9dbb-9b2b20218538
parent dc5bd4b0
...@@ -138,7 +138,7 @@ private: ...@@ -138,7 +138,7 @@ private:
ResourcePtr<ImageResource> m_image; ResourcePtr<ImageResource> m_image;
// FIXME: Oilpan: We might be able to remove this Persistent hack when // FIXME: Oilpan: We might be able to remove this Persistent hack when
// ImageResourceClient is traceable. // ImageResourceClient is traceable.
GC_PLUGIN_IGNORE("http://crbug.com/353083") GC_PLUGIN_IGNORE("http://crbug.com/383741")
RefPtrWillBePersistent<Element> m_keepAlive; RefPtrWillBePersistent<Element> m_keepAlive;
#if ENABLE(OILPAN) #if ENABLE(OILPAN)
class ImageLoaderClientRemover { class ImageLoaderClientRemover {
...@@ -152,8 +152,11 @@ private: ...@@ -152,8 +152,11 @@ private:
}; };
friend class ImageLoaderClientRemover; friend class ImageLoaderClientRemover;
// Oilpan: This ImageLoader object must outlive its clients because they // Oilpan: This ImageLoader object must outlive its clients because they
// need to call ImageLoader::willRemoveClient before they die. // need to call ImageLoader::willRemoveClient before they
GC_PLUGIN_IGNORE("http://crbug.com/353083") // die. Non-Persistent HeapHashMap doesn't work well because weak processing
// for HeapHashMap is not triggered when both of ImageLoader and
// ImageLoaderClient are unreachable.
GC_PLUGIN_IGNORE("http://crbug.com/383742")
PersistentHeapHashMap<WeakMember<ImageLoaderClient>, OwnPtr<ImageLoaderClientRemover> > m_clients; PersistentHeapHashMap<WeakMember<ImageLoaderClient>, OwnPtr<ImageLoaderClientRemover> > m_clients;
#else #else
HashSet<ImageLoaderClient*> m_clients; HashSet<ImageLoaderClient*> m_clients;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment