Commit c1dfa695 authored by finnur's avatar finnur Committed by Commit bot

Site Settings Desktop: Only show Remove action if filter hasn't removed all.

BUG=650239
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2370843002
Cr-Commit-Position: refs/heads/master@{#421275}
parent 90e45dfe
......@@ -36,7 +36,8 @@
</style>
<div class="layout horizontal">
<div class="flex site-header">$i18n{siteSettingsCookieHeader}</div>
<div class="secondary-action" hidden$="[[!removeAllIsVisible_(sites)]]">
<div class="secondary-action"
hidden$="[[!isRemoveButtonVisible_(sites, renderedItemCount)]]">
<paper-button on-tap="onDeleteMultipleSites_" class="secondary-button">
[[computeRemoveLabel_(filterString_)]]
</paper-button>
......@@ -47,7 +48,8 @@
</div>
<div class="list-frame vertical-list">
<template is="dom-repeat" id="list" items="[[sites]]" filter="showItem_">
<template is="dom-repeat" id="list" items="[[sites]]" filter="showItem_"
rendered-item-count="{{renderedItemCount}}">
<div class="list-item layout horizontal">
<div class="layout horizontal flex" on-tap="onSiteTap_" actionable>
<div class="favicon-image site"
......@@ -61,7 +63,6 @@
</div>
</template>
</div>
</template>
<script src="cookie_info.js"></script>
<script src="cookie_tree_node.js"></script>
......
......@@ -76,14 +76,9 @@ Polymer({
this.$.list.render();
},
/**
* Returns whether remove all should be shown.
* @param {!Array<!CookieDataSummaryItem>} sites The sites list to use to
* determine whether the button should be visible.
* @private
*/
removeAllIsVisible_: function(sites) {
return sites.length > 0;
/** @private */
isRemoveButtonVisible_: function(sites, renderedItemCount) {
return renderedItemCount != 0;
},
/**
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment