[iOS] Confirmation message before deleting password

This change adds confirmation message to the delete dialog for non
compromised passwords.

Bug: 1141331
Change-Id: I831192aa6adbda67354882d63f25f8f51f955b91
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2504232
Commit-Queue: Viktor Semeniuk <vsemeniuk@google.com>
Reviewed-by: Gauthier Ambard <gambard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#822080}

ios/chrome/app/strings/ios_strings.grd

@@ -1762,6 +1762,9 @@ Follow the steps below:
       <message name="IDS_IOS_CHANGE_COMPROMISED_PASSWORD" desc="Button which is shown on Password Details Screen when password is compromised. [iOS only]" meaning="Telling user to change password on a website since it is compromised.">
         Change Password on Website
       </message>
+      <message name="IDS_IOS_DELETE_PASSWORD_DESCRIPTION" desc="Message at the top of the confirmation alert when the user tapped delete password button. [iOS only]" meaning="Explaining to the user that deleting password locally won't delete account on a website.">
+        Deleting this password will not delete your account on <ph name="WEBSITE">$1<ex>twitter.com</ex></ph>.
+      </message>
       <message name="IDS_IOS_DELETE_COMPROMISED_PASSWORD_DESCRIPTION" desc="Message on top of the confirmation alert when the user tapped delete password button. [iOS only]" meaning="Explaining to the user that deleting password locally won't delete account on a website.">
         Deleting this password will not delete your account on <ph name="WEBSITE">$1<ex>twitter.com</ex></ph>. Change your password on <ph name="WEBSITE">$1<ex>twitter.com</ex></ph> to keep it safe from others.
       </message>

ios/chrome/app/strings/ios_strings_grd/IDS_IOS_DELETE_PASSWORD_DESCRIPTION.png.sha1

+efd4a799fae3a970124d6d79a43a538de3b086ed
\ No newline at end of file

ios/chrome/browser/ui/settings/password/password_details/password_details_coordinator.mm

@@ -148,13 +148,17 @@
   [self.alertCoordinator start];
 }
 
-- (void)showPasswordDeleteDialogWithOrigin:(NSString*)origin {
+- (void)showPasswordDeleteDialogWithOrigin:(NSString*)origin
+                       compromisedPassword:(BOOL)compromisedPassword {
   NSString* message;
 
-  if (origin.length > 0)
+  if (origin.length > 0) {
+    int stringID = compromisedPassword
+                       ? IDS_IOS_DELETE_COMPROMISED_PASSWORD_DESCRIPTION
+                       : IDS_IOS_DELETE_PASSWORD_DESCRIPTION;
     message =
-        l10n_util::GetNSStringF(IDS_IOS_DELETE_COMPROMISED_PASSWORD_DESCRIPTION,
-                                base::SysNSStringToUTF16(origin));
+        l10n_util::GetNSStringF(stringID, base::SysNSStringToUTF16(origin));
+  }
   self.actionSheetCoordinator = [[ActionSheetCoordinator alloc]
       initWithBaseViewController:self.viewController
                          browser:self.browser
@@ -168,9 +172,8 @@
   [self.actionSheetCoordinator
       addItemWithTitle:l10n_util::GetNSString(IDS_IOS_CONFIRM_PASSWORD_DELETION)
                 action:^{
-                  [weakSelf
-                      passwordDeletionConfirmedForCompromised:origin.length >
-                                                              0];
+                  [weakSelf passwordDeletionConfirmedForCompromised:
+                                compromisedPassword];
                 }
                  style:UIAlertActionStyleDestructive];
 

ios/chrome/browser/ui/settings/password/password_details/password_details_handler.h

@@ -17,8 +17,10 @@
 
 // Called when the user wants to delete password. |origin| is a short website
 // version. It is displayed inside dialog. If |origin| is nil dialog is
-// displayed without message.
-- (void)showPasswordDeleteDialogWithOrigin:(NSString*)origin;
+// displayed without message. |compromisedPassword| indicates whether password
+// is compromised.
+- (void)showPasswordDeleteDialogWithOrigin:(NSString*)origin
+                       compromisedPassword:(BOOL)compromisedPassword;
 
 // Called when the user wants to save edited password.
 - (void)showPasswordEditDialogWithOrigin:(NSString*)origin;

ios/chrome/browser/ui/settings/password/password_details/password_details_table_view_controller.mm

@@ -462,12 +462,15 @@ typedef NS_ENUM(NSInteger, ReauthenticationReason) {
 // Called when user tapped Delete button during editing. It means presented
 // password should be deleted.
 - (void)deleteItems:(NSArray<NSIndexPath*>*)indexPaths {
-  // Pass origin only if password is compromised as confirmation message makes
+  // Pass origin only if password is present as confirmation message makes
   // sense only in this case.
-  if (self.password.isCompromised) {
-    [self.handler showPasswordDeleteDialogWithOrigin:self.password.origin];
+  if ([self.password.password length]) {
+    [self.handler
+        showPasswordDeleteDialogWithOrigin:self.password.origin
+                       compromisedPassword:self.password.isCompromised];
   } else {
-    [self.handler showPasswordDeleteDialogWithOrigin:nil];
+    [self.handler showPasswordDeleteDialogWithOrigin:nil
+                                 compromisedPassword:NO];
   }
 }
 

ios/chrome/browser/ui/settings/password/password_details/password_details_table_view_controller_unittest.mm

@@ -50,6 +50,8 @@ constexpr char kPassword[] = "test";
 
 @property(nonatomic, assign) BOOL deletionCalled;
 
+@property(nonatomic, assign) BOOL deletionCalledOnCompromisedPassword;
+
 @property(nonatomic, assign) BOOL editingCalled;
 
 @end
@@ -62,8 +64,10 @@ constexpr char kPassword[] = "test";
 - (void)showPasscodeDialog {
 }
 
-- (void)showPasswordDeleteDialogWithOrigin:(NSString*)origin {
+- (void)showPasswordDeleteDialogWithOrigin:(NSString*)origin
+                       compromisedPassword:(BOOL)compromisedPassword {
   self.deletionCalled = YES;
+  self.deletionCalledOnCompromisedPassword = compromisedPassword;
 }
 
 - (void)showPasswordEditDialogWithOrigin:(NSString*)origin {
@@ -336,6 +340,25 @@ TEST_F(PasswordDetailsTableViewControllerTest, TestPasswordDelete) {
             from:nil
         forEvent:nil];
   EXPECT_TRUE(handler().deletionCalled);
+  EXPECT_FALSE(handler().deletionCalledOnCompromisedPassword);
+}
+
+// Tests compromised password deletion trigger showing password delete dialog.
+TEST_F(PasswordDetailsTableViewControllerTest, TestCompromisedPasswordDelete) {
+  SetPassword(kExampleCom, kUsername, kPassword, true);
+
+  EXPECT_FALSE(handler().deletionCalled);
+  PasswordDetailsTableViewController* passwordDetails =
+      base::mac::ObjCCastStrict<PasswordDetailsTableViewController>(
+          controller());
+  [passwordDetails editButtonPressed];
+  [[UIApplication sharedApplication]
+      sendAction:passwordDetails.deleteButton.action
+              to:passwordDetails.deleteButton.target
+            from:nil
+        forEvent:nil];
+  EXPECT_TRUE(handler().deletionCalled);
+  EXPECT_TRUE(handler().deletionCalledOnCompromisedPassword);
 }
 
 // Tests password editing. User confirmed this action.