Removing redundant names introduced for input type checkbox with menu as...

Removing redundant names introduced for input type checkbox with menu as parent and aria role menuitemcheckbox

In this CL https://codereview.chromium.org/589383004/, a redundant name was introduced
for input type checkbox with menu as parent. Rather the role defined for aria
role menuitemcheckbox can be used for input type checkbox with menu as parent.

Review URL: https://codereview.chromium.org/649073002

git-svn-id: svn://svn.chromium.org/blink/trunk@183591 bbb929c8-8fbe-4397-9dbb-9b2b20218538
parent 23455ed8
......@@ -210,7 +210,7 @@ AccessibilityRole AXNodeObject::determineAccessibilityRole()
}
if (type == InputTypeNames::checkbox) {
if ((node()->parentNode() && isHTMLMenuElement(node()->parentNode())) || (parentObject() && parentObject()->roleValue() == MenuRole))
return CheckBoxMenuItemRole;
return MenuItemCheckBoxRole;
return CheckBoxRole;
}
if (type == InputTypeNames::date)
......
......@@ -63,7 +63,6 @@ enum AccessibilityRole {
ButtonRole,
CanvasRole,
CellRole,
CheckBoxMenuItemRole,
CheckBoxRole,
ColorWellRole,
ColumnHeaderRole,
......
......@@ -320,7 +320,7 @@ AccessibilityRole AXRenderObject::determineAccessibilityRole()
}
if (type == InputTypeNames::checkbox) {
if ((node->parentNode() && isHTMLMenuElement(node->parentNode())) || (parentObject() && parentObject()->roleValue() == MenuRole))
return CheckBoxMenuItemRole;
return MenuItemCheckBoxRole;
return CheckBoxRole;
}
if (type == InputTypeNames::date)
......
......@@ -182,7 +182,6 @@ COMPILE_ASSERT_MATCHING_ENUM(WebAXRoleBusyIndicator, BusyIndicatorRole);
COMPILE_ASSERT_MATCHING_ENUM(WebAXRoleButton, ButtonRole);
COMPILE_ASSERT_MATCHING_ENUM(WebAXRoleCanvas, CanvasRole);
COMPILE_ASSERT_MATCHING_ENUM(WebAXRoleCell, CellRole);
COMPILE_ASSERT_MATCHING_ENUM(WebAXRoleCheckBoxMenuItem, CheckBoxMenuItemRole);
COMPILE_ASSERT_MATCHING_ENUM(WebAXRoleCheckBox, CheckBoxRole);
COMPILE_ASSERT_MATCHING_ENUM(WebAXRoleColorWell, ColorWellRole);
COMPILE_ASSERT_MATCHING_ENUM(WebAXRoleColumnHeader, ColumnHeaderRole);
......
......@@ -82,7 +82,6 @@ enum WebAXRole {
WebAXRoleButton,
WebAXRoleCanvas,
WebAXRoleCell,
WebAXRoleCheckBoxMenuItem,
WebAXRoleCheckBox,
WebAXRoleColorWell,
WebAXRoleColumnHeader,
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment