Commit c2391f47 authored by tony@chromium.org's avatar tony@chromium.org

Take 2 at removing thumb thickness compositor setting.

Instead, we get the value from blink (landed in blink r157790).
No change in behavior on Android or Desktop.

BUG=None

Review URL: https://chromiumcodereview.appspot.com/24182003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@223558 0039d316-1c4b-4281-b951-d872f2087c98
parent 893d0a35
...@@ -266,7 +266,6 @@ TEST(ScrollbarLayerTest, SolidColorDrawQuads) { ...@@ -266,7 +266,6 @@ TEST(ScrollbarLayerTest, SolidColorDrawQuads) {
const int kTrackLength = 100; const int kTrackLength = 100;
LayerTreeSettings layer_tree_settings; LayerTreeSettings layer_tree_settings;
layer_tree_settings.solid_color_scrollbar_thickness_dip = kThumbThickness;
scoped_ptr<FakeLayerTreeHost> host = scoped_ptr<FakeLayerTreeHost> host =
FakeLayerTreeHost::Create(layer_tree_settings); FakeLayerTreeHost::Create(layer_tree_settings);
...@@ -329,7 +328,6 @@ TEST(ScrollbarLayerTest, LayerDrivenSolidColorDrawQuads) { ...@@ -329,7 +328,6 @@ TEST(ScrollbarLayerTest, LayerDrivenSolidColorDrawQuads) {
const int kTrackLength = 10; const int kTrackLength = 10;
LayerTreeSettings layer_tree_settings; LayerTreeSettings layer_tree_settings;
layer_tree_settings.solid_color_scrollbar_thickness_dip = 3;
scoped_ptr<FakeLayerTreeHost> host = scoped_ptr<FakeLayerTreeHost> host =
FakeLayerTreeHost::Create(layer_tree_settings); FakeLayerTreeHost::Create(layer_tree_settings);
......
...@@ -46,15 +46,6 @@ void SolidColorScrollbarLayerImpl::PushPropertiesTo(LayerImpl* layer) { ...@@ -46,15 +46,6 @@ void SolidColorScrollbarLayerImpl::PushPropertiesTo(LayerImpl* layer) {
} }
int SolidColorScrollbarLayerImpl::ThumbThickness() const { int SolidColorScrollbarLayerImpl::ThumbThickness() const {
// TODO(wjmaclean) This should be removed when
// solid_color_scrollbar_thickness_dip is removed.
int thickness_override =
layer_tree_impl()
? layer_tree_impl()->settings().solid_color_scrollbar_thickness_dip
: -1;
if (thickness_override != -1)
return thickness_override;
if (thumb_thickness_ != -1) if (thumb_thickness_ != -1)
return thumb_thickness_; return thumb_thickness_;
......
...@@ -31,7 +31,6 @@ LayerTreeSettings::LayerTreeSettings() ...@@ -31,7 +31,6 @@ LayerTreeSettings::LayerTreeSettings()
scrollbar_linear_fade_length_ms(300), scrollbar_linear_fade_length_ms(300),
solid_color_scrollbars(false), solid_color_scrollbars(false),
solid_color_scrollbar_color(SK_ColorWHITE), solid_color_scrollbar_color(SK_ColorWHITE),
solid_color_scrollbar_thickness_dip(-1),
calculate_top_controls_position(false), calculate_top_controls_position(false),
use_memory_management(true), use_memory_management(true),
timeout_and_draw_when_animation_checkerboards(true), timeout_and_draw_when_animation_checkerboards(true),
......
...@@ -42,7 +42,6 @@ class CC_EXPORT LayerTreeSettings { ...@@ -42,7 +42,6 @@ class CC_EXPORT LayerTreeSettings {
int scrollbar_linear_fade_length_ms; int scrollbar_linear_fade_length_ms;
bool solid_color_scrollbars; bool solid_color_scrollbars;
SkColor solid_color_scrollbar_color; SkColor solid_color_scrollbar_color;
int solid_color_scrollbar_thickness_dip;
bool calculate_top_controls_position; bool calculate_top_controls_position;
bool use_memory_management; bool use_memory_management;
bool timeout_and_draw_when_animation_checkerboards; bool timeout_and_draw_when_animation_checkerboards;
......
...@@ -272,7 +272,6 @@ scoped_ptr<RenderWidgetCompositor> RenderWidgetCompositor::Create( ...@@ -272,7 +272,6 @@ scoped_ptr<RenderWidgetCompositor> RenderWidgetCompositor::Create(
cmd->HasSwitch(switches::kHideScrollbars) cmd->HasSwitch(switches::kHideScrollbars)
? SK_ColorTRANSPARENT ? SK_ColorTRANSPARENT
: SkColorSetARGB(128, 128, 128, 128); : SkColorSetARGB(128, 128, 128, 128);
settings.solid_color_scrollbar_thickness_dip = 3;
settings.highp_threshold_min = 2048; settings.highp_threshold_min = 2048;
// Android WebView handles root layer flings itself. // Android WebView handles root layer flings itself.
settings.ignore_root_layer_flings = settings.ignore_root_layer_flings =
...@@ -285,7 +284,6 @@ scoped_ptr<RenderWidgetCompositor> RenderWidgetCompositor::Create( ...@@ -285,7 +284,6 @@ scoped_ptr<RenderWidgetCompositor> RenderWidgetCompositor::Create(
if (cmd->HasSwitch(cc::switches::kEnablePinchVirtualViewport) || if (cmd->HasSwitch(cc::switches::kEnablePinchVirtualViewport) ||
cmd->HasSwitch(switches::kEnableOverlayScrollbars)) { cmd->HasSwitch(switches::kEnableOverlayScrollbars)) {
settings.solid_color_scrollbar_color = SkColorSetARGB(128, 128, 128, 128); settings.solid_color_scrollbar_color = SkColorSetARGB(128, 128, 128, 128);
settings.solid_color_scrollbar_thickness_dip = 7;
} }
#endif #endif
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment