Commit c248711a authored by Hwanseung Lee's avatar Hwanseung Lee Committed by Chromium LUCI CQ

Remove History.ClearBrowsingData.TimeSpentInDialog histogram

this histogram expired since M85 branch out.
so remove this historam.

Bug: 1088836
Change-Id: I1b05d0773d1f8d83200ff815eb667c72c057727a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2588676Reviewed-by: default avatarChristian Dullweber <dullweber@chromium.org>
Reviewed-by: default avatarSteven Holte <holte@chromium.org>
Reviewed-by: default avatardpapad <dpapad@chromium.org>
Commit-Queue: Hwanseung Lee <hs1217.lee@samsung.com>
Cr-Commit-Position: refs/heads/master@{#837500}
parent 0d85fd3e
...@@ -9,7 +9,6 @@ import android.app.ProgressDialog; ...@@ -9,7 +9,6 @@ import android.app.ProgressDialog;
import android.content.Context; import android.content.Context;
import android.content.Intent; import android.content.Intent;
import android.os.Bundle; import android.os.Bundle;
import android.os.SystemClock;
import android.view.LayoutInflater; import android.view.LayoutInflater;
import android.view.View; import android.view.View;
import android.view.ViewGroup; import android.view.ViewGroup;
...@@ -213,9 +212,6 @@ public abstract class ClearBrowsingDataFragment extends PreferenceFragmentCompat ...@@ -213,9 +212,6 @@ public abstract class ClearBrowsingDataFragment extends PreferenceFragmentCompat
// important domains from being cleared. // important domains from being cleared.
private ConfirmImportantSitesDialogFragment mConfirmImportantSitesDialog; private ConfirmImportantSitesDialogFragment mConfirmImportantSitesDialog;
// Time in ms, when the dialog was created.
private long mDialogOpened;
/** /**
* @return All available {@link DialogOption} entries. * @return All available {@link DialogOption} entries.
*/ */
...@@ -328,9 +324,6 @@ public abstract class ClearBrowsingDataFragment extends PreferenceFragmentCompat ...@@ -328,9 +324,6 @@ public abstract class ClearBrowsingDataFragment extends PreferenceFragmentCompat
dataTypes.add(getDataType(option)); dataTypes.add(getDataType(option));
} }
RecordHistogram.recordMediumTimesHistogram("History.ClearBrowsingData.TimeSpentInDialog",
SystemClock.elapsedRealtime() - mDialogOpened);
final @CookieOrCacheDeletionChoice int choice; final @CookieOrCacheDeletionChoice int choice;
if (dataTypes.contains(BrowsingDataType.COOKIES)) { if (dataTypes.contains(BrowsingDataType.COOKIES)) {
choice = dataTypes.contains(BrowsingDataType.CACHE) choice = dataTypes.contains(BrowsingDataType.CACHE)
...@@ -522,7 +515,6 @@ public abstract class ClearBrowsingDataFragment extends PreferenceFragmentCompat ...@@ -522,7 +515,6 @@ public abstract class ClearBrowsingDataFragment extends PreferenceFragmentCompat
if (savedInstanceState != null) { if (savedInstanceState != null) {
mFetcher = savedInstanceState.getParcelable(CLEAR_BROWSING_DATA_FETCHER); mFetcher = savedInstanceState.getParcelable(CLEAR_BROWSING_DATA_FETCHER);
} }
mDialogOpened = SystemClock.elapsedRealtime();
getActivity().setTitle(R.string.clear_browsing_data_title); getActivity().setTitle(R.string.clear_browsing_data_title);
SettingsUtils.addPreferencesFromResource(this, R.xml.clear_browsing_data_preferences_tab); SettingsUtils.addPreferencesFromResource(this, R.xml.clear_browsing_data_preferences_tab);
List<Integer> options = getDialogOptions(); List<Integer> options = getDialogOptions();
......
...@@ -201,15 +201,6 @@ Polymer({ ...@@ -201,15 +201,6 @@ Polymer({
'computeHasOtherError_(syncStatus, isSyncPaused_, hasPassphraseError_)', 'computeHasOtherError_(syncStatus, isSyncPaused_, hasPassphraseError_)',
}, },
/**
* Time in ms, when the dialog was opened.
* @private
*/
dialogOpenedTime_: {
type: Number,
value: 0,
},
/** @private {Array<string>} */ /** @private {Array<string>} */
tabsNames_: { tabsNames_: {
type: Array, type: Array,
...@@ -261,7 +252,6 @@ Polymer({ ...@@ -261,7 +252,6 @@ Polymer({
/** @override */ /** @override */
attached() { attached() {
this.browserProxy_ = ClearBrowsingDataBrowserProxyImpl.getInstance(); this.browserProxy_ = ClearBrowsingDataBrowserProxyImpl.getInstance();
this.dialogOpenedTime_ = Date.now();
this.browserProxy_.initialize().then(() => { this.browserProxy_.initialize().then(() => {
this.$.clearBrowsingDataDialog.showModal(); this.$.clearBrowsingDataDialog.showModal();
}); });
...@@ -311,7 +301,6 @@ Polymer({ ...@@ -311,7 +301,6 @@ Polymer({
currentRouteChanged(currentRoute) { currentRouteChanged(currentRoute) {
if (currentRoute === routes.CLEAR_BROWSER_DATA) { if (currentRoute === routes.CLEAR_BROWSER_DATA) {
chrome.metricsPrivate.recordUserAction('ClearBrowsingData_DialogCreated'); chrome.metricsPrivate.recordUserAction('ClearBrowsingData_DialogCreated');
this.dialogOpenedTime_ = Date.now();
} }
}, },
...@@ -482,9 +471,6 @@ Polymer({ ...@@ -482,9 +471,6 @@ Polymer({
showPasswordsNotice && !showHistoryNotice; showPasswordsNotice && !showHistoryNotice;
this.showPasswordsDeletionDialogLater_ = this.showPasswordsDeletionDialogLater_ =
showPasswordsNotice && showHistoryNotice; showPasswordsNotice && showHistoryNotice;
chrome.metricsPrivate.recordMediumTime(
'History.ClearBrowsingData.TimeSpentInDialog',
Date.now() - this.dialogOpenedTime_);
// Close the clear browsing data or installed apps dialog if they are open. // Close the clear browsing data or installed apps dialog if they are open.
const isLastDialog = !showHistoryNotice && !showPasswordsNotice; const isLastDialog = !showHistoryNotice && !showPasswordsNotice;
......
...@@ -317,6 +317,9 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. ...@@ -317,6 +317,9 @@ reviews. Googlers can read more about this at go/gwsq-gerrit.
<histogram name="History.ClearBrowsingData.TimeSpentInDialog" units="ms" <histogram name="History.ClearBrowsingData.TimeSpentInDialog" units="ms"
expires_after="M85"> expires_after="M85">
<obsolete>
Removed 12/2020
</obsolete>
<owner>dullweber@chromium.org</owner> <owner>dullweber@chromium.org</owner>
<owner>msramek@chromium.org</owner> <owner>msramek@chromium.org</owner>
<summary> <summary>
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment