Commit c260e6c2 authored by leviw@chromium.org's avatar leviw@chromium.org

Fix use of LayoutStateDisabler for RenderView invalidation

In an attempt to optimize pushing and popping LayoutState,
the entire optimization ended up being turned off. Fix the
use of LayoutState for RenderView-relative renderers.

BUG=381138

Review URL: https://codereview.chromium.org/326753002

git-svn-id: svn://svn.chromium.org/blink/trunk@175832 bbb929c8-8fbe-4397-9dbb-9b2b20218538
parent 3039fd91
...@@ -79,6 +79,10 @@ crbug.com/310679 [ Mac ] fast/events/scale-and-scroll-iframe-window.html [ Image ...@@ -79,6 +79,10 @@ crbug.com/310679 [ Mac ] fast/events/scale-and-scroll-iframe-window.html [ Image
crbug.com/310679 [ Mac ] fast/frames/frame-set-rotation-hit.html [ Failure ImageOnlyFailure Pass ] crbug.com/310679 [ Mac ] fast/frames/frame-set-rotation-hit.html [ Failure ImageOnlyFailure Pass ]
crbug.com/310679 [ Mac ] fast/frames/frame-set-scaling-hit.html [ Failure ImageOnlyFailure Pass ] crbug.com/310679 [ Mac ] fast/frames/frame-set-scaling-hit.html [ Failure ImageOnlyFailure Pass ]
crbug.com/381138 fast/repaint/reflection-repaint-test.html [ NeedsRebaseline ]
crbug.com/381138 fast/repaint/transform-disable-layoutstate.html [ NeedsRebaseline ]
crbug.com/381138 fast/repaint/transform-layout-repaint.html [ NeedsRebaseline ]
# Tests failing since applyPageScaleFactorInCompositor enabled # Tests failing since applyPageScaleFactorInCompositor enabled
crbug.com/225184 fast/repaint/relayout-fixed-position-after-scale.html [ ImageOnlyFailure ] crbug.com/225184 fast/repaint/relayout-fixed-position-after-scale.html [ ImageOnlyFailure ]
......
...@@ -1631,7 +1631,7 @@ void RenderBox::invalidateTreeAfterLayout(const RenderLayerModelObject& paintInv ...@@ -1631,7 +1631,7 @@ void RenderBox::invalidateTreeAfterLayout(const RenderLayerModelObject& paintInv
} }
// FIXME: LayoutState should be enabled for other paint invalidation containers than the RenderView. crbug.com/363834 // FIXME: LayoutState should be enabled for other paint invalidation containers than the RenderView. crbug.com/363834
if (establishesNewPaintInvalidationContainer) { if (establishesNewPaintInvalidationContainer && !isRenderView()) {
LayoutStateDisabler disabler(*this); LayoutStateDisabler disabler(*this);
RenderObject::invalidateTreeAfterLayout(newPaintInvalidationContainer); RenderObject::invalidateTreeAfterLayout(newPaintInvalidationContainer);
} else { } else {
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment