Valgrind: Fix a leak in ContentSettingsProvider.

If the call to SetWebsiteSetting() fails, the value is still owned by the
caller and must be deleted.

BUG=none
TEST=none

R=bauerb@chromium.org

Review URL: http://codereview.chromium.org/8592001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110594 0039d316-1c4b-4281-b951-d872f2087c98

chrome/browser/content_settings/content_settings_provider.h

@@ -42,7 +42,7 @@ class ProviderInterface {
       const ResourceIdentifier& resource_identifier,
       bool incognito) const = 0;
 
-  // Askes the provider to set the website setting for a particular
+  // Asks the provider to set the website setting for a particular
   // |primary_pattern|, |secondary_pattern|, |content_type| tuple. If the
   // provider accepts the setting it returns true and takes the ownership of the
   // |value|. Otherwise false is returned and the ownership of the |value| stays

chrome/browser/content_settings/host_content_settings_map.cc

@@ -211,12 +211,11 @@ void HostContentSettingsMap::SetDefaultContentSetting(
   DCHECK(IsSettingAllowedForType(setting, content_type));
 
   base::Value* value = Value::CreateIntegerValue(setting);
-  content_settings_providers_[DEFAULT_PROVIDER]->SetWebsiteSetting(
-      ContentSettingsPattern::Wildcard(),
-      ContentSettingsPattern::Wildcard(),
-      content_type,
-      std::string(),
-      value);
+  if (!content_settings_providers_[DEFAULT_PROVIDER]->SetWebsiteSetting(
+      ContentSettingsPattern::Wildcard(), ContentSettingsPattern::Wildcard(),
+      content_type, std::string(), value)) {
+    delete value;
+  }
 }
 
 void HostContentSettingsMap::SetWebsiteSetting(

chrome/browser/extensions/extension_special_storage_policy_unittest.cc

@@ -246,7 +246,7 @@ TEST_F(ExtensionSpecialStoragePolicyTest, HasSessionOnlyOrigins) {
 
   EXPECT_TRUE(policy->HasSessionOnlyOrigins());
 
-  // Clearing an origin-spesific rule.
+  // Clearing an origin-specific rule.
   cookie_settings->ResetCookieSetting(pattern,
                                       ContentSettingsPattern::Wildcard());