Commit c284eb1c authored by Mikel Astiz's avatar Mikel Astiz Committed by Commit Bot

Remove dead code in ChromeBrowserProvider

These are leftovers after https://codereview.chromium.org/1804813002
deleted the function bodies and calling sites.

Bug: 583477
Change-Id: I9982d7d35ee38e0995a3103ae224b3544494ec07
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1903131
Auto-Submit: Mikel Astiz <mastiz@chromium.org>
Commit-Queue: David Trainor <dtrainor@chromium.org>
Reviewed-by: default avatarDavid Trainor <dtrainor@chromium.org>
Cr-Commit-Position: refs/heads/master@{#713587}
parent 4d293a34
...@@ -27,7 +27,6 @@ ...@@ -27,7 +27,6 @@
#include "chrome/browser/bookmarks/bookmark_model_factory.h" #include "chrome/browser/bookmarks/bookmark_model_factory.h"
#include "chrome/browser/bookmarks/managed_bookmark_service_factory.h" #include "chrome/browser/bookmarks/managed_bookmark_service_factory.h"
#include "chrome/browser/browser_process.h" #include "chrome/browser/browser_process.h"
#include "chrome/browser/favicon/favicon_service_factory.h"
#include "chrome/browser/history/android/sqlite_cursor.h" #include "chrome/browser/history/android/sqlite_cursor.h"
#include "chrome/browser/history/history_service_factory.h" #include "chrome/browser/history/history_service_factory.h"
#include "chrome/browser/history/top_sites_factory.h" #include "chrome/browser/history/top_sites_factory.h"
...@@ -37,7 +36,6 @@ ...@@ -37,7 +36,6 @@
#include "components/bookmarks/browser/bookmark_model.h" #include "components/bookmarks/browser/bookmark_model.h"
#include "components/bookmarks/browser/bookmark_utils.h" #include "components/bookmarks/browser/bookmark_utils.h"
#include "components/bookmarks/managed/managed_bookmark_service.h" #include "components/bookmarks/managed/managed_bookmark_service.h"
#include "components/favicon/core/favicon_service.h"
#include "components/history/core/browser/android/android_history_types.h" #include "components/history/core/browser/android/android_history_types.h"
#include "components/history/core/browser/top_sites.h" #include "components/history/core/browser/top_sites.h"
#include "components/search_engines/template_url.h" #include "components/search_engines/template_url.h"
...@@ -45,7 +43,6 @@ ...@@ -45,7 +43,6 @@
#include "content/public/browser/browser_thread.h" #include "content/public/browser/browser_thread.h"
#include "ui/base/layout.h" #include "ui/base/layout.h"
#include "ui/base/resource/resource_bundle.h" #include "ui/base/resource/resource_bundle.h"
#include "ui/gfx/favicon_size.h"
using base::android::AttachCurrentThread; using base::android::AttachCurrentThread;
using base::android::CheckException; using base::android::CheckException;
...@@ -315,7 +312,7 @@ class IsInMobileBookmarksBranchTask : public BookmarkModelTask { ...@@ -315,7 +312,7 @@ class IsInMobileBookmarksBranchTask : public BookmarkModelTask {
// ------------- Aynchronous requests classes ------------- // // ------------- Aynchronous requests classes ------------- //
// Base class for asynchronous blocking requests to Chromium services. // Base class for asynchronous blocking requests to Chromium services.
// Service: type of the service to use (e.g. HistoryService, FaviconService). // Service: type of the service to use (e.g. HistoryService).
template <typename Service> template <typename Service>
class AsyncServiceRequest : protected BlockingUIThreadAsyncRequest { class AsyncServiceRequest : protected BlockingUIThreadAsyncRequest {
public: public:
...@@ -797,8 +794,6 @@ ChromeBrowserProvider::ChromeBrowserProvider(JNIEnv* env, jobject obj) ...@@ -797,8 +794,6 @@ ChromeBrowserProvider::ChromeBrowserProvider(JNIEnv* env, jobject obj)
profile_ = g_browser_process->profile_manager()->GetLastUsedProfile(); profile_ = g_browser_process->profile_manager()->GetLastUsedProfile();
bookmark_model_ = BookmarkModelFactory::GetForBrowserContext(profile_); bookmark_model_ = BookmarkModelFactory::GetForBrowserContext(profile_);
top_sites_ = TopSitesFactory::GetForProfile(profile_); top_sites_ = TopSitesFactory::GetForProfile(profile_);
favicon_service_ = FaviconServiceFactory::GetForProfile(
profile_, ServiceAccessType::EXPLICIT_ACCESS),
service_.reset(new AndroidHistoryProviderService(profile_)); service_.reset(new AndroidHistoryProviderService(profile_));
// Register as observer for service we are interested. // Register as observer for service we are interested.
......
...@@ -21,10 +21,6 @@ ...@@ -21,10 +21,6 @@
class AndroidHistoryProviderService; class AndroidHistoryProviderService;
class Profile; class Profile;
namespace favicon {
class FaviconService;
}
namespace history { namespace history {
class TopSites; class TopSites;
} }
...@@ -139,50 +135,6 @@ class ChromeBrowserProvider : public bookmarks::BaseBookmarkModelObserver, ...@@ -139,50 +135,6 @@ class ChromeBrowserProvider : public bookmarks::BaseBookmarkModelObserver,
const base::android::JavaParamRef<jstring>& selections, const base::android::JavaParamRef<jstring>& selections,
const base::android::JavaParamRef<jobjectArray>& selection_args); const base::android::JavaParamRef<jobjectArray>& selection_args);
// Custom provider API methods. ---------------------------------------------
jlong CreateBookmarksFolderOnce(
JNIEnv* env,
const base::android::JavaParamRef<jobject>& obj,
const base::android::JavaParamRef<jstring>& title,
jlong parent_id);
void RemoveAllUserBookmarks(JNIEnv* env,
const base::android::JavaParamRef<jobject>& obj);
base::android::ScopedJavaLocalRef<jobject> GetEditableBookmarkFolders(
JNIEnv* env,
const base::android::JavaParamRef<jobject>& obj);
base::android::ScopedJavaLocalRef<jobject> GetBookmarkNode(
JNIEnv* env,
const base::android::JavaParamRef<jobject>& obj,
jlong id,
jboolean get_parent,
jboolean get_children);
base::android::ScopedJavaLocalRef<jobject> GetMobileBookmarksFolder(
JNIEnv* env,
const base::android::JavaParamRef<jobject>& obj);
jboolean IsBookmarkInMobileBookmarksBranch(
JNIEnv* env,
const base::android::JavaParamRef<jobject>& obj,
jlong id);
jboolean BookmarkNodeExists(JNIEnv* env,
const base::android::JavaParamRef<jobject>& obj,
jlong id);
base::android::ScopedJavaLocalRef<jbyteArray> GetFaviconOrTouchIcon(
JNIEnv* env,
const base::android::JavaParamRef<jobject>& obj,
const base::android::JavaParamRef<jstring>& url);
base::android::ScopedJavaLocalRef<jbyteArray> GetThumbnail(
JNIEnv* env,
const base::android::JavaParamRef<jobject>& obj,
const base::android::JavaParamRef<jstring>& url);
private: private:
~ChromeBrowserProvider() override; ~ChromeBrowserProvider() override;
...@@ -223,7 +175,6 @@ class ChromeBrowserProvider : public bookmarks::BaseBookmarkModelObserver, ...@@ -223,7 +175,6 @@ class ChromeBrowserProvider : public bookmarks::BaseBookmarkModelObserver,
Profile* profile_; Profile* profile_;
bookmarks::BookmarkModel* bookmark_model_; bookmarks::BookmarkModel* bookmark_model_;
scoped_refptr<history::TopSites> top_sites_; scoped_refptr<history::TopSites> top_sites_;
favicon::FaviconService* favicon_service_;
std::unique_ptr<AndroidHistoryProviderService> service_; std::unique_ptr<AndroidHistoryProviderService> service_;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment