Commit c2873dde authored by Victor Costan's avatar Victor Costan Committed by Commit Bot

Revert "IndexedDB: Re-enable large value wrapping."

This reverts commit 24ee6490.

Reason for revert: large value wrapping amplifies the IndexedDB Blob
leak in https://crbug.com/488851.

This CL also disables IndexedDBBrowserTest.DeleteCompactsBackingStore
due to brittleness. Re-enabling is tracked in https://crbug.com/1071292.

Original change's description:
> IndexedDB: Re-enable large value wrapping.
>
> This CL removes the feature flag gating IndexedDB large value wrapping.
> The feature will be rolled out using Chrome's standard waterfall release
> model.
>
> Bug: 844782
> Change-Id: Ie33675293a1c592c8731ab380ae9c55674ee6ae4
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2056863
> Commit-Queue: Daniel Murphy <dmurph@chromium.org>
> Auto-Submit: Victor Costan <pwnall@chromium.org>
> Reviewed-by: Daniel Murphy <dmurph@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#741600}

TBR=dmurph@chromium.org,pwnall@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 1071257, 844782, 488851
Change-Id: I1ba9fc1402c1831dd7daaa4b88fde68821a9d1d9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2151885
Commit-Queue: Victor Costan <pwnall@chromium.org>
Reviewed-by: default avatarVictor Costan <pwnall@chromium.org>
Reviewed-by: default avatarMarijn Kruisselbrink <mek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#759515}
parent 773d9c87
......@@ -1013,7 +1013,9 @@ INSTANTIATE_TEST_SUITE_P(IndexedDBBrowserTestInstantiation,
"failTransactionCommit",
"clearObjectStore"));
IN_PROC_BROWSER_TEST_F(IndexedDBBrowserTest, DeleteCompactsBackingStore) {
// TODO(crbug.com/1071292): Make this test less brittle and re-enable it.
IN_PROC_BROWSER_TEST_F(IndexedDBBrowserTest,
DISABLED_DeleteCompactsBackingStore) {
const GURL kTestUrl = GetTestUrl("indexeddb", "delete_compact.html");
const url::Origin kTestOrigin = url::Origin::Create(kTestUrl);
SimpleTest(GURL(kTestUrl.spec() + "#fill"));
......
......@@ -585,7 +585,8 @@ IDBRequest* IDBObjectStore::DoPut(ScriptState* script_state,
value_wrapper.DoneCloning();
value_wrapper.WrapIfBiggerThan(IDBValueWrapper::kWrapThreshold);
if (base::FeatureList::IsEnabled(kIndexedDBLargeValueWrapping))
value_wrapper.WrapIfBiggerThan(IDBValueWrapper::kWrapThreshold);
auto idb_value = std::make_unique<IDBValue>(
value_wrapper.TakeWireBytes(), value_wrapper.TakeBlobInfo(),
......
......@@ -27,6 +27,9 @@ class ScriptState;
class ScriptValue;
class SerializedScriptValue;
const base::Feature kIndexedDBLargeValueWrapping{
"IndexedDBLargeValueWrapping", base::FEATURE_DISABLED_BY_DEFAULT};
// Logic for serializing V8 values for storage in IndexedDB.
//
// An IDBValueWrapper instance drives the serialization of a single V8 value to
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment