Revert of [Chromoting] Remove wildcard ('*') from remoting_all target....
Revert of [Chromoting] Remove wildcard ('*') from remoting_all target. (patchset #8 id:140001 of https://codereview.chromium.org/896743004/) Reason for revert: It cause ChromiumOS.Chromium and PFQ bots to fail. The reason might because chroot didn't have "dpkg-architecture" command. The correct solution might be add "dpkg-architecture" command to chroot. But this CL currently break PFQ and a bunch of bots. So revert it for immediate fix. See crbug.com/456491 Original issue's description: > [Chromoting] Remove wildcard ('*') from remoting_all target. > > Support for the wildcard is going away in GN, so this helps prepare for the transition away from GYP. > > This cl adds dummy targets so that that logic for when the proper targets should be build can be kept in the platform-specific files. > > Some of the conditions in the host gyp files needed to be restructured so that the dummy targets would be defined only when necessary. The updated conditions caused a lot of lines to be re-indented, but the target definitions are the same (except for the new dummy targets). > > BUG= > > Committed: https://crrev.com/9fb75ed89c0ae4ced679576f9cf030cc8c30e928 > Cr-Commit-Position: refs/heads/master@{#315150} TBR=kelvinp@chromium.org,garykac@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Review URL: https://codereview.chromium.org/905223002 Cr-Commit-Position: refs/heads/master@{#315261}
Showing
This diff is collapsed.
This diff is collapsed.
This diff is collapsed.
Please register or sign in to comment