Commit c2bd3712 authored by Kyle Horimoto's avatar Kyle Horimoto Committed by Commit Bot

Reland "[CrOS settings] Fix printing new route in settings page"

This reverts commit 3e252473.

Reason for revert: Original CL did not cause the flake; flake was fixed in separate CL: https://chromium-review.googlesource.com/c/chromium/src/+/2141113

Original change's description:
> Revert "[CrOS settings] Fix printing new route in settings page"
>
> This reverts commit 4c027362.
>
> Reason for revert: Potentially breaking https://ci.chromium.org/p/chrome/builders/ci/linux-chromeos-chrome/4672
>
> Original change's description:
> > [CrOS settings] Fix printing new route in settings page
> >
> > https://chromium-review.googlesource.com/c/chromium/src/+/2126332
> > Changes the routes to printing pages in settings. os_printing_page has a
> > route that was missed. This CL updates the route in
> > os_printing_page.html to match the new route, from /printing to
> > osPrinting.
> >
> > Fix: 1068322
> > Change-Id: I2e9095ff805d2f94bf4c520717d3290fab912807
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2138632
> > Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
> > Reviewed-by: jimmy gong <jimmyxgong@chromium.org>
> > Commit-Queue: Nnamdi Theodore Johnson-kanu <tjohnsonkanu@google.com>
> > Cr-Commit-Position: refs/heads/master@{#756949}
>
> TBR=khorimoto@chromium.org,jimmyxgong@chromium.org,hsuregan@chromium.org,tjohnsonkanu@google.com
>
> Change-Id: I50d29f93d85233a198f62baec0e65b4c5eda9b4f
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2139172
> Reviewed-by: Melissa Zhang <melzhang@chromium.org>
> Commit-Queue: Melissa Zhang <melzhang@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#756973}

TBR=khorimoto@chromium.org,jimmyxgong@chromium.org,hsuregan@chromium.org,melzhang@chromium.org,tjohnsonkanu@google.com

# Not skipping CQ checks because original CL landed > 1 day ago.

Fixed: 1068322
Change-Id: I25cee2d65483a5a48b70d80c0469b6058d298f32
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2142137
Commit-Queue: Kyle Horimoto <khorimoto@chromium.org>
Reviewed-by: default avatarKyle Horimoto <khorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#757559}
parent a5260e88
...@@ -11,7 +11,7 @@ ...@@ -11,7 +11,7 @@
<dom-module id="os-settings-printing-page"> <dom-module id="os-settings-printing-page">
<template> <template>
<style include="settings-shared"></style> <style include="settings-shared"></style>
<settings-animated-pages id="pages" section="printing" <settings-animated-pages id="pages" section="osPrinting"
focus-config="[[focusConfig_]]"> focus-config="[[focusConfig_]]">
<div route-path="default"> <div route-path="default">
<cr-link-row id="cupsPrinters" label="$i18n{cupsPrintersTitle}" <cr-link-row id="cupsPrinters" label="$i18n{cupsPrintersTitle}"
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment