Commit c2efe62d authored by Tarun Bansal's avatar Tarun Bansal Committed by Commit Bot

Attempt to deflake resource loading hints browsertests

Skip the blacklist check in resource loading
hints browsertest. This has been a cause of flakiness
in previews browser tests previously.

Bug: 904014,904500
Change-Id: Ia8386c7e010d0976830ec0a84b7e1441acd87f00
Reviewed-on: https://chromium-review.googlesource.com/c/1333994Reviewed-by: default avatarDoug Arnett <dougarnett@chromium.org>
Commit-Queue: Tarun Bansal <tbansal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#607664}
parent 2094eb4c
...@@ -27,6 +27,7 @@ ...@@ -27,6 +27,7 @@
#include "components/previews/content/previews_ui_service.h" #include "components/previews/content/previews_ui_service.h"
#include "components/previews/core/previews_black_list.h" #include "components/previews/core/previews_black_list.h"
#include "components/previews/core/previews_features.h" #include "components/previews/core/previews_features.h"
#include "components/previews/core/previews_switches.h"
#include "content/public/browser/browser_task_traits.h" #include "content/public/browser/browser_task_traits.h"
#include "content/public/test/browser_test_utils.h" #include "content/public/test/browser_test_utils.h"
#include "net/test/embedded_test_server/http_request.h" #include "net/test/embedded_test_server/http_request.h"
...@@ -132,6 +133,11 @@ class ResourceLoadingNoFeaturesBrowserTest : public InProcessBrowserTest { ...@@ -132,6 +133,11 @@ class ResourceLoadingNoFeaturesBrowserTest : public InProcessBrowserTest {
void SetUpCommandLine(base::CommandLine* cmd) override { void SetUpCommandLine(base::CommandLine* cmd) override {
cmd->AppendSwitch("enable-spdy-proxy-auth"); cmd->AppendSwitch("enable-spdy-proxy-auth");
// Due to race conditions, it's possible that blacklist data is not loaded
// at the time of first navigation. That may prevent Preview from
// triggering, and causing the test to flake.
cmd->AppendSwitch(previews::switches::kIgnorePreviewsBlacklist);
} }
void SetDefaultOnlyResourceLoadingHints( void SetDefaultOnlyResourceLoadingHints(
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment