Commit c30cc4aa authored by Nohemi Fernandez's avatar Nohemi Fernandez Committed by Commit Bot

[iOS] Disable Discover Feed in Chrome Sign-in tests.

The spinner causes EarlGrey to crash following 'infinite' page wait.

Bug: 1116650
Change-Id: I20c808dfe77115ba10ba2da5ea06d60688bf76da
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2375173
Commit-Queue: Nohemi Fernandez <fernandex@chromium.org>
Commit-Queue: Sergio Collazos <sczs@chromium.org>
Auto-Submit: Nohemi Fernandez <fernandex@chromium.org>
Reviewed-by: default avatarSergio Collazos <sczs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#801473}
parent 16725934
...@@ -106,6 +106,7 @@ source_set("eg2_tests") { ...@@ -106,6 +106,7 @@ source_set("eg2_tests") {
"//base/test:test_support", "//base/test:test_support",
"//ios/chrome/app/strings", "//ios/chrome/app/strings",
"//ios/chrome/browser/ui/authentication:eg_test_support+eg2", "//ios/chrome/browser/ui/authentication:eg_test_support+eg2",
"//ios/chrome/browser/ui/content_suggestions:feature_flags",
"//ios/chrome/browser/ui/recent_tabs:recent_tabs_ui_constants", "//ios/chrome/browser/ui/recent_tabs:recent_tabs_ui_constants",
"//ios/chrome/test/earl_grey:eg_test_support+eg2", "//ios/chrome/test/earl_grey:eg_test_support+eg2",
"//ios/public/provider/chrome/browser/signin:constants", "//ios/public/provider/chrome/browser/signin:constants",
......
...@@ -9,6 +9,7 @@ ...@@ -9,6 +9,7 @@
#include "base/test/scoped_feature_list.h" #include "base/test/scoped_feature_list.h"
#import "ios/chrome/browser/ui/authentication/signin_earl_grey.h" #import "ios/chrome/browser/ui/authentication/signin_earl_grey.h"
#import "ios/chrome/browser/ui/authentication/signin_earl_grey_ui.h" #import "ios/chrome/browser/ui/authentication/signin_earl_grey_ui.h"
#import "ios/chrome/browser/ui/content_suggestions/content_suggestions_feature.h"
#import "ios/chrome/browser/ui/recent_tabs/recent_tabs_constants.h" #import "ios/chrome/browser/ui/recent_tabs/recent_tabs_constants.h"
#include "ios/chrome/grit/ios_strings.h" #include "ios/chrome/grit/ios_strings.h"
#import "ios/chrome/test/earl_grey/chrome_earl_grey.h" #import "ios/chrome/test/earl_grey/chrome_earl_grey.h"
...@@ -115,6 +116,12 @@ void ChooseImportOrKeepDataSepareteDialog(id<GREYMatcher> choiceButtonMatcher) { ...@@ -115,6 +116,12 @@ void ChooseImportOrKeepDataSepareteDialog(id<GREYMatcher> choiceButtonMatcher) {
@implementation SigninCoordinatorTestCase @implementation SigninCoordinatorTestCase
- (AppLaunchConfiguration)appConfigurationForTestCase {
AppLaunchConfiguration config;
config.features_disabled.push_back(kDiscoverFeedInNtp);
return config;
}
- (void)setUp { - (void)setUp {
[super setUp]; [super setUp];
// Remove closed tab history to make sure the sign-in promo is always visible // Remove closed tab history to make sure the sign-in promo is always visible
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment