Commit c312b420 authored by tfarina's avatar tfarina Committed by Commit bot

Reland "components: Fix 'gn check' errors for omnibox."

This reverts commit cc83d2d6.

Tested on Linux with the following command lines:

$ gn gen out-gn/Release --args='is_debug=false is_component_build=false symbol_level=1'
$ gn check out-gn/Release //components/omnibox/*

BUG=367595, 376000
TEST=see above
R=brettw@chromium.org

Review URL: https://codereview.chromium.org/1242973003

Cr-Commit-Position: refs/heads/master@{#339700}
parent a250ccfb
...@@ -36,6 +36,8 @@ check_targets = [ ...@@ -36,6 +36,8 @@ check_targets = [
"//components/app_modal/*", "//components/app_modal/*",
"//components/autofill/*", "//components/autofill/*",
"//components/bookmarks/*", "//components/bookmarks/*",
"//components/google/*",
"//components/omnibox/*",
"//components/os_crypt/*", "//components/os_crypt/*",
"//components/pref_registry/*", "//components/pref_registry/*",
"//components/undo/*", "//components/undo/*",
......
...@@ -300,8 +300,8 @@ test("components_unittests") { ...@@ -300,8 +300,8 @@ test("components_unittests") {
"//components/undo:unit_tests", "//components/undo:unit_tests",
"//components/update_client:unit_tests", "//components/update_client:unit_tests",
"//components/variations:unit_tests", "//components/variations:unit_tests",
"//components/web_resource:unit_tests",
"//components/webcrypto:unit_tests", "//components/webcrypto:unit_tests",
"//components/web_resource:unit_tests",
"//components/webdata/common:unit_tests", "//components/webdata/common:unit_tests",
# These are the deps required by the code in this target. # These are the deps required by the code in this target.
......
...@@ -84,6 +84,7 @@ source_set("browser") { ...@@ -84,6 +84,7 @@ source_set("browser") {
":in_memory_url_index_cache_proto", ":in_memory_url_index_cache_proto",
"//base", "//base",
"//base:i18n", "//base:i18n",
"//base:prefs",
"//components/bookmarks/browser", "//components/bookmarks/browser",
"//components/keyed_service/core", "//components/keyed_service/core",
"//components/pref_registry", "//components/pref_registry",
...@@ -91,6 +92,7 @@ source_set("browser") { ...@@ -91,6 +92,7 @@ source_set("browser") {
"//components/resources", "//components/resources",
"//components/search", "//components/search",
"//components/search_engines", "//components/search_engines",
"//components/sessions",
"//components/strings", "//components/strings",
"//components/url_fixer", "//components/url_fixer",
"//components/variations", "//components/variations",
...@@ -122,6 +124,8 @@ static_library("test_support") { ...@@ -122,6 +124,8 @@ static_library("test_support") {
":browser", ":browser",
"//base", "//base",
"//components/metrics/proto", "//components/metrics/proto",
"//components/search_engines",
"//net",
"//testing/gmock", "//testing/gmock",
] ]
} }
...@@ -144,7 +148,12 @@ source_set("unit_tests") { ...@@ -144,7 +148,12 @@ source_set("unit_tests") {
deps = [ deps = [
":browser", ":browser",
":test_support", ":test_support",
"//base",
"//components/search",
"//components/search_engines",
"//components/variations",
"//testing/gmock", "//testing/gmock",
"//testing/gtest", "//testing/gtest",
"//url",
] ]
} }
...@@ -22,6 +22,10 @@ if (!is_ios) { ...@@ -22,6 +22,10 @@ if (!is_ios) {
configs += [ ":implementation" ] configs += [ ":implementation" ]
public_deps = [
":shared",
]
deps = [ deps = [
":shared", ":shared",
"//base", "//base",
...@@ -40,6 +44,10 @@ if (!is_ios) { ...@@ -40,6 +44,10 @@ if (!is_ios) {
"ios/ios_serialized_navigation_driver.h", "ios/ios_serialized_navigation_driver.h",
] ]
public_deps = [
":shared",
]
deps = [ deps = [
":shared", ":shared",
"//base", "//base",
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment