Skip to content

GitLab

T
tangled
Commit c32fbe04 authored by Kenichi Ishibashi's avatar Kenichi Ishibashi Committed by Commit Bot
Browse files
Options

Remove blink_memory_mobile benchmark 

We need to migrate pagesets to WprGo but I don't think
blink_memory_mobile is worth updating because it tracks almost the same
metrics as system_health benchmarks do. This benchmark should be
superseded by system_health.memory_mobile.

BUG=730036

Change-Id: Ic6877c733efce8ffd42cb3d570fb8ec55456d7b7
Reviewed-on: https://chromium-review.googlesource.com/595347Reviewed-by: default avatarTakashi Sakamoto <tasak@google.com>
Reviewed-by: default avatarKentaro Hara <haraken@chromium.org>
Reviewed-by: default avatarHelen Li <xunjieli@chromium.org>
Reviewed-by: default avatarNed Nguyen <nednguyen@google.com>
Commit-Queue: Ned Nguyen <nednguyen@google.com>
Cr-Commit-Position: refs/heads/master@{#491084}
parent 1f832885
Expand all Hide whitespace changes
Inline Side-by-side
Showing with 0 additions and 606 deletions
testing/buildbot/chromium.perf.json
View file @ c32fbe04
This diff is collapsed.
tools/perf/benchmark.csv
View file @ c32fbe04
......@@ -36,7 +36,6 @@ media.mse_cases,"crouleau@chromium.org, videostack-eng@google.com",Internals>Med
media.tough_video_cases,crouleau@chromium.org,Internals>Media
media.tough_video_cases_tbmv2,"johnchen@chromium.org, crouleau@chromium.org",Internals>Media
media_perftests,crouleau@chromium.org,
memory.blink_memory_mobile,bashi@chromium.org,
memory.desktop,erikchen@chromium.org,
memory.long_running_idle_gmail_background_tbmv2,ulan@chromium.org,
memory.long_running_idle_gmail_tbmv2,ulan@chromium.org,
......
tools/perf/benchmarks/memory.py
View file @ c32fbe04
......@@ -113,42 +113,6 @@ class MemoryBenchmarkTop10Mobile(_MemoryInfra):
return page_sets.MemoryTop10MobileStoryExpectations()
@benchmark.Enabled('android') # catapult:#3176
@benchmark.Owner(emails=['bashi@chromium.org'])
class RendererMemoryBlinkMemoryMobile(_MemoryInfra):
"""Timeline based benchmark for measuring memory consumption on mobile
sites on which blink's memory consumption is relatively high.
"""
page_set = page_sets.BlinkMemoryMobilePageSet
def SetExtraBrowserOptions(self, options):
super(RendererMemoryBlinkMemoryMobile, self).SetExtraBrowserOptions(
options)
options.AppendExtraBrowserArgs([
# Ignore certs errors because record_wpr cannot handle certs correctly
# in some cases (e.g. WordPress).
'--ignore-certificate-errors',
])
@classmethod
def Name(cls):
return 'memory.blink_memory_mobile'
@classmethod
def ValueCanBeAddedPredicate(cls, value, is_first_result):
return (not _IGNORED_STATS_RE.search(value.name) and
'renderer_processes' in value.name)
@classmethod
def ShouldDisable(cls, possible_browser):
# http://crbug.com/634319
return (possible_browser.browser_type == 'reference' and
possible_browser.platform.GetDeviceTypeName() == 'Nexus 5X')
def GetExpectations(self):
return page_sets.BlinkMemoryMobileStoryExpectations()
class _MemoryV8Benchmark(_MemoryInfra):
# Report only V8-specific and overall renderer memory values. Note that
......
tools/perf/core/benchmark_sharding_map.json
View file @ c32fbe04
......@@ -48,7 +48,6 @@
"benchmarks": [
"blink_perf.shadow_dom",
"dromaeo.domcorequery",
"memory.blink_memory_mobile",
"page_cycler_v2.intl_ko_th_vi",
"power.idle_platform",
"smoothness.gpu_rasterization_and_decoding.image_decoding_cases",
......@@ -279,7 +278,6 @@
"benchmarks": [
"blink_perf.shadow_dom",
"dromaeo.domcorequery",
"memory.blink_memory_mobile",
"page_cycler_v2.intl_ko_th_vi",
"power.idle_platform",
"smoothness.gpu_rasterization_and_decoding.image_decoding_cases",
......@@ -505,7 +503,6 @@
"battor.steady_state",
"blink_perf.canvas",
"blink_perf.paint",
"memory.blink_memory_mobile",
"power.idle_platform",
"smoothness.image_decoding_cases",
"start_with_ext.warm.blank_page"
......@@ -716,7 +713,6 @@
"benchmarks": [
"blink_perf.shadow_dom",
"dromaeo.domcorequery",
"memory.blink_memory_mobile",
"page_cycler_v2.intl_ko_th_vi",
"power.idle_platform",
"smoothness.gpu_rasterization_and_decoding.image_decoding_cases",
......@@ -942,7 +938,6 @@
"battor.steady_state",
"blink_perf.canvas",
"blink_perf.paint",
"memory.blink_memory_mobile",
"power.idle_platform",
"smoothness.image_decoding_cases",
"start_with_ext.warm.blank_page"
......@@ -1326,7 +1321,6 @@
"benchmarks": [
"blink_perf.shadow_dom",
"dromaeo.domcorequery",
"memory.blink_memory_mobile",
"page_cycler_v2.intl_ko_th_vi",
"power.idle_platform",
"smoothness.gpu_rasterization_and_decoding.image_decoding_cases",
......@@ -1382,7 +1376,6 @@
"build17-b1--device7": {
"benchmarks": [
"kraken",
"memory.blink_memory_mobile",
"page_cycler_v2.intl_ko_th_vi",
"power.idle_platform",
"start_with_ext.warm.blank_page",
......@@ -1615,7 +1608,6 @@
"benchmarks": [
"blink_perf.shadow_dom",
"dromaeo.domcorequery",
"memory.blink_memory_mobile",
"page_cycler_v2.intl_ko_th_vi",
"power.idle_platform",
"smoothness.gpu_rasterization_and_decoding.image_decoding_cases",
......@@ -1936,7 +1928,6 @@
"loading.mobile",
"media.mse_cases",
"media.tough_video_cases_tbmv2",
"memory.blink_memory_mobile",
"memory.long_running_idle_gmail_tbmv2",
"memory.top_10_mobile_stress",
"page_cycler_v2_site_isolation.basic_oopif",
......@@ -2103,7 +2094,6 @@
"loading.mobile",
"media.mse_cases",
"media.tough_video_cases_tbmv2",
"memory.blink_memory_mobile",
"memory.long_running_idle_gmail_tbmv2",
"memory.top_10_mobile_stress",
"page_cycler_v2_site_isolation.basic_oopif",
......@@ -2270,7 +2260,6 @@
"loading.mobile",
"media.mse_cases",
"media.tough_video_cases_tbmv2",
"memory.blink_memory_mobile",
"memory.long_running_idle_gmail_tbmv2",
"memory.top_10_mobile_stress",
"page_cycler_v2_site_isolation.basic_oopif",
......@@ -2437,7 +2426,6 @@
"loading.mobile",
"media.mse_cases",
"media.tough_video_cases_tbmv2",
"memory.blink_memory_mobile",
"memory.long_running_idle_gmail_tbmv2",
"memory.top_10_mobile_stress",
"page_cycler_v2_site_isolation.basic_oopif",
......@@ -2604,7 +2592,6 @@
"loading.mobile",
"media.mse_cases",
"media.tough_video_cases_tbmv2",
"memory.blink_memory_mobile",
"memory.long_running_idle_gmail_tbmv2",
"memory.top_10_mobile_stress",
"page_cycler_v2_site_isolation.basic_oopif",
......@@ -2771,7 +2758,6 @@
"loading.mobile",
"media.mse_cases",
"media.tough_video_cases_tbmv2",
"memory.blink_memory_mobile",
"memory.long_running_idle_gmail_tbmv2",
"memory.top_10_mobile_stress",
"page_cycler_v2_site_isolation.basic_oopif",
......@@ -2810,7 +2796,6 @@
"loading.mobile",
"media.mse_cases",
"media.tough_video_cases_tbmv2",
"memory.blink_memory_mobile",
"memory.long_running_idle_gmail_tbmv2",
"memory.top_10_mobile_stress",
"page_cycler_v2_site_isolation.basic_oopif",
......@@ -2978,7 +2963,6 @@
"build137-b1": {
"benchmarks": [
"loading.desktop",
"memory.blink_memory_mobile",
"smoothness.gpu_rasterization.polymer",
"v8.runtimestats.browsing_mobile_classic"
]
......@@ -3340,7 +3324,6 @@
"loading.mobile",
"media.mse_cases",
"media.tough_video_cases_tbmv2",
"memory.blink_memory_mobile",
"memory.long_running_idle_gmail_tbmv2",
"memory.top_10_mobile_stress",
"page_cycler_v2_site_isolation.basic_oopif",
......@@ -3380,7 +3363,6 @@
"build186-b4": {
"benchmarks": [
"loading.desktop",
"memory.blink_memory_mobile",
"smoothness.gpu_rasterization.polymer",
"v8.runtimestats.browsing_mobile_classic"
]
......@@ -3743,7 +3725,6 @@
"loading.mobile",
"media.mse_cases",
"media.tough_video_cases_tbmv2",
"memory.blink_memory_mobile",
"memory.long_running_idle_gmail_tbmv2",
"memory.top_10_mobile_stress",
"page_cycler_v2_site_isolation.basic_oopif",
......@@ -3909,7 +3890,6 @@
"loading.mobile",
"media.mse_cases",
"media.tough_video_cases_tbmv2",
"memory.blink_memory_mobile",
"memory.long_running_idle_gmail_tbmv2",
"memory.top_10_mobile_stress",
"page_cycler_v2_site_isolation.basic_oopif",
......@@ -4076,7 +4056,6 @@
"loading.mobile",
"media.mse_cases",
"media.tough_video_cases_tbmv2",
"memory.blink_memory_mobile",
"memory.long_running_idle_gmail_tbmv2",
"memory.top_10_mobile_stress",
"page_cycler_v2_site_isolation.basic_oopif",
......@@ -4244,7 +4223,6 @@
"loading.mobile",
"media.mse_cases",
"media.tough_video_cases_tbmv2",
"memory.blink_memory_mobile",
"memory.long_running_idle_gmail_tbmv2",
"memory.top_10_mobile_stress",
"page_cycler_v2_site_isolation.basic_oopif",
......@@ -4410,7 +4388,6 @@
"loading.mobile",
"media.mse_cases",
"media.tough_video_cases_tbmv2",
"memory.blink_memory_mobile",
"memory.long_running_idle_gmail_tbmv2",
"memory.top_10_mobile_stress",
"page_cycler_v2_site_isolation.basic_oopif",
......@@ -4577,7 +4554,6 @@
"loading.mobile",
"media.mse_cases",
"media.tough_video_cases_tbmv2",
"memory.blink_memory_mobile",
"memory.long_running_idle_gmail_tbmv2",
"memory.top_10_mobile_stress",
"page_cycler_v2_site_isolation.basic_oopif",
......@@ -4745,7 +4721,6 @@
"loading.mobile",
"media.mse_cases",
"media.tough_video_cases_tbmv2",
"memory.blink_memory_mobile",
"memory.long_running_idle_gmail_tbmv2",
"memory.top_10_mobile_stress",
"page_cycler_v2_site_isolation.basic_oopif",
......@@ -4803,7 +4778,6 @@
"media.mse_cases",
"media.tough_video_cases",
"media.tough_video_cases_tbmv2",
"memory.blink_memory_mobile",
"memory.desktop",
"memory.long_running_idle_gmail_background_tbmv2",
"memory.long_running_idle_gmail_tbmv2",
......
tools/perf/page_sets/blink_memory_mobile.py deleted 100644 → 0
View file @ 1f832885
# Copyright 2015 The Chromium Authors. All rights reserved.
# Use of this source code is governed by a BSD-style license that can be
# found in the LICENSE file.
import logging
from telemetry.page import page as page_module
from telemetry.page import shared_page_state
from telemetry import story
from page_sets.login_helpers import google_login
DUMP_WAIT_TIME = 3
class BlinkMemoryMobilePage(page_module.Page):
def __init__(self, url, page_set, name):
super(BlinkMemoryMobilePage, self).__init__(
url=url, page_set=page_set, name=name,
shared_page_state_class=shared_page_state.SharedMobilePageState,
credentials_path='data/credentials.json')
self.archive_data_file = 'data/blink_memory_mobile.json'
def _DumpMemory(self, action_runner, phase):
with action_runner.CreateInteraction(phase):
action_runner.Wait(DUMP_WAIT_TIME)
action_runner.ForceGarbageCollection()
action_runner.SimulateMemoryPressureNotification('critical')
action_runner.Wait(DUMP_WAIT_TIME)
if not action_runner.tab.browser.DumpMemory():
logging.error('Unable to get a memory dump for %s.', self.name)
def RunPageInteractions(self, action_runner):
action_runner.ScrollPage()
self._DumpMemory(action_runner, 'scrolled')
class TheVergePage(BlinkMemoryMobilePage):
COMMENT_LINK_SELECTOR = '.show_comments_link'
def __init__(self, page_set):
super(TheVergePage, self).__init__(
'http://www.theverge.com/2015/8/11/9133883/taylor-swift-spotify-discover-weekly-what-is-going-on',
page_set=page_set,
name='TheVerge')
def RunPageInteractions(self, action_runner):
action_runner.WaitForElement(selector=TheVergePage.COMMENT_LINK_SELECTOR)
action_runner.ExecuteJavaScript(
'window.location.hash = "comments"')
action_runner.TapElement(
selector=TheVergePage.COMMENT_LINK_SELECTOR)
action_runner.WaitForJavaScriptCondition(
'window.Chorus.Comments.collection.length > 0')
super(TheVergePage, self).RunPageInteractions(action_runner)
class FacebookPage(BlinkMemoryMobilePage):
def __init__(self, page_set):
super(FacebookPage, self).__init__(
'https://facebook.com/barackobama',
page_set=page_set,
name='Facebook')
def RunNavigateSteps(self, action_runner):
super(FacebookPage, self).RunNavigateSteps(action_runner)
action_runner.WaitForJavaScriptCondition(
'document.getElementById("u_0_c") !== null &&'
'document.body.scrollHeight > window.innerHeight')
class GmailPage(BlinkMemoryMobilePage):
def __init__(self, page_set):
super(GmailPage, self).__init__(
'https://mail.google.com/mail/',
page_set=page_set,
name='Gmail')
def RunNavigateSteps(self, action_runner):
google_login.LoginGoogleAccount(action_runner, 'google',
self.credentials_path)
super(GmailPage, self).RunNavigateSteps(action_runner)
action_runner.WaitForElement(selector='#apploadingdiv')
action_runner.WaitForJavaScriptCondition(
'document.querySelector("#apploadingdiv").style.opacity == "0"')
class BlinkMemoryMobilePageSet(story.StorySet):
"""Key mobile sites for Blink memory reduction."""
def __init__(self):
super(BlinkMemoryMobilePageSet, self).__init__(
archive_data_file='data/blink_memory_mobile.json',
cloud_storage_bucket=story.PARTNER_BUCKET)
# Why: High rate of Blink's memory consumption rate.
self.AddStory(BlinkMemoryMobilePage(
'https://www.pinterest.com',
page_set=self,
name='Pinterest'))
self.AddStory(FacebookPage(self))
self.AddStory(TheVergePage(self))
# Why: High rate of Blink's memory comsumption rate on low-RAM devices.
self.AddStory(BlinkMemoryMobilePage(
'http://en.m.wikipedia.org/wiki/Wikipedia',
page_set=self,
name='Wikipedia (1 tab) - delayed scroll start',))
self.AddStory(BlinkMemoryMobilePage(
url='http://www.reddit.com/r/programming/comments/1g96ve',
page_set=self,
name='Reddit'))
self.AddStory(BlinkMemoryMobilePage(
'https://en.blog.wordpress.com/2012/09/04/freshly-pressed-editors-picks-for-august-2012/',
page_set=self,
name='Wordpress'))
# Why: Renderer memory usage is high.
self.AddStory(BlinkMemoryMobilePage(
'http://worldjournal.com/',
page_set=self,
name='Worldjournal'))
# Why: Key products.
self.AddStory(GmailPage(page_set=self))
self.AddStory(BlinkMemoryMobilePage(
'http://googlewebmastercentral.blogspot.com/2015/04/rolling-out-mobile-friendly-update.html?m=1',
page_set=self,
name='Blogger'))
self.AddStory(BlinkMemoryMobilePage(
'https://plus.google.com/app/basic/110031535020051778989/posts?source=apppromo',
page_set=self,
name='GooglePlus'))
class BlinkMemoryMobileStoryExpectations(story.expectations.StoryExpectations):
def SetExpectations(self):
pass # No tests disabled.
tools/perf/page_sets/data/blink_memory_mobile.json deleted 100644 → 0
View file @ 1f832885
{
"archives": {
"Blogger": {
"DEFAULT": "blink_memory_mobile_000.wpr"
},
"Gmail": {
"DEFAULT": "blink_memory_mobile_000.wpr"
},
"GooglePlus": {
"DEFAULT": "blink_memory_mobile_000.wpr"
},
"Pinterest": {
"DEFAULT": "blink_memory_mobile_000.wpr"
},
"Reddit": {
"DEFAULT": "blink_memory_mobile_000.wpr"
},
"TheVerge": {
"DEFAULT": "blink_memory_mobile_003.wpr"
},
"Wikipedia (1 tab) - delayed scroll start": {
"DEFAULT": "blink_memory_mobile_000.wpr"
},
"Wordpress": {
"DEFAULT": "blink_memory_mobile_000.wpr"
},
"Worldjournal": {
"DEFAULT": "blink_memory_mobile_000.wpr"
},
"https://facebook.com/barackobama": {
"DEFAULT": "blink_memory_mobile_000.wpr"
}
},
"description": "Describes the Web Page Replay archives for a story set. Don't edit by hand! Use record_wpr for updating.",
"platform_specific": true
}
\ No newline at end of file
tools/perf/page_sets/data/blink_memory_mobile_000.wpr.sha1 deleted 100644 → 0
View file @ 1f832885
eebd09a79b9b9dc23cbca9826c65b11e39830118
\ No newline at end of file
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment