Commit c3414cc4 authored by Ted Choc's avatar Ted Choc Committed by Commit Bot

Revert "Sheriff: mark a few omnibox.UrlBarTest as flaky as the test suite flakes a lot."

This reverts commit 336bb21b.

Reason for revert: From the comment on the bug, these failures were a red herring and the underlying issue was an auth one.  If you have explicit failure logs that were these tests failing then please add them to the bug.

Original change's description:
> Sheriff: mark a few omnibox.UrlBarTest as flaky as the test suite flakes a lot.
> 
> Bug: 908542
> Change-Id: Ibf9b8f2ac2c5bcdd14dcf65483d576fe61a3bf8d
> TBR: tedchoc@chromium.org
> Reviewed-on: https://chromium-review.googlesource.com/c/1351428
> Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
> Commit-Queue: Mounir Lamouri <mlamouri@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#610958}

TBR=mlamouri@chromium.org,tedchoc@chromium.org

Change-Id: I9df39181033b11a2ac8e3b0e8e395bdb0a626e1d
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 908542
Reviewed-on: https://chromium-review.googlesource.com/c/1352336Reviewed-by: default avatarTed Choc <tedchoc@chromium.org>
Commit-Queue: Ted Choc <tedchoc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611191}
parent 521fe812
......@@ -32,7 +32,6 @@ import org.chromium.base.ThreadUtils;
import org.chromium.base.test.util.CallbackHelper;
import org.chromium.base.test.util.CommandLineFlags;
import org.chromium.base.test.util.Feature;
import org.chromium.base.test.util.FlakyTest;
import org.chromium.base.test.util.Restriction;
import org.chromium.base.test.util.RetryOnFailure;
import org.chromium.base.test.util.parameter.CommandLineParameter;
......@@ -637,7 +636,6 @@ public class UrlBarTest {
@SmallTest
@Feature({"Omnibox"})
@RetryOnFailure
@FlakyTest(message = "crbug.com/908542")
public void testBatchModeChangesTriggerCorrectSuggestions() throws InterruptedException {
mActivityTestRule.startMainActivityOnBlankPage();
......@@ -689,7 +687,6 @@ public class UrlBarTest {
@SmallTest
@Feature("Omnibox")
@RetryOnFailure
@FlakyTest(message = "crbug.com/908542")
public void testAutocompleteCorrectlyPerservedOnBatchMode() throws InterruptedException {
mActivityTestRule.startMainActivityOnBlankPage();
stubLocationBarAutocomplete();
......@@ -850,7 +847,6 @@ public class UrlBarTest {
@Feature("Omnibox")
@RetryOnFailure
@Restriction({RESTRICTION_TYPE_NON_LOW_END_DEVICE}) // crbug.com/635714
@FlakyTest(message = "crbug.com/908542")
public void testDelayedCompositionCorrectedWithAutocomplete()
throws InterruptedException, ExecutionException {
mActivityTestRule.startMainActivityOnBlankPage();
......@@ -996,7 +992,6 @@ public class UrlBarTest {
@SmallTest
@Feature({"Omnibox"})
@RetryOnFailure
@FlakyTest(message = "crbug.com/908542")
public void testFocusingOnStartup() {
Intent intent = new Intent(Intent.ACTION_MAIN);
intent.addCategory(Intent.CATEGORY_LAUNCHER);
......@@ -1023,7 +1018,6 @@ public class UrlBarTest {
@SmallTest
@Feature({"Omnibox"})
@RetryOnFailure
@FlakyTest(message = "crbug.com/908542")
public void testCutHuge() throws InterruptedException {
mActivityTestRule.startMainActivityWithURL(HUGE_URL);
toggleFocusAndIgnoreImeOperations(getUrlBar(), true);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment