Commit c34462d2 authored by Demetrios Papadopoulos's avatar Demetrios Papadopoulos Committed by Commit Bot

Disable remaining WebuI A11y obsolete tests (using axs_testing.js)

Bug: 807458
Change-Id: I22eafec23c447becaba75d19c4e710861c050bca
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1928238
Commit-Queue: Hector Carmona <hcarmona@chromium.org>
Auto-Submit: Demetrios Papadopoulos <dpapad@chromium.org>
Reviewed-by: default avatarHector Carmona <hcarmona@chromium.org>
Cr-Commit-Position: refs/heads/master@{#717730}
parent 5ac79f5a
......@@ -16,8 +16,6 @@ InvalidationsWebUITest.prototype = {
* Browse to the Invalidations page.
*/
browsePreload: 'chrome://invalidations',
runAccessibilityChecks: false,
accessibilityIssuesAreErrors: false
};
// Test that registering an invalidations appears properly on the textarea.
......
......@@ -25,9 +25,6 @@ BluetoothInternalsTest.prototype = {
/** @override */
isAsync: true,
/** @override */
runAccessibilityChecks: false,
/** @override */
extraLibraries: [
'//third_party/mocha/mocha.js',
......
......@@ -25,11 +25,6 @@ var MachineLearningInternalsWebUIBrowserTest = class extends testing.Test {
return true;
}
/** @override */
get runAccessibilityChecks() {
return false;
}
/** @override */
get typedefCppFixture() {
return 'MachineLearningInternalsBrowserTest';
......
......@@ -29,11 +29,6 @@ var DiscardsTest = class extends testing.Test {
get webuiHost() {
return 'discards';
}
/** @override */
get runAccessibilityChecks() {
return false;
}
};
......
......@@ -19,8 +19,6 @@ SiteEngagementBrowserTest.prototype = {
browsePreload: 'chrome://site-engagement',
runAccessibilityChecks: false,
isAsync: true,
testGenPreamble: function() {
......
......@@ -18,11 +18,6 @@ var WebUIResourceModuleAsyncTest = class extends testing.Test {
return true;
}
/** @override */
get runAccessibilityChecks() {
return false;
}
/** @override */
get webuiHost() {
return 'dummyurl';
......
......@@ -22,8 +22,6 @@ MediaEngagementWebUIBrowserTest.prototype = {
featureList: {enabled: ['media::kRecordMediaEngagementScores']},
runAccessibilityChecks: false,
isAsync: true,
testGenPreamble: function() {
......
......@@ -53,8 +53,6 @@ TEST_F(
return;
}
// #chromeos-view-import-onc fails accessibility check.
this.runAccessibilityChecks = false;
NetInternalsTest.switchToView('chromeos');
var taskQueue = new NetInternalsTest.TaskQueue(true);
......
......@@ -50,37 +50,6 @@ var NetInternalsTest = (function() {
setUp: function() {
testing.Test.prototype.setUp.call(this);
// Enforce accessibility auditing, but suppress some false positives.
this.accessibilityIssuesAreErrors = true;
// False positive because the background color highlights and then
// fades out with a transition when there's an error.
this.accessibilityAuditConfig.ignoreSelectors(
'lowContrastElements', '#hsts-view-query-output span');
// False positives for unknown reason.
this.accessibilityAuditConfig.ignoreSelectors(
'focusableElementNotVisibleAndNotAriaHidden',
'#domain-security-policy-view-tab-content *');
// TODO(aboxhall): enable when this bug is fixed:
// https://github.com/GoogleChrome/accessibility-developer-tools/issues/69
this.accessibilityAuditConfig.auditRulesToIgnore.push(
'focusableElementNotVisibleAndNotAriaHidden');
var controlsWithoutLabelSelectors = [
'#hsts-view-add-input',
'#hsts-view-delete-input',
'#hsts-view-query-input',
];
// Enable when failure is resolved.
// AX_TEXT_01: http://crbug.com/559203
this.accessibilityAuditConfig.ignoreSelectors(
'controlsWithoutLabel', controlsWithoutLabelSelectors);
// Enable when warning is resolved.
// AX_HTML_01: http://crbug.com/559204
this.accessibilityAuditConfig.ignoreSelectors('humanLangMissing', 'html');
// Wrap g_browser.receive around a test function so that assert and expect
// functions can be called from observers.
g_browser.receive = this.continueTest(
......
......@@ -30,13 +30,6 @@ PolymerTest.prototype = {
*/
isAsync: true,
/**
* Old style a11y checks are obsolete. See ../a11y/accessibility_test.js for
* the new suggested way.
* @override
*/
runAccessibilityChecks: false,
/**
* Files that need not be compiled.
* @override
......
......@@ -211,13 +211,6 @@ suite('settings-date-time-page', function() {
});
});
suiteTeardown(function() {
// TODO(michaelpg): Removes the element before exiting, because the
// <paper-tooltip> in <cr-policy-indicator> somehow causes warnings
// and/or script errors in axs_testing.js.
PolymerTest.clearBody();
});
function checkDateTimePageReadyCalled() {
if (dateTime.prefs.cros.flags.fine_grained_time_zone_detection_enabled
.value) {
......
......@@ -25,9 +25,6 @@ SettingsIdleLoadBrowserTest.prototype = {
/** @override */
isAsync: true,
/** @override */
runAccessibilityChecks: false,
};
TEST_F('SettingsIdleLoadBrowserTest', 'All', function() {
......
......@@ -17,8 +17,6 @@ SysInternalsBrowserTest.prototype = {
browsePreload: 'chrome://sys-internals',
runAccessibilityChecks: false,
isAsync: true,
extraLibraries: [
......
......@@ -20,10 +20,6 @@ var TabStripBrowserTest = class extends testing.Test {
];
}
get runAccessibilityChecks() {
return false;
}
/** @override */
get featureList() {
return {enabled: ['network::features::kOutOfBlinkCors']};
......
......@@ -180,7 +180,7 @@ Test.prototype = {
* Whether to run the accessibility checks.
* @type {boolean}
*/
runAccessibilityChecks: true,
runAccessibilityChecks: false,
/**
* Configuration for the accessibility audit.
......
......@@ -27,9 +27,6 @@ UsbInternalsTest.prototype = {
/** @override */
isAsync: true,
/** @override */
runAccessibilityChecks: false,
/** @override */
extraLibraries: [
'//third_party/mocha/mocha.js',
......
......@@ -25,9 +25,6 @@ WebUIResourceAsyncTest.prototype = {
/** @override */
isAsync: true,
/** @override */
runAccessibilityChecks: false,
/** @override */
extraLibraries: [
'//third_party/mocha/mocha.js',
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment