Commit c360b97b authored by Chris Watkins's avatar Chris Watkins Committed by Commit Bot

Run clang-tidy modernize-use-equals-{delete,default} on //printing

See the bugs and cxx post for justification and details:
https://groups.google.com/a/chromium.org/forum/#!topic/cxx/RkOHzIK6Tq8

This change was done using clang-tidy as described here:
https://chromium.googlesource.com/chromium/src/+/lkcr/docs/clang_tidy.md

In some cases the the tool leaves behind a string of commas where it
replaced a member initializer list
(https://bugs.llvm.org/show_bug.cgi?id=35051). They were cleaned up with:
  git diff --name-only | \
    xargs sed -E -i 's/(^\s*|\)\s*):[ ,]*= default/\1 = default/'

BUG=778959,778957

Change-Id: Id32fe134ba35b64c9593c46297620e84e508d1ce
Reviewed-on: https://chromium-review.googlesource.com/789727Reviewed-by: default avatarRebekah Potter <rbpotter@chromium.org>
Commit-Queue: Chris Watkins <watk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#520864}
parent 788cf2d1
...@@ -19,7 +19,7 @@ PrinterBasicInfo::PrinterBasicInfo() ...@@ -19,7 +19,7 @@ PrinterBasicInfo::PrinterBasicInfo()
PrinterBasicInfo::PrinterBasicInfo(const PrinterBasicInfo& other) = default; PrinterBasicInfo::PrinterBasicInfo(const PrinterBasicInfo& other) = default;
PrinterBasicInfo::~PrinterBasicInfo() {} PrinterBasicInfo::~PrinterBasicInfo() = default;
PrinterSemanticCapsAndDefaults::PrinterSemanticCapsAndDefaults() PrinterSemanticCapsAndDefaults::PrinterSemanticCapsAndDefaults()
: collate_capable(false), : collate_capable(false),
...@@ -36,16 +36,16 @@ PrinterSemanticCapsAndDefaults::PrinterSemanticCapsAndDefaults() ...@@ -36,16 +36,16 @@ PrinterSemanticCapsAndDefaults::PrinterSemanticCapsAndDefaults()
PrinterSemanticCapsAndDefaults::PrinterSemanticCapsAndDefaults( PrinterSemanticCapsAndDefaults::PrinterSemanticCapsAndDefaults(
const PrinterSemanticCapsAndDefaults& other) = default; const PrinterSemanticCapsAndDefaults& other) = default;
PrinterSemanticCapsAndDefaults::~PrinterSemanticCapsAndDefaults() {} PrinterSemanticCapsAndDefaults::~PrinterSemanticCapsAndDefaults() = default;
PrinterCapsAndDefaults::PrinterCapsAndDefaults() {} PrinterCapsAndDefaults::PrinterCapsAndDefaults() = default;
PrinterCapsAndDefaults::PrinterCapsAndDefaults( PrinterCapsAndDefaults::PrinterCapsAndDefaults(
const PrinterCapsAndDefaults& other) = default; const PrinterCapsAndDefaults& other) = default;
PrinterCapsAndDefaults::~PrinterCapsAndDefaults() {} PrinterCapsAndDefaults::~PrinterCapsAndDefaults() = default;
PrintBackend::~PrintBackend() {} PrintBackend::~PrintBackend() = default;
// static // static
scoped_refptr<PrintBackend> PrintBackend::CreateInstance( scoped_refptr<PrintBackend> PrintBackend::CreateInstance(
......
...@@ -60,10 +60,10 @@ class PrintBackendChromeOS : public PrintBackend { ...@@ -60,10 +60,10 @@ class PrintBackendChromeOS : public PrintBackend {
bool IsValidPrinter(const std::string& printer_name) override; bool IsValidPrinter(const std::string& printer_name) override;
protected: protected:
~PrintBackendChromeOS() override {} ~PrintBackendChromeOS() override = default;
}; };
PrintBackendChromeOS::PrintBackendChromeOS() {} PrintBackendChromeOS::PrintBackendChromeOS() = default;
bool PrintBackendChromeOS::EnumeratePrinters(PrinterList* printer_list) { bool PrintBackendChromeOS::EnumeratePrinters(PrinterList* printer_list) {
return true; return true;
......
...@@ -12,9 +12,9 @@ ...@@ -12,9 +12,9 @@
namespace printing { namespace printing {
TestPrintBackend::TestPrintBackend() {} TestPrintBackend::TestPrintBackend() = default;
TestPrintBackend::~TestPrintBackend() {} TestPrintBackend::~TestPrintBackend() = default;
bool TestPrintBackend::EnumeratePrinters(PrinterList* printer_list) { bool TestPrintBackend::EnumeratePrinters(PrinterList* printer_list) {
if (printer_list_.empty()) if (printer_list_.empty())
......
...@@ -24,14 +24,9 @@ Image::Image(const Metafile& metafile) ...@@ -24,14 +24,9 @@ Image::Image(const Metafile& metafile)
LoadMetafile(metafile); LoadMetafile(metafile);
} }
Image::Image(const Image& image) Image::Image(const Image& image) = default;
: size_(image.size_),
row_length_(image.row_length_),
data_(image.data_),
ignore_alpha_(image.ignore_alpha_) {
}
Image::~Image() {} Image::~Image() = default;
std::string Image::checksum() const { std::string Image::checksum() const {
base::MD5Digest digest; base::MD5Digest digest;
......
...@@ -13,17 +13,13 @@ ...@@ -13,17 +13,13 @@
namespace printing { namespace printing {
MetafilePlayer::MetafilePlayer() { MetafilePlayer::MetafilePlayer() = default;
}
MetafilePlayer::~MetafilePlayer() { MetafilePlayer::~MetafilePlayer() = default;
}
Metafile::Metafile() { Metafile::Metafile() = default;
}
Metafile::~Metafile() { Metafile::~Metafile() = default;
}
bool Metafile::GetDataAsVector(std::vector<char>* buffer) const { bool Metafile::GetDataAsVector(std::vector<char>* buffer) const {
buffer->resize(GetDataSize()); buffer->resize(GetDataSize());
......
...@@ -43,7 +43,7 @@ PageSetup::PageSetup() { ...@@ -43,7 +43,7 @@ PageSetup::PageSetup() {
PageSetup::PageSetup(const PageSetup& other) = default; PageSetup::PageSetup(const PageSetup& other) = default;
PageSetup::~PageSetup() {} PageSetup::~PageSetup() = default;
void PageSetup::Clear() { void PageSetup::Clear() {
physical_size_.SetSize(0, 0); physical_size_.SetSize(0, 0);
......
...@@ -80,7 +80,7 @@ struct PdfMetafileSkiaData { ...@@ -80,7 +80,7 @@ struct PdfMetafileSkiaData {
#endif #endif
}; };
PdfMetafileSkia::~PdfMetafileSkia() {} PdfMetafileSkia::~PdfMetafileSkia() = default;
bool PdfMetafileSkia::Init() { bool PdfMetafileSkia::Init() {
return true; return true;
......
...@@ -154,8 +154,7 @@ PrintSettings::PrintSettings() { ...@@ -154,8 +154,7 @@ PrintSettings::PrintSettings() {
PrintSettings::PrintSettings(const PrintSettings& other) = default; PrintSettings::PrintSettings(const PrintSettings& other) = default;
PrintSettings::~PrintSettings() { PrintSettings::~PrintSettings() = default;
}
void PrintSettings::Clear() { void PrintSettings::Clear() {
ranges_.clear(); ranges_.clear();
......
...@@ -111,8 +111,7 @@ PrintedDocument::PrintedDocument(const PrintSettings& settings, ...@@ -111,8 +111,7 @@ PrintedDocument::PrintedDocument(const PrintSettings& settings,
DebugDumpSettings(name, settings); DebugDumpSettings(name, settings);
} }
PrintedDocument::~PrintedDocument() { PrintedDocument::~PrintedDocument() = default;
}
void PrintedDocument::SetPage(int page_number, void PrintedDocument::SetPage(int page_number,
std::unique_ptr<MetafilePlayer> metafile, std::unique_ptr<MetafilePlayer> metafile,
...@@ -239,16 +238,16 @@ void PrintedDocument::DebugDumpData( ...@@ -239,16 +238,16 @@ void PrintedDocument::DebugDumpData(
base::RetainedRef(data))); base::RetainedRef(data)));
} }
PrintedDocument::Mutable::Mutable() {} PrintedDocument::Mutable::Mutable() = default;
PrintedDocument::Mutable::~Mutable() {} PrintedDocument::Mutable::~Mutable() = default;
PrintedDocument::Immutable::Immutable(const PrintSettings& settings, PrintedDocument::Immutable::Immutable(const PrintSettings& settings,
const base::string16& name, const base::string16& name,
int cookie) int cookie)
: settings_(settings), name_(name), cookie_(cookie) {} : settings_(settings), name_(name), cookie_(cookie) {}
PrintedDocument::Immutable::~Immutable() {} PrintedDocument::Immutable::~Immutable() = default;
#if defined(OS_ANDROID) #if defined(OS_ANDROID)
// This function is not used on android. // This function is not used on android.
......
...@@ -21,8 +21,7 @@ PrintedPage::PrintedPage(int page_number, ...@@ -21,8 +21,7 @@ PrintedPage::PrintedPage(int page_number,
page_content_rect_(page_content_rect) { page_content_rect_(page_content_rect) {
} }
PrintedPage::~PrintedPage() { PrintedPage::~PrintedPage() = default;
}
const MetafilePlayer* PrintedPage::metafile() const { const MetafilePlayer* PrintedPage::metafile() const {
return metafile_.get(); return metafile_.get();
......
...@@ -26,8 +26,7 @@ PrintingContext::PrintingContext(Delegate* delegate) ...@@ -26,8 +26,7 @@ PrintingContext::PrintingContext(Delegate* delegate)
DCHECK(delegate_); DCHECK(delegate_);
} }
PrintingContext::~PrintingContext() { PrintingContext::~PrintingContext() = default;
}
void PrintingContext::set_margin_type(MarginType type) { void PrintingContext::set_margin_type(MarginType type) {
DCHECK(type != CUSTOM_MARGINS); DCHECK(type != CUSTOM_MARGINS);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment