Commit c362a595 authored by Dirk Pranke's avatar Dirk Pranke Committed by Commit Bot

Roll GN from e327ffdc..6f13aaac and update BUILD files.

This CL was initially generated by //tools/gn/roll_gn.py and
picks up the following changes:

https://gn.googlesource.com/gn/+log/e327ffdc..6f13aaac

    6f13aaac [visibility] Consider configs in visibility check
    5da62d5e Fix native MinGW build
    0649bd9a Add MSYS as a platform.
    501b49a3 clang: Add support for C++ modules in deps
    03df22eb [rust-project] Add "proc_macro" as dep for proc macro targets
    b489f906 Add support for Solaris and illumos systems

6f13aac is a breaking change, in that it addresses gn bug #22,
where `visibility` was not actually enforced on configs (it was
enforced only on targets); as a result, we have some visibility
violations that are now picked up with the new GN binary.

This CL fixes those violations.

Change-Id: I52b6e01f31ce64c1926e97b699b7f8a399dbf9f5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2360685
Commit-Queue: Dirk Pranke <dpranke@google.com>
Reviewed-by: default avatarNico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#800616}
parent d43ed2e9
......@@ -368,7 +368,7 @@ vars = {
# revisions.
# GN CIPD package version.
'gn_version': 'git_revision:e327ffdc503815916db2543ec000226a8df45163',
'gn_version': 'git_revision:6f13aaac55a977e1948910942675c69f2b4f7a94',
# Also, if you change these, update buildtools/DEPS too. Also update the
# libc++ svn_revision in //buildtools/deps_revisions.gni.
......
......@@ -1256,6 +1256,11 @@ template("ios_framework_bundle") {
_default_toolchain_root_out_dir =
get_label_info("$_target_name($default_toolchain)", "root_out_dir")
_arch_shared_library_source = _target_name + "_arch_shared_library_sources"
_arch_shared_library_target = _target_name + "_arch_shared_library"
_lipo_shared_library_target = _target_name + "_shared_library"
_link_target_name = _target_name + "+link"
if (_has_public_headers) {
_default_toolchain_target_gen_dir =
get_label_info("$_target_name($default_toolchain)", "target_gen_dir")
......@@ -1266,7 +1271,10 @@ template("ios_framework_bundle") {
_header_map_filename =
"$_default_toolchain_target_gen_dir/$_output_name.headers.hmap"
config(_headers_map_config) {
visibility = [ ":${_target_name}_signed_bundle" ]
visibility = [
":${_target_name}_signed_bundle",
":${_arch_shared_library_source}",
]
include_dirs = [ _header_map_filename ]
}
}
......@@ -1276,11 +1284,6 @@ template("ios_framework_bundle") {
framework_dirs = [ _default_toolchain_root_out_dir ]
}
_arch_shared_library_source = _target_name + "_arch_shared_library_sources"
_arch_shared_library_target = _target_name + "_arch_shared_library"
_lipo_shared_library_target = _target_name + "_shared_library"
_link_target_name = _target_name + "+link"
_framework_public_config = _target_name + "_public_config"
config(_framework_public_config) {
configs = [ ":$_framework_headers_config" ]
......
......@@ -14,7 +14,7 @@ vars = {
#
# GN CIPD package version.
'gn_version': 'git_revision:e327ffdc503815916db2543ec000226a8df45163',
'gn_version': 'git_revision:6f13aaac55a977e1948910942675c69f2b4f7a94',
# When changing these, also update the svn revisions in deps_revisions.gni
'clang_format_revision': '96636aa0e9f047f17447f2d45a094d0b59ed7917',
......
......@@ -122,6 +122,8 @@ group("make_platform_generated") {
import("//build/config/pch.gni")
config("blink_platform_config") {
visibility = []
visibility = [ "./*" ]
configs = [
"//third_party/blink/renderer:config",
"//third_party/blink/renderer:inside_blink",
......@@ -199,10 +201,15 @@ buildflag_header("bindings_buildflags") {
}
config("blink_platform_implementation") {
visibility = []
visibility = [ "./*" ]
defines = [ "BLINK_PLATFORM_IMPLEMENTATION=1" ]
}
config("blink_platform_pch") {
visibility = []
visibility = [ "./*" ]
if (enable_precompiled_headers) {
if (is_win) {
# This is a string rather than a file GN knows about. It has to match
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment