Commit c37469ac authored by dbeam@chromium.org's avatar dbeam@chromium.org

history: fix a11y issue by making checkboxes always visible.

this change:
- changes border-color instead of opacity of checkboxes on hover
- makes checked and hovered checkboxes look more similar
- makes hovered rows more noticeable

And I touched a few more things that weren't really noticeable
before I changed the background color:
- checkbox vertical alignment
- added padding in front of checkboxes

BUG=351565
R=dmazzoni@chromium.org
TEST=visible checkboxes

Review URL: https://codereview.chromium.org/293303002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272735 0039d316-1c4b-4281-b951-d872f2087c98
parent 1e76420f
......@@ -347,28 +347,18 @@ html[dir='rtl'] .site-domain {
.entry input[type='checkbox'] {
-webkit-margin-end: 6px;
line-height: 1em;
margin-top: 2px;
min-width: 13px;
top: 0;
}
<if expr="not is_android">
/* Checkboxes are shown when checked or focused, or when the entry is hovered.
* Fade in on focus, but not on hover, because it makes the UI feel laggy. */
.site-domain-wrapper input[type=checkbox]:not(:checked),
.entry input[type='checkbox']:not(:checked) {
opacity: 0;
}
.site-domain-wrapper:hover input[type='checkbox'],
.site-domain-wrapper input[type='checkbox']:checked,
.site-domain-wrapper input[type='checkbox']:focus,
.entry-box:hover input[type='checkbox'],
.entry-box input[type='checkbox']:checked,
.entry-box input[type='checkbox']:focus {
opacity: 1;
}
.site-domain-wrapper input[type='checkbox']:focus,
.entry-box input[type='checkbox']:focus {
-webkit-transition: opacity 150ms;
border-color: rgba(0, 0, 0, .5);
}
.filter-status {
......@@ -428,13 +418,13 @@ html[dir='rtl'] .site-domain {
</if>
.entry-box {
background-color: none;
-webkit-padding-start: 6px;
border-radius: 2px;
}
.entry-box:hover,
.entry-box.contains-focus {
background-color: rgb(252, 252, 252);
border-radius: 2px;
background-color: rgba(0, 0, 0, .05);
}
.entry-box-container {
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment