Commit c39dfb96 authored by Jordy Greenblatt's avatar Jordy Greenblatt Committed by Commit Bot

Revert "[CrOS Settings]: Fix RTL bug caused by CSS 'absolute' position"

This reverts commit c731a337.

Reason for revert: Fix caused new aesthetic issue http://crbug.com/973810

Original change's description:
> [CrOS Settings]: Fix RTL bug caused by CSS 'absolute' position
>
> The cameraVideo was positioned absolutely and therefore wasn't
> contained in the cr-picture-pane in RTL languages and could not be
> viewed.
>
> Testing:
>
> Note: I switched the language to Hebrew because the behavior was the
> same but I can read some Hebrew so it was easier to navigate.
>
> Before in RTL:
> https://screenshot.googleplex.com/tx9TUixsmhg
>
> After in RTL:
> https://screenshot.googleplex.com/aAax330vziE
>
> Also, the change did not affect the behavior to in LTR languages, as
> seen in this English language screenshot from after the change:
> https://screenshot.googleplex.com/oMA5JjvDGer
>
>
> Bug: 935341
> Change-Id: Ia9167e398ff7121fea7eb07ff90671ac4b4ae4b0
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1652206
> Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
> Commit-Queue: Jordy Greenblatt <jordynass@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#667778}

TBR=stevenjb@chromium.org,maybelle@chromium.org,jordynass@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 935341
Change-Id: Iae610493b7d3aa3fdc637b3e703e58b1656f1ae4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1659530
Commit-Queue: Jordy Greenblatt <jordynass@chromium.org>
Reviewed-by: default avatarMay Lippert <maybelle@chromium.org>
Reviewed-by: default avatarJordy Greenblatt <jordynass@chromium.org>
Cr-Commit-Position: refs/heads/master@{#669020}
parent 79ab9a76
......@@ -85,6 +85,7 @@
height: var(--cr-camera-image-size, 228px);
object-fit: cover;
object-position: center;
position: absolute;
width: var(--cr-camera-image-size, 228px);
}
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment