Small crash fix for set pages dialog drag'n'drop issue.

R=thakis@chromium.org
BUG=302284

Review URL: https://codereview.chromium.org/52823006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@232971 0039d316-1c4b-4281-b951-d872f2087c98

chrome/browser/custom_home_pages_table_model.cc

@@ -96,7 +96,7 @@ void CustomHomePagesTableModel::SetURLs(const std::vector<GURL>& urls) {
  */
 void CustomHomePagesTableModel::MoveURLs(int insert_before,
                                          const std::vector<int>& index_list) {
-  DCHECK(!index_list.empty());
+  if (index_list.empty()) return;
   DCHECK(insert_before >= 0 && insert_before <= RowCount());
 
   // The range of elements that needs to be reshuffled is [ |first|, |last| ).

chrome/browser/ui/webui/options/options_browsertest.js

@@ -271,6 +271,12 @@ TEST_F('OptionsWebUITest', 'EnterPreventsDefault', function() {
   testDone();
 });
 
+// Verifies that sending an empty list of indexes to move doesn't crash chrome.
+TEST_F('OptionsWebUITest', 'emptySelectedIndexesDoesntCrash', function() {
+  chrome.send('dragDropStartupPage', [0, []]);
+  setTimeout(testDone);
+});
+
 /**
  * TestFixture for OptionsPage WebUI testing including tab history and support
  * for preference manipulation.