Commit c3c2850e authored by Jun Mukai's avatar Jun Mukai Committed by Commit Bot

Run SchedulePaint for v1 app frames on enter/exit overview-mode

The v1 app frames change its visibility on overview mode, therefore
the SchedulePaint() should be called. Normal browser windows
don't have to.

Bug: 949227, 951405
Test: manually
Change-Id: If448b1d0eb016dfad2522545e3e62f102ed1f9da
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1562073Reviewed-by: default avatarMitsuru Oshima <oshima@chromium.org>
Reviewed-by: default avatarScott Violet <sky@chromium.org>
Commit-Queue: Jun Mukai <mukai@chromium.org>
Cr-Commit-Position: refs/heads/master@{#649686}
parent 24fd92ce
......@@ -763,6 +763,14 @@ void BrowserNonClientFrameViewAsh::OnOverviewOrSplitviewModeChanged() {
caption_button_container_->SetVisible(should_show_caption_buttons);
if (hosted_app_button_container())
hosted_app_button_container()->SetVisible(should_show_caption_buttons);
// The entire frame should be repainted for v1 apps, since its visibility can
// change (see also ShouldPaint()). Do not invoke this on normal browser
// windows since it does not have to repaint frame except for the caption
// buttons and repainting might cause stuttering of the animation. See
// https://crbug.com/949227.
if (!browser_view()->IsBrowserTypeNormal())
SchedulePaint();
}
std::unique_ptr<ash::FrameHeader>
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment