Commit c3c31de6 authored by Rachel Carpenter's avatar Rachel Carpenter Committed by Commit Bot

Record metric if we are opening help app from Release Notes chip.

It would be good to be consistent in the logging of our release notes
entry points for now as we have an experiment running on this as well as
the swap from PWA to help app in M86. Will clean up to have better
logging of the various pages HelpApp can be opened to/from at a later
date.

Bug: b/165421480
Change-Id: Ia6a128aaeed139694f39421abb9ebe1f86c30827
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2362240Reviewed-by: default avatarNancy Wang <nancylingwang@chromium.org>
Commit-Queue: Rachel Carpenter <carpenterr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#799816}
parent 99a1deab
......@@ -8,6 +8,7 @@
#include "ash/public/cpp/app_list/app_list_types.h"
#include "ash/public/cpp/app_list/internal_app_id_constants.h"
#include "base/bind.h"
#include "base/metrics/user_metrics.h"
#include "chrome/browser/apps/app_service/app_service_metrics.h"
#include "chrome/browser/apps/app_service/app_service_proxy.h"
#include "chrome/browser/apps/app_service/app_service_proxy_factory.h"
......@@ -161,6 +162,12 @@ void AppServiceAppResult::Launch(int event_flags,
if (id() == chromeos::default_web_apps::kHelpAppId &&
query_url().has_value()) {
// This matches the logging of the release notes app in
// chrome/browser/apps/app_service/built_in_chromeos_apps.cc.
// TODO(carpenterr): Have more consistent logging of the places Help App can
// be opened to/from.
base::RecordAction(
base::UserMetricsAction("ReleaseNotes.SuggestionChipLaunched"));
proxy->LaunchAppWithUrl(app_id(), event_flags, query_url().value(),
launch_source, controller()->GetAppListDisplayId());
return;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment