Commit c3d7ccc5 authored by ssid's avatar ssid Committed by Commit Bot

Memory-infra: Enable graph computation by default

Perfetto JSON exporter will only be able to write processed graphs in
legacy format. So, enable graph computation by default to verify other
consumers can handle this format.

Change-Id: Id39814653767acfff27d8c4dd939b69ba116f864
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2552820Reviewed-by: default avatarEric Seckler <eseckler@chromium.org>
Commit-Queue: ssid <ssid@chromium.org>
Cr-Commit-Position: refs/heads/master@{#830179}
parent 20c1e0cf
...@@ -619,7 +619,7 @@ bool QueuedRequestDispatcher::AddChromeMemoryDumpToTrace( ...@@ -619,7 +619,7 @@ bool QueuedRequestDispatcher::AddChromeMemoryDumpToTrace(
const base::TimeTicks& timestamp) { const base::TimeTicks& timestamp) {
bool is_chrome_tracing_enabled = bool is_chrome_tracing_enabled =
base::CommandLine::ForCurrentProcess()->HasSwitch( base::CommandLine::ForCurrentProcess()->HasSwitch(
switches::kEnableChromeTracingComputation); switches::kDisableChromeTracingComputation);
if (!is_chrome_tracing_enabled) { if (!is_chrome_tracing_enabled) {
return tracing_observer->AddChromeDumpToTraceIfEnabled( return tracing_observer->AddChromeDumpToTraceIfEnabled(
args, pid, &raw_chrome_dump, timestamp); args, pid, &raw_chrome_dump, timestamp);
......
...@@ -7,9 +7,9 @@ ...@@ -7,9 +7,9 @@
namespace memory_instrumentation { namespace memory_instrumentation {
namespace switches { namespace switches {
// Enable the tracing service. // Disable the tracing service graph compuation while writing the trace.
const char kEnableChromeTracingComputation[] = const char kDisableChromeTracingComputation[] =
"enable-chrome-tracing-computation"; "disable-chrome-tracing-computation";
const char kUseMemoryTrackingProtoWriter[] = "use-memory-tracking-proto-writer"; const char kUseMemoryTrackingProtoWriter[] = "use-memory-tracking-proto-writer";
} // namespace switches } // namespace switches
......
...@@ -10,7 +10,7 @@ namespace switches { ...@@ -10,7 +10,7 @@ namespace switches {
// All switches in alphabetical order. The switches should be documented // All switches in alphabetical order. The switches should be documented
// alongside the definition of their values in the .cc file. // alongside the definition of their values in the .cc file.
extern const char kEnableChromeTracingComputation[]; extern const char kDisableChromeTracingComputation[];
extern const char kUseMemoryTrackingProtoWriter[]; extern const char kUseMemoryTrackingProtoWriter[];
} // namespace switches } // namespace switches
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment