Commit c3f1916e authored by Zinovy Nis's avatar Zinovy Nis Committed by Commit Bot

[clang-tidy] Fix possible use after move

Minor fixes.

Bug: None
Change-Id: I2270516c27757bceb0e6b3e838ce2004f1d137eb
Reviewed-on: https://chromium-review.googlesource.com/c/1356985Reviewed-by: default avatarDmitry Gozman <dgozman@chromium.org>
Commit-Queue: Dmitry Gozman <dgozman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#615971}
parent 4f9376f2
...@@ -324,7 +324,7 @@ class DevToolsAgentHostClientImpl : public DevToolsAgentHostClient { ...@@ -324,7 +324,7 @@ class DevToolsAgentHostClientImpl : public DevToolsAgentHostClient {
~DevToolsAgentHostClientImpl() override { ~DevToolsAgentHostClientImpl() override {
DCHECK_CURRENTLY_ON(BrowserThread::UI); DCHECK_CURRENTLY_ON(BrowserThread::UI);
if (agent_host_.get()) if (agent_host_)
agent_host_->DetachClient(this); agent_host_->DetachClient(this);
} }
...@@ -356,7 +356,7 @@ class DevToolsAgentHostClientImpl : public DevToolsAgentHostClient { ...@@ -356,7 +356,7 @@ class DevToolsAgentHostClientImpl : public DevToolsAgentHostClient {
void OnMessage(const std::string& message) { void OnMessage(const std::string& message) {
DCHECK_CURRENTLY_ON(BrowserThread::UI); DCHECK_CURRENTLY_ON(BrowserThread::UI);
if (agent_host_.get()) if (agent_host_)
agent_host_->DispatchProtocolMessage(this, message); agent_host_->DispatchProtocolMessage(this, message);
} }
...@@ -384,7 +384,7 @@ DevToolsHttpHandler::~DevToolsHttpHandler() { ...@@ -384,7 +384,7 @@ DevToolsHttpHandler::~DevToolsHttpHandler() {
} }
static std::string PathWithoutParams(const std::string& path) { static std::string PathWithoutParams(const std::string& path) {
size_t query_position = path.find("?"); size_t query_position = path.find('?');
if (query_position != std::string::npos) if (query_position != std::string::npos)
return path.substr(0, query_position); return path.substr(0, query_position);
return path; return path;
...@@ -547,13 +547,13 @@ void DevToolsHttpHandler::OnJsonRequest( ...@@ -547,13 +547,13 @@ void DevToolsHttpHandler::OnJsonRequest(
// Trim fragment and query // Trim fragment and query
std::string query; std::string query;
size_t query_pos = path.find("?"); size_t query_pos = path.find('?');
if (query_pos != std::string::npos) { if (query_pos != std::string::npos) {
query = path.substr(query_pos + 1); query = path.substr(query_pos + 1);
path = path.substr(0, query_pos); path = path.substr(0, query_pos);
} }
size_t fragment_pos = path.find("#"); size_t fragment_pos = path.find('#');
if (fragment_pos != std::string::npos) if (fragment_pos != std::string::npos)
path = path.substr(0, fragment_pos); path = path.substr(0, fragment_pos);
...@@ -652,7 +652,6 @@ void DevToolsHttpHandler::OnJsonRequest( ...@@ -652,7 +652,6 @@ void DevToolsHttpHandler::OnJsonRequest(
} }
SendJson(connection_id, net::HTTP_NOT_FOUND, nullptr, SendJson(connection_id, net::HTTP_NOT_FOUND, nullptr,
"Unknown command: " + command); "Unknown command: " + command);
return;
} }
void DevToolsHttpHandler::DecompressAndSendJsonProtocol(int connection_id) { void DevToolsHttpHandler::DecompressAndSendJsonProtocol(int connection_id) {
...@@ -791,7 +790,8 @@ DevToolsHttpHandler::DevToolsHttpHandler( ...@@ -791,7 +790,8 @@ DevToolsHttpHandler::DevToolsHttpHandler(
base::Thread::Options options; base::Thread::Options options;
options.message_loop_type = base::MessageLoop::TYPE_IO; options.message_loop_type = base::MessageLoop::TYPE_IO;
if (thread->StartWithOptions(options)) { if (thread->StartWithOptions(options)) {
thread->task_runner()->PostTask( auto task_runner = thread->task_runner();
task_runner->PostTask(
FROM_HERE, FROM_HERE,
base::BindOnce(&StartServerOnHandlerThread, weak_factory_.GetWeakPtr(), base::BindOnce(&StartServerOnHandlerThread, weak_factory_.GetWeakPtr(),
std::move(thread), std::move(socket_factory), std::move(thread), std::move(socket_factory),
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment