Closure compile file_list_model_unittest

Bug: 905930 Change-Id: Ice0fb6efbfdaa7f52463cb9876d50b85b9900989 Reviewed-on: https://chromium-review.googlesource.com/c/1341298Reviewed-by: Stuart Langley <slangley@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#609187}

Closure compile file_list_model_unittest
Bug: 905930 Change-Id: Ice0fb6efbfdaa7f52463cb9876d50b85b9900989 Reviewed-on: https://chromium-review.googlesource.com/c/1341298Reviewed-by: Stuart Langley <slangley@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#609187}
c4875d3e · Noel Gordon · Commit Bot · e18ec17c · c4875d3e · c4875d3e
Commit c4875d3e authored Nov 19, 2018 by Noel Gordon Committed by Commit Bot Nov 19, 2018
4 changed files
--- a/chrome/browser/chromeos/file_manager/file_manager_jstest.cc
+++ b/chrome/browser/chromeos/file_manager/file_manager_jstest.cc
@@ -193,8 +193,7 @@ IN_PROC_BROWSER_TEST_F(FileManagerJsTest, SpinnerController) {
 }

 IN_PROC_BROWSER_TEST_F(FileManagerJsTest, FileListModel) {
-  RunTest(base::FilePath(
-      FILE_PATH_LITERAL("foreground/js/file_list_model_unittest.html")));
+  RunGeneratedTest("/foreground/js/file_list_model_unittest.html");
 }

 IN_PROC_BROWSER_TEST_F(FileManagerJsTest, FileTapHandler) {

--- a/ui/file_manager/file_manager/foreground/js/BUILD.gn
+++ b/ui/file_manager/file_manager/foreground/js/BUILD.gn
@@ -286,6 +286,13 @@ js_library("file_list_model") {
  ]
 }

+js_unittest("file_list_model_unittest") {
+  deps = [
+    ":file_list_model",
+    "//ui/webui/resources/js:webui_resource_test",
+  ]
+}
+
 js_library("file_manager") {
  deps = [
    ":app_state_controller",
@@ -666,6 +673,7 @@ js_library("webui_command_extender") {

 js_unit_tests("unit_tests") {
  deps = [
+    ":file_list_model_unittest",
    ":thumbnail_loader_unittest",
  ]
 }
--- a/ui/file_manager/file_manager/foreground/js/file_list_model_unittest.html
+++ b/ui/file_manager/file_manager/foreground/js/file_list_model_unittest.html
-<!DOCTYPE html>
-<!-- Copyright 2016 The Chromium Authors. All rights reserved.
-  -- Use of this source code is governed by a BSD-style license that can be
-  -- found in the LICENSE file.
-  -->
-
-<script src="../../../../../ui/webui/resources/js/cr.js"></script>
-<script src="../../../../../ui/webui/resources/js/cr/ui.js"></script>
-<script src="../../../../../ui/webui/resources/js/cr/event_target.js"></script>
-<script src="../../../../../ui/webui/resources/js/cr/ui/array_data_model.js"></script>
-<script src="../../../../../ui/webui/resources/js/webui_resource_test.js"></script>
-<script src="../../common/js/util.js"></script>
-<script src="../../common/js/file_type.js"></script>
-<script src="file_list_model.js"></script>
-
-<script src="file_list_model_unittest.js"></script>
--- a/ui/file_manager/file_manager/foreground/js/file_list_model_unittest.js
+++ b/ui/file_manager/file_manager/foreground/js/file_list_model_unittest.js
@@ -39,9 +39,15 @@ function makeSimpleFileListModel(names) {
  return fileListModel;
 }

-// MetadataModel for this test.
-// It is supposed to provide metadata from TEST_METADATA to work with the
-// FileListModel.
+/**
+ * MetadataModel for this test.
+ * It is supposed to provide metadata from TEST_METADATA to work with the
+ * FileListModel.
+ *
+ * @constructor
+ * @extends {MetadataModel}
+ * @param {Object} testdata
+ */
 function TestMetadataModel(testdata) {
  this.testdata_ = testdata;
 }