Commit c4c45dde authored by Dave Tapuska's avatar Dave Tapuska Committed by Commit Bot

Fix crash in plugins setting tooltip text.

In order to bind a local associated interface you need to use the testing
API. While the API is poorly named due to mojo team previously did agree
that the ForTesting suffix should be removed for cases such as these.

BUG=1084849,1085031,1082648
TBR=tommycli@chromium.org

Change-Id: I2413fcc8633cd3db75f3c4eefcff763b29ca714c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2210488Reviewed-by: default avatarDave Tapuska <dtapuska@chromium.org>
Commit-Queue: Dave Tapuska <dtapuska@chromium.org>
Cr-Commit-Position: refs/heads/master@{#770817}
parent 445a9972
...@@ -277,8 +277,11 @@ WebViewPlugin::WebViewHelper::WebViewHelper(WebViewPlugin* plugin, ...@@ -277,8 +277,11 @@ WebViewPlugin::WebViewHelper::WebViewHelper(WebViewPlugin* plugin,
blink::mojom::FrameWidgetHostInterfaceBase>(), blink::mojom::FrameWidgetHostInterfaceBase>(),
blink::CrossVariantMojoAssociatedReceiver< blink::CrossVariantMojoAssociatedReceiver<
blink::mojom::FrameWidgetInterfaceBase>(), blink::mojom::FrameWidgetInterfaceBase>(),
blink_widget_host_receiver_.BindNewEndpointAndPassRemote(), // TODO(dtapuska): https://crbug.com/1085031. Have the suffix ForTesting
blink_widget_.BindNewEndpointAndPassReceiver()); // removed.
blink_widget_host_receiver_
.BindNewEndpointAndPassDedicatedRemoteForTesting(),
blink_widget_.BindNewEndpointAndPassDedicatedReceiverForTesting());
// The WebFrame created here was already attached to the Page as its // The WebFrame created here was already attached to the Page as its
// main frame, and the WebFrameWidget has been initialized, so we can call // main frame, and the WebFrameWidget has been initialized, so we can call
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment