Commit c4d26bf4 authored by Sahel Sharify's avatar Sahel Sharify Committed by Commit Bot

Remove NON_BUBBLING_GESTURE ScrollInputType

This cl removes the NON_BUBBLING_GESTURE from ScrollInputType since it
is only used in layer_tree_host_impl_unittest.cc.

On a follow up cl, I am gonna add AUTOSCROLL to the ScrollInputType.

Bug: 845960
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I5c63225416e41a3a7586ac7a710fe9b472b53a10
Reviewed-on: https://chromium-review.googlesource.com/1070432
Commit-Queue: David Bokan <bokan@chromium.org>
Reviewed-by: default avatarDavid Bokan <bokan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561734}
parent 010ddcfd
...@@ -113,7 +113,6 @@ class CC_EXPORT InputHandler { ...@@ -113,7 +113,6 @@ class CC_EXPORT InputHandler {
enum ScrollInputType { enum ScrollInputType {
TOUCHSCREEN, TOUCHSCREEN,
WHEEL, WHEEL,
NON_BUBBLING_GESTURE
}; };
enum class TouchStartOrMoveEventListenerType { enum class TouchStartOrMoveEventListenerType {
......
...@@ -6785,7 +6785,7 @@ TEST_F(LayerTreeHostImplTest, ScrollWithoutBubbling) { ...@@ -6785,7 +6785,7 @@ TEST_F(LayerTreeHostImplTest, ScrollWithoutBubbling) {
EXPECT_EQ(InputHandler::SCROLL_ON_IMPL_THREAD, EXPECT_EQ(InputHandler::SCROLL_ON_IMPL_THREAD,
host_impl_ host_impl_
->ScrollBegin(BeginState(gfx::Point()).get(), ->ScrollBegin(BeginState(gfx::Point()).get(),
InputHandler::NON_BUBBLING_GESTURE) InputHandler::TOUCHSCREEN)
.thread); .thread);
host_impl_->ScrollBy(UpdateState(gfx::Point(), scroll_delta).get()); host_impl_->ScrollBy(UpdateState(gfx::Point(), scroll_delta).get());
host_impl_->ScrollEnd(EndState().get()); host_impl_->ScrollEnd(EndState().get());
...@@ -6814,7 +6814,7 @@ TEST_F(LayerTreeHostImplTest, ScrollWithoutBubbling) { ...@@ -6814,7 +6814,7 @@ TEST_F(LayerTreeHostImplTest, ScrollWithoutBubbling) {
EXPECT_EQ(InputHandler::SCROLL_ON_IMPL_THREAD, EXPECT_EQ(InputHandler::SCROLL_ON_IMPL_THREAD,
host_impl_ host_impl_
->ScrollBegin(BeginState(gfx::Point(5, 5)).get(), ->ScrollBegin(BeginState(gfx::Point(5, 5)).get(),
InputHandler::NON_BUBBLING_GESTURE) InputHandler::TOUCHSCREEN)
.thread); .thread);
EXPECT_EQ(host_impl_->CurrentlyScrollingNode()->id, EXPECT_EQ(host_impl_->CurrentlyScrollingNode()->id,
grand_child->scroll_tree_index()); grand_child->scroll_tree_index());
...@@ -6839,7 +6839,7 @@ TEST_F(LayerTreeHostImplTest, ScrollWithoutBubbling) { ...@@ -6839,7 +6839,7 @@ TEST_F(LayerTreeHostImplTest, ScrollWithoutBubbling) {
EXPECT_EQ(InputHandler::SCROLL_ON_IMPL_THREAD, EXPECT_EQ(InputHandler::SCROLL_ON_IMPL_THREAD,
host_impl_ host_impl_
->ScrollBegin(BeginState(gfx::Point(5, 5)).get(), ->ScrollBegin(BeginState(gfx::Point(5, 5)).get(),
InputHandler::NON_BUBBLING_GESTURE) InputHandler::TOUCHSCREEN)
.thread); .thread);
EXPECT_EQ(host_impl_->CurrentlyScrollingNode()->id, EXPECT_EQ(host_impl_->CurrentlyScrollingNode()->id,
grand_child->scroll_tree_index()); grand_child->scroll_tree_index());
...@@ -6866,7 +6866,7 @@ TEST_F(LayerTreeHostImplTest, ScrollWithoutBubbling) { ...@@ -6866,7 +6866,7 @@ TEST_F(LayerTreeHostImplTest, ScrollWithoutBubbling) {
EXPECT_EQ(InputHandler::SCROLL_ON_IMPL_THREAD, EXPECT_EQ(InputHandler::SCROLL_ON_IMPL_THREAD,
host_impl_ host_impl_
->ScrollBegin(BeginState(gfx::Point(1, 1)).get(), ->ScrollBegin(BeginState(gfx::Point(1, 1)).get(),
InputHandler::NON_BUBBLING_GESTURE) InputHandler::TOUCHSCREEN)
.thread); .thread);
EXPECT_EQ(grand_child->scroll_tree_index(), EXPECT_EQ(grand_child->scroll_tree_index(),
host_impl_->CurrentlyScrollingNode()->id); host_impl_->CurrentlyScrollingNode()->id);
...@@ -7638,7 +7638,7 @@ TEST_F(LayerTreeHostImplTest, OverscrollChildWithoutBubbling) { ...@@ -7638,7 +7638,7 @@ TEST_F(LayerTreeHostImplTest, OverscrollChildWithoutBubbling) {
EXPECT_EQ(InputHandler::SCROLL_ON_IMPL_THREAD, EXPECT_EQ(InputHandler::SCROLL_ON_IMPL_THREAD,
host_impl_ host_impl_
->ScrollBegin(BeginState(gfx::Point()).get(), ->ScrollBegin(BeginState(gfx::Point()).get(),
InputHandler::NON_BUBBLING_GESTURE) InputHandler::TOUCHSCREEN)
.thread); .thread);
scroll_result = scroll_result =
host_impl_->ScrollBy(UpdateState(gfx::Point(), scroll_delta).get()); host_impl_->ScrollBy(UpdateState(gfx::Point(), scroll_delta).get());
...@@ -7653,7 +7653,7 @@ TEST_F(LayerTreeHostImplTest, OverscrollChildWithoutBubbling) { ...@@ -7653,7 +7653,7 @@ TEST_F(LayerTreeHostImplTest, OverscrollChildWithoutBubbling) {
EXPECT_EQ(InputHandler::SCROLL_ON_IMPL_THREAD, EXPECT_EQ(InputHandler::SCROLL_ON_IMPL_THREAD,
host_impl_ host_impl_
->ScrollBegin(BeginState(gfx::Point(5, 5)).get(), ->ScrollBegin(BeginState(gfx::Point(5, 5)).get(),
InputHandler::NON_BUBBLING_GESTURE) InputHandler::TOUCHSCREEN)
.thread); .thread);
EXPECT_EQ(host_impl_->CurrentlyScrollingNode()->id, EXPECT_EQ(host_impl_->CurrentlyScrollingNode()->id,
grand_child_layer->scroll_tree_index()); grand_child_layer->scroll_tree_index());
...@@ -7662,7 +7662,7 @@ TEST_F(LayerTreeHostImplTest, OverscrollChildWithoutBubbling) { ...@@ -7662,7 +7662,7 @@ TEST_F(LayerTreeHostImplTest, OverscrollChildWithoutBubbling) {
EXPECT_EQ(InputHandler::SCROLL_ON_IMPL_THREAD, EXPECT_EQ(InputHandler::SCROLL_ON_IMPL_THREAD,
host_impl_ host_impl_
->ScrollBegin(BeginState(gfx::Point(5, 5)).get(), ->ScrollBegin(BeginState(gfx::Point(5, 5)).get(),
InputHandler::NON_BUBBLING_GESTURE) InputHandler::TOUCHSCREEN)
.thread); .thread);
scroll_result = scroll_result =
host_impl_->ScrollBy(UpdateState(gfx::Point(), scroll_delta).get()); host_impl_->ScrollBy(UpdateState(gfx::Point(), scroll_delta).get());
...@@ -7679,7 +7679,7 @@ TEST_F(LayerTreeHostImplTest, OverscrollChildWithoutBubbling) { ...@@ -7679,7 +7679,7 @@ TEST_F(LayerTreeHostImplTest, OverscrollChildWithoutBubbling) {
EXPECT_EQ(InputHandler::SCROLL_ON_IMPL_THREAD, EXPECT_EQ(InputHandler::SCROLL_ON_IMPL_THREAD,
host_impl_ host_impl_
->ScrollBegin(BeginState(gfx::Point(5, 5)).get(), ->ScrollBegin(BeginState(gfx::Point(5, 5)).get(),
InputHandler::NON_BUBBLING_GESTURE) InputHandler::TOUCHSCREEN)
.thread); .thread);
EXPECT_EQ(host_impl_->CurrentlyScrollingNode()->id, EXPECT_EQ(host_impl_->CurrentlyScrollingNode()->id,
grand_child_layer->scroll_tree_index()); grand_child_layer->scroll_tree_index());
...@@ -7799,7 +7799,7 @@ TEST_F(LayerTreeHostImplTest, NoOverscrollWhenNotAtEdge) { ...@@ -7799,7 +7799,7 @@ TEST_F(LayerTreeHostImplTest, NoOverscrollWhenNotAtEdge) {
EXPECT_EQ(InputHandler::SCROLL_ON_IMPL_THREAD, EXPECT_EQ(InputHandler::SCROLL_ON_IMPL_THREAD,
host_impl_ host_impl_
->ScrollBegin(BeginState(gfx::Point(0, 0)).get(), ->ScrollBegin(BeginState(gfx::Point(0, 0)).get(),
InputHandler::NON_BUBBLING_GESTURE) InputHandler::TOUCHSCREEN)
.thread); .thread);
EXPECT_EQ(InputHandler::SCROLL_ON_IMPL_THREAD, EXPECT_EQ(InputHandler::SCROLL_ON_IMPL_THREAD,
host_impl_->FlingScrollBegin().thread); host_impl_->FlingScrollBegin().thread);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment