Commit c4ed92c8 authored by donnd's avatar donnd Committed by Commit bot

Disable crashing unittests in background offliner.

Two unit tests are crashing a lot on Android, disabling those
tests in background_loader_offliner_unittest.cc for Android
only.

BUG=722556
TBR=dewittj@chromium.org

Review-Url: https://codereview.chromium.org/2891623002
Cr-Commit-Position: refs/heads/master@{#472286}
parent bbfd1d20
...@@ -236,6 +236,15 @@ void BackgroundLoaderOfflinerTest::OnCancel(const SavePageRequest& request) { ...@@ -236,6 +236,15 @@ void BackgroundLoaderOfflinerTest::OnCancel(const SavePageRequest& request) {
cancel_callback_called_ = true; cancel_callback_called_ = true;
} }
// Two tests crash roughly 20% of runs on Android. http://crbug.com/722556.
#if defined(OS_ANDROID)
#define MAYBE_FailsOnErrorPage DISABLED_FailsOnErrorPage
#define MAYBE_NoNextOnInternetDisconnected DISABLED_NoNextOnInternetDisconnected
#else
#define MAYBE_FailsOnErrorPage FailsOnErrorPage
#define MAYBE_NoNextOnInternetDisconnected NoNextOnInternetDisconnected
#endif
TEST_F(BackgroundLoaderOfflinerTest, TEST_F(BackgroundLoaderOfflinerTest,
LoadAndSaveBlockThirdPartyCookiesForCustomTabs) { LoadAndSaveBlockThirdPartyCookiesForCustomTabs) {
base::Time creation_time = base::Time::Now(); base::Time creation_time = base::Time::Now();
...@@ -464,7 +473,7 @@ TEST_F(BackgroundLoaderOfflinerTest, ReturnsOnWebContentsDestroyed) { ...@@ -464,7 +473,7 @@ TEST_F(BackgroundLoaderOfflinerTest, ReturnsOnWebContentsDestroyed) {
EXPECT_EQ(Offliner::RequestStatus::LOADING_FAILED, request_status()); EXPECT_EQ(Offliner::RequestStatus::LOADING_FAILED, request_status());
} }
TEST_F(BackgroundLoaderOfflinerTest, FailsOnErrorPage) { TEST_F(BackgroundLoaderOfflinerTest, MAYBE_FailsOnErrorPage) {
base::Time creation_time = base::Time::Now(); base::Time creation_time = base::Time::Now();
SavePageRequest request(kRequestId, kHttpUrl, kClientId, creation_time, SavePageRequest request(kRequestId, kHttpUrl, kClientId, creation_time,
kUserRequested); kUserRequested);
...@@ -489,7 +498,7 @@ TEST_F(BackgroundLoaderOfflinerTest, FailsOnErrorPage) { ...@@ -489,7 +498,7 @@ TEST_F(BackgroundLoaderOfflinerTest, FailsOnErrorPage) {
EXPECT_EQ(Offliner::RequestStatus::LOADING_FAILED, request_status()); EXPECT_EQ(Offliner::RequestStatus::LOADING_FAILED, request_status());
} }
TEST_F(BackgroundLoaderOfflinerTest, NoNextOnInternetDisconnected) { TEST_F(BackgroundLoaderOfflinerTest, MAYBE_NoNextOnInternetDisconnected) {
base::Time creation_time = base::Time::Now(); base::Time creation_time = base::Time::Now();
SavePageRequest request(kRequestId, kHttpUrl, kClientId, creation_time, SavePageRequest request(kRequestId, kHttpUrl, kClientId, creation_time,
kUserRequested); kUserRequested);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment