scanning: Add finalized strings for source options

Bug: 1059779
Change-Id: I9005fb60fdff0c38526411125614f6883ea3cbfa
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2527883
Commit-Queue: Jesse Schettler <jschettler@chromium.org>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>
Cr-Commit-Position: refs/heads/master@{#825651}

chromeos/chromeos_strings.grd

@@ -480,6 +480,15 @@ Try tapping the mic to ask me anything.
       <message name="IDS_SCANNING_APP_SOURCE_DROPDOWN_LABEL" desc="The label for the dropdown that displays available scan sources (e.g. flatbed, document feeder, etc.).">
         Source
       </message>
+      <message name="IDS_SCANNING_APP_ONE_SIDED_DOC_FEEDER_OPTION_TEXT" desc="The text displayed for the one-sided document feeder source option.">
+        Document Feeder (One-sided)
+      </message>
+      <message name="IDS_SCANNING_APP_TWO_SIDED_DOC_FEEDER_OPTION_TEXT" desc="The text displayed for the two-sided document feeder source option.">
+        Document Feeder (Two-sided)
+      </message>
+      <message name="IDS_SCANNING_APP_FLATBED_OPTION_TEXT" desc="The text displayed for the flatbed source option.">
+        Flatbed
+      </message>
       <message name="IDS_SCANNING_APP_FILE_TYPE_DROPDOWN_LABEL" desc="The label for the dropdown that displays available file types.">
         File type
       </message>

chromeos/chromeos_strings_grd/IDS_SCANNING_APP_FLATBED_OPTION_TEXT.png.sha1

+5c309079f2ca5c91edd96f11c21bd39e69a8bbc8
\ No newline at end of file

chromeos/chromeos_strings_grd/IDS_SCANNING_APP_ONE_SIDED_DOC_FEEDER_OPTION_TEXT.png.sha1

+5c309079f2ca5c91edd96f11c21bd39e69a8bbc8
\ No newline at end of file

chromeos/chromeos_strings_grd/IDS_SCANNING_APP_TWO_SIDED_DOC_FEEDER_OPTION_TEXT.png.sha1

+5c309079f2ca5c91edd96f11c21bd39e69a8bbc8
\ No newline at end of file

chromeos/components/scanning/resources/scanning_app_util.js

@@ -3,6 +3,7 @@
 // found in the LICENSE file.
 
 import {assertNotReached} from 'chrome://resources/js/assert.m.js';
+import {loadTimeData} from 'chrome://resources/js/load_time_data.m.js';
 
 /**
  * Converts a chromeos.scanning.mojom.ColorMode string to the corresponding enum
@@ -93,20 +94,19 @@ export function getPageSizeString(pageSize) {
  * @return {string}
  */
 export function getSourceTypeString(mojoSourceType) {
-  // TODO(jschettler): Replace with finalized i18n strings.
   switch (mojoSourceType) {
     case chromeos.scanning.mojom.SourceType.kFlatbed:
-      return 'Flatbed';
+      return loadTimeData.getString('flatbedOptionText');
     case chromeos.scanning.mojom.SourceType.kAdfSimplex:
-      return 'Document Feeder (Simplex)';
+      return loadTimeData.getString('oneSidedDocFeederOptionText');
     case chromeos.scanning.mojom.SourceType.kAdfDuplex:
-      return 'Document Feeder (Duplex)';
+      return loadTimeData.getString('twoSidedDocFeederOptionText');
     case chromeos.scanning.mojom.SourceType.kDefault:
-      return 'Default';
+      return loadTimeData.getString('defaultSourceOptionText');
     case chromeos.scanning.mojom.SourceType.kUnknown:
     default:
       assertNotReached();
-      return 'Unknown';
+      return loadTimeData.getString('defaultSourceOptionText');
   }
 }
 

chromeos/components/scanning/scanning_ui.cc

@@ -55,6 +55,7 @@ void AddScanningAppStrings(content::WebUIDataSource* html_source) {
       {"appTitle", IDS_SCANNING_APP_TITLE},
       {"colorModeDropdownLabel", IDS_SCANNING_APP_COLOR_MODE_DROPDOWN_LABEL},
       {"defaultSourceOptionText", IDS_SCANNING_APP_DEFAULT_SOURCE_OPTION_TEXT},
+      {"flatbedOptionText", IDS_SCANNING_APP_FLATBED_OPTION_TEXT},
       {"fileTypeDropdownLabel", IDS_SCANNING_APP_FILE_TYPE_DROPDOWN_LABEL},
       {"jpgOptionText", IDS_SCANNING_APP_JPG_OPTION_TEXT},
       {"moreSettings", IDS_SCANNING_APP_MORE_SETTINGS},
@@ -62,6 +63,8 @@ void AddScanningAppStrings(content::WebUIDataSource* html_source) {
       {"noScannersHelpLinkLabel", IDS_SCANNING_APP_NO_SCANNERS_HELP_LINK_LABEL},
       {"noScannersHelpText", IDS_SCANNING_APP_NO_SCANNERS_HELP_TEXT},
       {"noScannersText", IDS_SCANNING_APP_NO_SCANNERS_TEXT},
+      {"oneSidedDocFeederOptionText",
+       IDS_SCANNING_APP_ONE_SIDED_DOC_FEEDER_OPTION_TEXT},
       {"pdfOptionText", IDS_SCANNING_APP_PDF_OPTION_TEXT},
       {"pngOptionText", IDS_SCANNING_APP_PNG_OPTION_TEXT},
       {"pageSizeDropdownLabel", IDS_SCANNING_APP_PAGE_SIZE_DROPDOWN_LABEL},
@@ -72,7 +75,9 @@ void AddScanningAppStrings(content::WebUIDataSource* html_source) {
       {"scanToDropdownLabel", IDS_SCANNING_APP_SCAN_TO_DROPDOWN_LABEL},
       {"scannerDropdownLabel", IDS_SCANNING_APP_SCANNER_DROPDOWN_LABEL},
       {"selectFolderOption", IDS_SCANNING_APP_SELECT_FOLDER_OPTION},
-      {"sourceDropdownLabel", IDS_SCANNING_APP_SOURCE_DROPDOWN_LABEL}};
+      {"sourceDropdownLabel", IDS_SCANNING_APP_SOURCE_DROPDOWN_LABEL},
+      {"twoSidedDocFeederOptionText",
+       IDS_SCANNING_APP_TWO_SIDED_DOC_FEEDER_OPTION_TEXT}};
 
   for (const auto& str : kLocalizedStrings)
     html_source->AddLocalizedString(str.name, str.id);