Skip to content

GitLab

T
tangled
Commit c518ea79 authored by Georg Neis's avatar Georg Neis Committed by Commit Bot
Browse files
Options

Add tests for module instantiation errors due to ambiguous exports. 

Bug: v8:6649
Change-Id: I79555121ce72bef536ca99365cc5b12c3a6496df
Reviewed-on: https://chromium-review.googlesource.com/590369
Commit-Queue: Georg Neis <neis@chromium.org>
Reviewed-by: default avatarKouhei Ueno <kouhei@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491981}
parent 4a65b860
Hide whitespace changes
Inline Side-by-side
Showing with 96 additions and 0 deletions
third_party/WebKit/LayoutTests/external/wpt/html/semantics/scripting-1/the-script-element/module/instantiation-error-6.html 0 → 100644
View file @ c518ea79
<!DOCTYPE html>
<title>Handling of instantiation errors, 6</title>
<script src="/resources/testharness.js"></script>
<script src="/resources/testharnessreport.js"></script>
<script>
setup({allow_uncaught_exception: true});
window.log = [];
window.addEventListener("error", ev => log.push(ev.error));
const test_load = async_test(
"Test that ambiguous star exports lead to an instantiation error " +
"and that the correct module is blamed.");
// Concretely, instantiation-error-6a.js fails to instantiate because it
// requests a name from instantion-error-6b.js that is ambiguous there.
// instantiation-error-6b.js itself, however, is fine, and it instantiates
// and evaluates successfully.
window.addEventListener("load", test_load.step_func_done(ev => {
const exn = log[0];
assert_array_equals(log, [
exn, 1,
"instantiation-error-6c",
"instantiation-error-6d",
"instantiation-error-6b", 2
]);
assert_equals(exn.constructor, SyntaxError);
}));
function unreachable() { log.push("unexpected"); }
</script>
<script type="module" src="./instantiation-error-6a.js"
onerror="unreachable()" onload="log.push(1)"></script>
<script type="module" src="./instantiation-error-6b.js"
onerror="unreachable()" onload="log.push(2)"></script>
third_party/WebKit/LayoutTests/external/wpt/html/semantics/scripting-1/the-script-element/module/instantiation-error-6a.js 0 → 100644
View file @ c518ea79
import {foo} from "./instantiation-error-6b.js";
log.push("instantiation-error-6a");
third_party/WebKit/LayoutTests/external/wpt/html/semantics/scripting-1/the-script-element/module/instantiation-error-6b.js 0 → 100644
View file @ c518ea79
export * from "./instantiation-error-6c.js";
export * from "./instantiation-error-6d.js";
log.push("instantiation-error-6b");
third_party/WebKit/LayoutTests/external/wpt/html/semantics/scripting-1/the-script-element/module/instantiation-error-7.html 0 → 100644
View file @ c518ea79
<!DOCTYPE html>
<title>Handling of instantiation errors, 7</title>
<script src="/resources/testharness.js"></script>
<script src="/resources/testharnessreport.js"></script>
<script>
setup({allow_uncaught_exception: true});
window.log = [];
window.addEventListener("error", ev => log.push(ev.error));
const test_load = async_test(
"Test that ambiguous star exports lead to an instantiation error, " +
"even when discovered through a star export, and that the correct " +
"module is blamed.");
// This is a variation of instantiation-error-6.html (see the explanation
// there).
window.addEventListener("load", test_load.step_func_done(ev => {
const exn = log[0];
assert_array_equals(log, [
exn, 1,
"instantiation-error-7d",
"instantiation-error-7e",
"instantiation-error-7c",
"instantiation-error-7f",
"instantiation-error-7b", 2
]);
assert_equals(exn.constructor, SyntaxError);
}));
function unreachable() { log.push("unexpected"); }
</script>
<script type="module" src="./instantiation-error-7a.js"
onerror="unreachable()" onload="log.push(1)"></script>
<script type="module" src="./instantiation-error-7b.js"
onerror="unreachable()" onload="log.push(2)"></script>
third_party/WebKit/LayoutTests/external/wpt/html/semantics/scripting-1/the-script-element/module/instantiation-error-7a.js 0 → 100644
View file @ c518ea79
import {foo} from "./instantiation-error-7b.js";
log.push("instantiation-error-7a");
third_party/WebKit/LayoutTests/external/wpt/html/semantics/scripting-1/the-script-element/module/instantiation-error-7b.js 0 → 100644
View file @ c518ea79
export * from "./instantiation-error-7c.js";
export * from "./instantiation-error-7f.js";
log.push("instantiation-error-7b");
third_party/WebKit/LayoutTests/external/wpt/html/semantics/scripting-1/the-script-element/module/instantiation-error-7c.js 0 → 100644
View file @ c518ea79
export * from "./instantiation-error-7d.js";
export * from "./instantiation-error-7e.js";
log.push("instantiation-error-7c");
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment