Commit c5324012 authored by Nasko Oskov's avatar Nasko Oskov Committed by Commit Bot

Remove unused member of RenderViewHostImpl.

The render_view_termination_status_ is assigned, but never referenced.
This CL removes it, as it is unused code.

Bug: 566116
Change-Id: I40363c1fa9bf028c2fcd44e5e37e26efd4ec1a03
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1611245Reviewed-by: default avatarDaniel Cheng <dcheng@chromium.org>
Commit-Queue: Nasko Oskov <nasko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#659474}
parent 79ceb2c9
...@@ -2565,12 +2565,6 @@ void RenderFrameHostImpl::OnRenderProcessGone(int status, int exit_code) { ...@@ -2565,12 +2565,6 @@ void RenderFrameHostImpl::OnRenderProcessGone(int status, int exit_code) {
base::TerminationStatus termination_status = base::TerminationStatus termination_status =
static_cast<base::TerminationStatus>(status); static_cast<base::TerminationStatus>(status);
if (frame_tree_node_->IsMainFrame()) {
// Keep the termination status so we can get at it later when we
// need to know why it died.
render_view_host_->render_view_termination_status_ = termination_status;
}
if (base::FeatureList::IsEnabled(features::kCrashReporting)) if (base::FeatureList::IsEnabled(features::kCrashReporting))
MaybeGenerateCrashReport(termination_status, exit_code); MaybeGenerateCrashReport(termination_status, exit_code);
......
...@@ -227,7 +227,6 @@ RenderViewHostImpl::RenderViewHostImpl( ...@@ -227,7 +227,6 @@ RenderViewHostImpl::RenderViewHostImpl(
main_frame_routing_id_(main_frame_routing_id), main_frame_routing_id_(main_frame_routing_id),
is_waiting_for_close_ack_(false), is_waiting_for_close_ack_(false),
sudden_termination_allowed_(false), sudden_termination_allowed_(false),
render_view_termination_status_(base::TERMINATION_STATUS_STILL_RUNNING),
updating_web_preferences_(false), updating_web_preferences_(false),
has_notified_about_creation_(false), has_notified_about_creation_(false),
weak_factory_(this) { weak_factory_(this) {
......
...@@ -129,10 +129,6 @@ class CONTENT_EXPORT RenderViewHostImpl : public RenderViewHost, ...@@ -129,10 +129,6 @@ class CONTENT_EXPORT RenderViewHostImpl : public RenderViewHost,
const FrameReplicationState& replicated_frame_state, const FrameReplicationState& replicated_frame_state,
bool window_was_created_with_opener); bool window_was_created_with_opener);
base::TerminationStatus render_view_termination_status() const {
return render_view_termination_status_;
}
// Tracks whether this RenderViewHost is in an active state (rather than // Tracks whether this RenderViewHost is in an active state (rather than
// pending swap out or swapped out), according to its main frame // pending swap out or swapped out), according to its main frame
// RenderFrameHost. // RenderFrameHost.
...@@ -341,9 +337,6 @@ class CONTENT_EXPORT RenderViewHostImpl : public RenderViewHost, ...@@ -341,9 +337,6 @@ class CONTENT_EXPORT RenderViewHostImpl : public RenderViewHost,
// True if the render view can be shut down suddenly. // True if the render view can be shut down suddenly.
bool sudden_termination_allowed_; bool sudden_termination_allowed_;
// The termination status of the last render view that terminated.
base::TerminationStatus render_view_termination_status_;
// This is updated every time UpdateWebkitPreferences is called. That method // This is updated every time UpdateWebkitPreferences is called. That method
// is in turn called when any of the settings change that the WebPreferences // is in turn called when any of the settings change that the WebPreferences
// values depend on. // values depend on.
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment