Commit c5440805 authored by haraken@chromium.org's avatar haraken@chromium.org

Blink-in-JS: A very simple refactoring about a way to get a basename of an IDL file

Just a clean-up of idl_reader.py.

BUG=341031

Review URL: https://codereview.chromium.org/469253004

git-svn-id: svn://svn.chromium.org/blink/trunk@180333 bbb929c8-8fbe-4397-9dbb-9b2b20218538
parent 4f631455
...@@ -69,8 +69,8 @@ class IdlReader(object): ...@@ -69,8 +69,8 @@ class IdlReader(object):
ast = blink_idl_parser.parse_file(self.parser, idl_filename) ast = blink_idl_parser.parse_file(self.parser, idl_filename)
if not ast: if not ast:
raise Exception('Failed to parse %s' % idl_filename) raise Exception('Failed to parse %s' % idl_filename)
idl_name = os.path.basename(idl_filename) idl_file_basename, _ = os.path.splitext(os.path.basename(idl_filename))
definitions = IdlDefinitions(idl_name, ast) definitions = IdlDefinitions(idl_file_basename, ast)
# Validate file contents with filename convention # Validate file contents with filename convention
# The Blink IDL filenaming convention is that the file # The Blink IDL filenaming convention is that the file
...@@ -86,7 +86,6 @@ class IdlReader(object): ...@@ -86,7 +86,6 @@ class IdlReader(object):
'Expected exactly 1 definition in file {0}, but found {1}' 'Expected exactly 1 definition in file {0}, but found {1}'
.format(idl_filename, number_of_targets)) .format(idl_filename, number_of_targets))
target = targets[0] target = targets[0]
idl_file_basename, _ = os.path.splitext(os.path.basename(idl_filename))
if not target.is_partial and target.name != idl_file_basename: if not target.is_partial and target.name != idl_file_basename:
raise Exception( raise Exception(
'Definition name "{0}" disagrees with IDL file basename "{1}".' 'Definition name "{0}" disagrees with IDL file basename "{1}".'
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment