[iOS] Remove Drag-Drop EG Test Hook

The current EarlGrey version has the fix for the original issue. The
test hook is no longer required.

Bug: 1129058
Change-Id: Idf287df68d149c57f26b3e01e2936dc210acec82
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2544806Reviewed-by: edchin <edchin@chromium.org>
Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Commit-Queue: Sebastien Lalancette <seblalancette@chromium.org>
Cr-Commit-Position: refs/heads/master@{#828890}

ios/chrome/app/tests_fake_hook.mm

@@ -31,9 +31,6 @@ bool DisableUpdateService() {
 bool DisableMainThreadFreezeDetection() {
   return false;
 }
-bool DisableTableDragAndDrop() {
-  return false;
-}
 policy::ConfigurationPolicyProvider* GetOverriddenPlatformPolicyProvider() {
   return nullptr;
 }

ios/chrome/app/tests_hook.h

@@ -41,12 +41,6 @@ bool DisableUpdateService();
 // Return true if it should be disabled.
 bool DisableMainThreadFreezeDetection();
 
-// Returns true if drag-and-drop should be disabled in native table views (e.g.
-// Bookmarks, History).
-// TODO(crbug.com/1129058): Clean this up when EarlGrey allows interacting with
-// context menus that can be dragged.
-bool DisableTableDragAndDrop();
-
 // Returns a policy provider that should be installed as the platform policy
 // provider when testing. May return nullptr.
 policy::ConfigurationPolicyProvider* GetOverriddenPlatformPolicyProvider();

ios/chrome/browser/ui/bookmarks/bookmark_home_view_controller.mm

@@ -496,8 +496,7 @@ std::vector<GURL> GetUrlsToOpen(const std::vector<const BookmarkNode*>& nodes) {
     self.dragDropHandler.dropDelegate = self;
     self.tableView.dragDelegate = self.dragDropHandler;
     self.tableView.dropDelegate = self.dragDropHandler;
-    self.tableView.dragInteractionEnabled =
-        !tests_hook::DisableTableDragAndDrop();
+    self.tableView.dragInteractionEnabled = true;
   }
 
   // Configure the table view.

ios/chrome/browser/ui/history/history_table_view_controller.mm

@@ -199,8 +199,7 @@ const CGFloat kButtonHorizontalPadding = 30.0;
     self.dragDropHandler.origin = WindowActivityHistoryOrigin;
     self.dragDropHandler.dragDataSource = self;
     self.tableView.dragDelegate = self.dragDropHandler;
-    self.tableView.dragInteractionEnabled =
-        !tests_hook::DisableTableDragAndDrop();
+    self.tableView.dragInteractionEnabled = true;
   }
 
   // NavigationController configuration.

ios/chrome/browser/ui/reading_list/reading_list_table_view_controller.mm

@@ -231,8 +231,7 @@ ReadingListSelectionState GetSelectionStateForSelectedCounts(
     self.dragDropHandler.origin = WindowActivityReadingListOrigin;
     self.dragDropHandler.dragDataSource = self;
     self.tableView.dragDelegate = self.dragDropHandler;
-    self.tableView.dragInteractionEnabled =
-        !tests_hook::DisableTableDragAndDrop();
+    self.tableView.dragInteractionEnabled = true;
   }
 }
 

ios/chrome/browser/ui/recent_tabs/recent_tabs_table_view_controller.mm

@@ -183,11 +183,7 @@ API_AVAILABLE(ios(13.0))
     self.dragDropHandler.origin = WindowActivityRecentTabsOrigin;
     self.dragDropHandler.dragDataSource = self;
     self.tableView.dragDelegate = self.dragDropHandler;
-
-    // TODO(crbug.com/1129058): Clean this up when EarlGrey allows interacting
-    // with context menus that can be dragged.
-    self.tableView.dragInteractionEnabled =
-        !tests_hook::DisableTableDragAndDrop();
+    self.tableView.dragInteractionEnabled = true;
   }
 }
 

ios/chrome/test/earl_grey/eg_tests_hook.mm

@@ -42,10 +42,6 @@ bool DisableMainThreadFreezeDetection() {
   return true;
 }
 
-bool DisableTableDragAndDrop() {
-  return true;
-}
-
 policy::ConfigurationPolicyProvider* GetOverriddenPlatformPolicyProvider() {
   if (base::CommandLine::ForCurrentProcess()->HasSwitch(
           "com.apple.configuration.managed")) {