Skip to content

GitLab

T
tangled
Commit c55166de authored by Bence Béky's avatar Bence Béky Committed by Commit Bot
Browse files
Options

Roll src/net/third_party/quiche/src/ eede82b9b..e7415a5b8 (8 commits) 

https://quiche.googlesource.com/quiche.git/+log/eede82b9b785..e7415a5b8712

$ git log eede82b9b..e7415a5b8 --date=short --no-merges --format='%ad %ae %s'
2020-07-27 haoyuewang Simplify the usage of ack_frequency and ack_delay in quic_received_packet_manager. flag protected by gfe2_reloadable_flag_quic_simplify_received_packet_manager_ack.
2020-07-27 wub In quicconnection, revert to a previously validated mtu after a delay equivalent to the duration of three ptos. protected by --gfe2_reloadable_flag_quic_revert_mtu_after_two_ptos.
2020-07-27 fayang Deprecate gfe2_reloadable_flag_quic_always_send_earliest_ack.
2020-07-27 bnc Update goaway behavior. protected by gfe2_reloadable_flag_quic_http3_goaway_new_behavior.
2020-07-24 nharper Replace reloadable quic_enable_tls_resumption flag with restart flag
2020-07-24 fayang Do not enforce push promise arrive in order in http3. client side only, not protected.
2020-07-24 fayang Surface hpack decoder detailed error for header value too long, and put detailed error to quic connection close error details. only change connection close error detail, not protected.
2020-07-24 haoyuewang Reserve a few connection options for using gfe measured bandwidth data in cwnd bootstrapping. no behavior change and not flag protected.

Created with:
  roll-dep src/net/third_party/quiche/src src/third_party/quic_trace/src

Change-Id: I8273dc56d706086ab271aba32932635e99a3f552
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2321850Reviewed-by: default avatarZhongyi Shi <zhongyi@chromium.org>
Commit-Queue: Bence Béky <bnc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#792369}
parent ec59b868
Hide whitespace changes
Inline Side-by-side
Showing with 46 additions and 23 deletions
DEPS
View file @ c55166de
......@@ -322,7 +322,7 @@ vars = {
# Three lines of non-changing comments so that
# the commit queue can handle CLs rolling feed
# and whatever else without interference from each other.
'quiche_revision': 'eede82b9b785ad030686f73a15c9e04cfd24a494',
'quiche_revision': 'e7415a5b8712762e28b383b59d542763f5bbdfe4',
# Three lines of non-changing comments so that
# the commit queue can handle CLs rolling ios_webkit
# and whatever else without interference from each other.
......
components/domain_reliability/quic_error_mapping.cc
View file @ c55166de
......@@ -377,6 +377,10 @@ const struct QuicErrorMapping {
"quic.http_zero_rtt_resumption_settings_mismatch"},
{quic::QUIC_HTTP_ZERO_RTT_REJECTION_SETTINGS_MISMATCH,
"quic.http_zero_rtt_rejection_settings_mismatch"},
{quic::QUIC_HTTP_GOAWAY_INVALID_STREAM_ID,
"quic.quic_http_goaway_invalid_stream_id"},
{quic::QUIC_HTTP_GOAWAY_ID_LARGER_THAN_PREVIOUS,
"quic.quic_http_goaway_id_larger_than_previous"},
// QUIC_INVALID_APPLICATION_CLOSE_DATA was code 101. The code has been
// deprecated, but to keep the assert below happy, there needs to be
......
net/quic/quic_flags_list.h
View file @ c55166de
......@@ -78,10 +78,6 @@ QUIC_FLAG(int32_t, FLAGS_quic_lumpy_pacing_size, 2)
// pacing.
QUIC_FLAG(double, FLAGS_quic_lumpy_pacing_cwnd_fraction, 0.25f)
// Default enables QUIC ack decimation and adds a connection option to disable
// it.
QUIC_FLAG(bool, FLAGS_quic_reloadable_flag_quic_enable_ack_decimation, true)
// If true, QUIC offload pacing when using USPS as egress method.
QUIC_FLAG(bool, FLAGS_quic_restart_flag_quic_offload_pacing_to_usps2, false)
......@@ -267,7 +263,7 @@ QUIC_FLAG(bool,
false)
// If true, enables support for TLS resumption in QUIC.
QUIC_FLAG(bool, FLAGS_quic_reloadable_flag_quic_enable_tls_resumption_v2, false)
QUIC_FLAG(bool, FLAGS_quic_restart_flag_quic_enable_tls_resumption_v3, false)
// When true, QUIC's BBRv2 ignores inflight_lo in PROBE_BW.
QUIC_FLAG(bool, FLAGS_quic_reloadable_flag_quic_bbr2_ignore_inflight_lo, false)
......@@ -284,17 +280,10 @@ QUIC_FLAG(bool,
FLAGS_quic_restart_flag_quic_google_transport_param_omit_old,
true)
// If true, QUIC will free writer-allocated packet buffer if writer->WritePacket
// is not called.
QUIC_FLAG(bool, FLAGS_quic_reloadable_flag_quic_avoid_leak_writer_buffer, true)
// If true, the B2HI connection option limits reduction of inflight_hi to
// (1-Beta)*CWND.
QUIC_FLAG(bool, FLAGS_quic_reloadable_flag_quic_bbr2_limit_inflight_hi, false)
// If true, SendAllPendingAcks always send the earliest ACK.
QUIC_FLAG(bool, FLAGS_quic_reloadable_flag_quic_always_send_earliest_ack, true)
// If true, disable QUIC version h3-T050.
QUIC_FLAG(bool, FLAGS_quic_reloadable_flag_quic_disable_version_t050, false)
......@@ -345,10 +334,10 @@ QUIC_FLAG(bool, FLAGS_quic_reloadable_flag_quic_dont_pad_chlo, false)
QUIC_FLAG(
bool,
FLAGS_quic_reloadable_flag_quic_dispatcher_legacy_version_encapsulation,
false)
true)
// If true, update packet size when the first frame gets queued.
QUIC_FLAG(bool, FLAGS_quic_reloadable_flag_quic_update_packet_size, false)
QUIC_FLAG(bool, FLAGS_quic_reloadable_flag_quic_update_packet_size, true)
// If true, consider frame expansion when calculating extra padding bytes to
// meet minimum plaintext packet size required for header protection.
......@@ -359,23 +348,23 @@ QUIC_FLAG(bool, FLAGS_quic_reloadable_flag_quic_fix_extra_padding_bytes, false)
QUIC_FLAG(
bool,
FLAGS_quic_reloadable_flag_quic_do_not_close_stream_again_on_connection_close,
false)
true)
// If true, determine a serialized packet's fate before the packet gets
// serialized.
QUIC_FLAG(
bool,
FLAGS_quic_reloadable_flag_quic_determine_serialized_packet_fate_early,
false)
true)
// If true, take the largest acked packet into account when computing the sent
// packet number length.
QUIC_FLAG(bool, FLAGS_quic_reloadable_flag_quic_fix_packet_number_length, false)
QUIC_FLAG(bool, FLAGS_quic_reloadable_flag_quic_fix_packet_number_length, true)
// If true, retransmit unacked handshake data before PTO expiry.
QUIC_FLAG(bool,
FLAGS_quic_reloadable_flag_quic_retransmit_handshake_data_early,
false)
true)
// If true, improve Bbr2Sender::AdjustNetworkParameters by 1) do not inject a
// bandwidth sample to the bandwidth filter, and 2) re-calculate pacing rate
......@@ -389,7 +378,7 @@ QUIC_FLAG(
// mitigate RTT inflations.
QUIC_FLAG(bool,
FLAGS_quic_reloadable_flag_quic_coalesced_packet_of_higher_space,
false)
true)
// If true, record the received min_ack_delay in transport parameters to QUIC
// config.
......@@ -420,3 +409,32 @@ QUIC_FLAG(bool,
// If true, QUIC subclasses will no longer directly access stream_map for its
// content.
QUIC_FLAG(bool, FLAGS_quic_reloadable_flag_quic_do_not_use_stream_map, false)
// If true,
// server accepts GOAWAY (draft-28 behavior),
// client receiving GOAWAY with stream ID that is not client-initiated
// bidirectional stream ID closes connection with H3_ID_ERROR (draft-28
// behavior).
// Also, receiving a GOAWAY with ID larger than previously received closes
// connection with H3_ID_ERROR.
// If false,
// server receiving GOAWAY closes connection with H3_FRAME_UNEXPECTED
// (draft-27 behavior),
// client receiving GOAWAY with stream ID that is not client-initiated
// bidirectional stream ID closes connection with PROTOCOL_VIOLATION
// (draft-04 behavior),
// larger ID than previously received does not trigger connection close.
QUIC_FLAG(bool,
FLAGS_quic_reloadable_flag_quic_http3_goaway_new_behavior,
false)
// If true, QUIC connection will revert to a previously validated MTU (if
// exists) after two PTOs.
QUIC_FLAG(bool,
FLAGS_quic_reloadable_flag_quic_revert_mtu_after_two_ptos,
false)
// Simplify the ACK code in quic_received_packet_manager.
QUIC_FLAG(bool,
FLAGS_quic_reloadable_flag_quic_simplify_received_packet_manager_ack,
false)
net/spdy/buffered_spdy_framer.cc
View file @ c55166de
......@@ -49,7 +49,8 @@ void BufferedSpdyFramer::set_debug_visitor(
}
void BufferedSpdyFramer::OnError(
http2::Http2DecoderAdapter::SpdyFramerError spdy_framer_error) {
http2::Http2DecoderAdapter::SpdyFramerError spdy_framer_error,
std::string /*detailed_error*/) {
visitor_->OnError(spdy_framer_error);
}
......
net/spdy/buffered_spdy_framer.h
View file @ c55166de
......@@ -147,8 +147,8 @@ class NET_EXPORT_PRIVATE BufferedSpdyFramer
void set_debug_visitor(spdy::SpdyFramerDebugVisitorInterface* debug_visitor);
// spdy::SpdyFramerVisitorInterface
void OnError(
http2::Http2DecoderAdapter::SpdyFramerError spdy_framer_error) override;
void OnError(http2::Http2DecoderAdapter::SpdyFramerError spdy_framer_error,
std::string detailed_error) override;
void OnHeaders(spdy::SpdyStreamId stream_id,
bool has_priority,
int weight,
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment