💥 Copy initiator_params from OpenURLParams to LoadURLParams.
The reproduction steps for this crash are a bit complex - and they rely on a feature I'm implementing at the moment, but basically they involve clicking on an Android notification that calls client.focus and then client.navigate. The client.navigate call triggers the DCHECK at the start of initiator_origin). It looks like it isn't copied over in NavigationControllerImpl: :LoadURLWithParams (checking for a non-empty WebContentsDelegateAndroid: :OpenURLFromTab. Change-Id: Id7319d4cf107d8452d546cfe8e8af6af76628ba9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1849384Reviewed-by:Bo <boliu@chromium.org> Commit-Queue: Peter Conn <peconn@chromium.org> Cr-Commit-Position: refs/heads/master@{#704196}
Showing
Please register or sign in to comment