Commit c5760709 authored by Peter E Conn's avatar Peter E Conn Committed by Commit Bot

💥 Copy initiator_params from OpenURLParams to LoadURLParams.

The reproduction steps for this crash are a bit complex - and they rely
on a feature I'm implementing at the moment, but basically they involve
clicking on an Android notification that calls client.focus and then
client.navigate.

The client.navigate call triggers the DCHECK at the start of

initiator_origin). It looks like it isn't copied over in

NavigationControllerImpl: :LoadURLWithParams (checking for a non-empty
WebContentsDelegateAndroid: :OpenURLFromTab.
Change-Id: Id7319d4cf107d8452d546cfe8e8af6af76628ba9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1849384Reviewed-by: default avatarBo <boliu@chromium.org>
Commit-Queue: Peter Conn <peconn@chromium.org>
Cr-Commit-Position: refs/heads/master@{#704196}
parent 942d5843
......@@ -111,6 +111,7 @@ WebContents* WebContentsDelegateAndroid::OpenURLFromTab(
params.should_replace_current_entry;
load_params.is_renderer_initiated = params.is_renderer_initiated;
load_params.has_user_gesture = params.user_gesture;
load_params.initiator_origin = params.initiator_origin;
if (params.uses_post) {
load_params.load_type = content::NavigationController::LOAD_TYPE_HTTP_POST;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment